拉动变换_始终关闭...拉动请求

拉动变换

I was looking at a Well Known Open Source Project on GitHub today. It had like 978 Pull Requests. A "PR" means "hey here's some code I did for your project, you can PULL it from here and merge it into your code!"

我今天在GitHub上看一个知名的开源项目。 它有978个请求请求。 “ PR”的意思是“嘿，这是我为您的项目所做的一些代码，您可以从此处拉出它并将其合并到您的代码中！”

But these were Open Pull Requests. Pending. Limbo Pull Requests. Dating back to 2015.

但是这些是“开放拉取请求”。 待定。 凌波请求请求。 可以追溯到2015年。

为什么拉取请求保持打开状态？ (Why do Pull Requests stay open?)

Why do projects keep Pull Requests open? What's a reasonable amount of time? Here's a few thoughts.

为什么项目使“拉取请求”保持打开状态？ 合理的时间是多少？ 这里有一些想法。

• PR as Call to Action

  公关作为行动号召

  • PRs are a shout. They are HERE IS SOME CODE and they create work for the maintainer. They are needy things and require review and merging, but even worse, sometimes manual merging. Plus for folks new to Git and Open Source, asking them to "rebase on top of latest" may be enough for them to just give up.
    公关大喊。 它们是某些代码，它们为维护人员创建工作。 它们是有需要的东西，需要进行审查和合并，但更糟糕的是，有时是手动合并。 对于刚接触Git和开放源代码的人来说，要求他们“在最新消息基础上重新定位”可能足以使他们放弃。

• Fear of Closing

  闭幕恐惧

  • If you close a PR without merging it, it's a rejection. It's a statement that this work isn't going to be used, and there's always a chance that the person who did the work will feel pretty bad about it.
    如果您关闭PR而不合并它，那就是拒绝。 有一种说法是说这项工作将不会被使用，而且做这项工作的人总会对此感到非常难过。

• Abandoned

  弃

  • Sometimes the originator of the PR disappears. The PR is effectively abandoned. These should be closed after a time.
    有时，PR的创建者会消失。 公关实际上被放弃了。 这些应在一段时间后关闭。

• Opened so long they can't be merged

  打开太久了，它们无法合并

  • The problem with PRs that are open for long is that they become impossible to merge. The cost of understanding whether they are still relevant plus resolving the merge conflicts might be higher than the value of the PR itself.
    长期开放的PR的问题在于它们无法合并。 了解它们是否仍然相关以及解决合并冲突的成本可能高于PR本身的价值。

• Incorrectly created

  创建不正确

  • A PR originator may intent to change a single word (misspelling) but their PR changes CRs to LFs or Tabs to Spaces, it's a hassle.
    PR发起人可能打算更改单个单词(拼写错误)，但是他们的PR会将CR更改为LF或将制表符更改为空格，这很麻烦。

• Formatting

  格式化

  • It's generally considered poor form to send a PR out of the blue where one just ran a linter or formatter. If the project wanted that done they'd ask for it.
    通常，公关只是在运行了lint或formatter的情况下发出的PR太差了。 如果项目想要这样做，他们会要求它。

• Totally not aligned with Roadmap

  完全不符合路线图

  • If a PR shows up without context or communication, it may not be aligned with the direction of the project.
    如果PR在没有上下文或沟通的情况下出现，则可能与项目方向不一致。

• Surprise PR

  惊喜公关

  • Unfortunately some PRs show up out of the blue with major changes, file moves, or no context. If a PR wasn't asked for, or if a PR wasn't requested, or borne of an Issue, you'll likely have trouble pushing it through.
    不幸的是，一些PR出现了重大更改，文件移动或没有上下文，突然出现。 如果不要求提供PR，或者不要求提供PR，或带有问题，则可能无法顺利完成。

Thanks to Jon and Immo for their thoughts on this (likely incomplete) list. Jess Frazelle has a great post on "The Art of Closing" that I just found, and it includes a glorious gif from Glengarry Glen Ross where Always Be Closing comes from (warning, clip has dated and offensive language).

感谢Jon和Immo对这个清单(可能不完整)的想法。 我刚刚发现，杰西·弗雷泽(Jess Frazelle)在“闭幕的艺术”上有一篇很棒的文章，其中包括格伦加里·格伦·罗斯( Glengarry Glen Ross)的一幅精美的gif图像，其中“永远是闭幕”的来源(警告，剪辑已陈旧和令人反感的语言)。

Jess suggests a few ways to Always Be Closing.

杰西(Jess)提出了几种“永远关闭”的方法。

Two things that can help make your open source project successful AND stay tidy!

有两点可以帮助您的开源项目成功并保持整洁！

• including a CONTRIBUTING.md
  包括一个CONTRIBUTING.md

• • GitHub has some good guidance https://help.github.com/articles/setting-up-your-project-for-healthy-contributions/ and most of the dotnet repos have some decent contribution guidelines.

    GitHub上有一些很好的指南https://help.github.com/articles/setting-up-your-project-for-healthy-contributions/ ，大多数dotnet仓库都有一些不错的贡献准则。

  • I LOVE Gina Häußge's Contributing.md on her open source project "OctoPrint."

    我爱吉娜Häußge的Contributing.md她的开源项目“ OctoPrint 。”

• using Pull Request templates that give clear guidance on how to submit a successful pull request.
  使用请求请求模板，这些模板为如何成功提交请求提供了明确的指导。

• • https://help.github.com/articles/creating-a-pull-request-template-for-your-repository

    https://help.github.com/articles/creating-a-pull-request-template-for-your-repository

• Use bots to test and build PRs, sign CLAs (Contributor License Agreements) and move the ball forward.
  使用漫游器测试和构建PR，签署CLA(贡献者许可协议)并将球向前推进。

What do you think? Why do PRs stay open?

你怎么看？ 为什么PR保持开放状态？

---

---

Sponsor: Get home early, eat supper on time and coach your kids in soccer. Moving workloads to Azure just got easy with Azure NetApp Files. Sign up to Preview Azure NetApp Files!

赞助商：早点回家，准时吃晚饭，并指导孩子们踢足球。 使用Azure NetApp文件将工作负载转移到Azure变得很容易。 注册以预览Azure NetApp文件！

关于斯科特 (About Scott)

Scott Hanselman is a former professor, former Chief Architect in finance, now speaker, consultant, father, diabetic, and Microsoft employee. He is a failed stand-up comic, a cornrower, and a book author.

斯科特·汉塞尔曼(Scott Hanselman)是前教授，前金融首席架构师，现在是演讲者，顾问，父亲，糖尿病患者和Microsoft员工。 他是一位失败的单口相声漫画家，一个玉米种植者和一本书的作者。

About   关于 Newsletter 时事通讯

Hosting By 主持人

翻译自: https://www.hanselman.com/blog/always-be-closingpull-requests

拉动变换