【发布时间】:2021-10-24 09:54:08
【问题描述】:
我正在做一个项目来显示 json 数据并检查它们是否是闰年。
我正在尝试为 IsLeapYear 创建一个参数,以便在进行测试时传递一些 json 值,我尝试使用 User 指向结构的指针,所以我可以传入函数参数中的字段,但是没有用。
如何在函数参数中从 user.json 传入 json 数据,这样我可以更轻松地进行测试?
只是让您知道,我的测试文件中出现错误,因为我创建了 DateTest 字符串,但 IsLeapYear 不是字符串。
这是我的代码:
main.go:
package main
import (
"encoding/json"
"fmt"
"io/ioutil"
"log"
"os"
"time"
)
// Users struct which contains
// an array of users
type Users struct {
Users []User `json:"users"`
}
// User struct which contains a name
// a type and a list of social links
type User struct {
Firstname string `json:"fname"`
Secondname string `json:"lname"`
Date string `json:"date"`
}
var users Users
func Birthday() {
// Open our jsonFile
jsonFile, err := os.Open("users.json")
// if we os.Open returns an error then handle it
if err != nil {
fmt.Println(err)
}
fmt.Println("Successfully Opened users.json")
// defer the closing of our jsonFile so that we can parse it later on
defer jsonFile.Close()
// read our opened xmlFile as a byte array.
byteValue, _ := ioutil.ReadAll(jsonFile)
// we initialize our Users array
// we unmarshal our byteArray which contains our
// jsonFile's content into 'users' which we defined above
json.Unmarshal(byteValue, &users)
IsLeapYear(&users{Firstname: ""}, &users{Secondname: ""}) ---> passing the users fileds
}
func IsLeapYear(firstname *Users, secondname *Users) {
// we iterate through every user within our users array and
// print out the user Type, their name
for i := 0; i < len(users.Users); i++ {
date, err := time.Parse("2006/01/02", users.Users[i].Date)
if err != nil {
date, err = time.Parse("2006-01-02", users.Users[i].Date)
// date, err = time.Parse("2006 01 02", users.Users[i].Date)
if err != nil {
log.Fatal("unsupported date format:", err)
}
}
// check if the date is a leap year, ex: 29 is not a leap year but 28th is !
if date.Day()%400 == 0 || (date.Day()%4 == 0 && date.Day()%100 != 0) {
fmt.Println("User Date: " + users.Users[i].Date)
fmt.Println("User First Name: " + users.Users[i].Firstname)
fmt.Println("User Second Name: " + users.Users[i].Secondname)
fmt.Println(users.Users[i].Date, "is a Leap Year ✨ ✨ ✨")
fmt.Println("TODAY IS NOT YOUR BIRTHDAY, but it's a leap year..!!! ???? ???? ???? ")
fmt.Println("")
// checking if the date.day matches today's date
if date.Day() == time.Now().Day() {
fmt.Println("User Date: " + users.Users[i].Date)
fmt.Println("User First Name: " + users.Users[i].Firstname)
fmt.Println("User Second Name: " + users.Users[i].Secondname)
fmt.Println(users.Users[i].Date, "is a Leap Year ✨ ✨ ✨")
fmt.Println("TODAY IS YOUR BIRTHDAY AND A Leap YEAR, Happy birthday !!!???? ???? ???? ???? ")
// not ur birthday today because the date in the json doesn't match todays date
}
} else {
fmt.Println("User Date: " + users.Users[i].Date)
fmt.Println("User First Name: " + users.Users[i].Firstname)
fmt.Println("User Second Name: " + users.Users[i].Secondname)
fmt.Println(users.Users[i].Date, " is Not a Leap Year ???? ???? ???? ")
fmt.Println("Your Date is neither a leap year nor your birthday..!!! ????????????")
}
}
}
func main() {
Birthday()
}
user.json:
{
"users": [
{
"Fname": "Johnny",
"Lname":"mane",
"date":"1982/01/08"
},
{
"Fname": "Wayne",
"Lname":"Bruce",
"date":"1965/01/30"
},
{
"Fname": "Gaga",
"Lname":"Lady",
"date":"1986/03/08"
},
{
"Fname": "radio",
"Lname":"head",
"date":"1988/02/29"
},
{
"Fname": "Mario",
"Lname":"torres",
"date":"1996/09/04"
},
{
"Fname": "robert",
"Lname":"Alex",
"date":"1991/12/05"
},
{
"Fname": "Julia",
"Lname":"sevak",
"date":"1991-03-28"
},
{
"Fname": "feb",
"Lname":"robert",
"date":"1995-05-24"
},
{
"Fname": "Liam",
"Lname":"Noah",
"date":"2002-10-04"
},
{
"Fname": "karim",
"Lname":"salim",
"date":"2021/10/21"
},
{
"Fname": "ahmed",
"Lname":"mario",
"date":"2021-10-24"
}
]
}
BD_test.go:
package main
import (
"testing"
)
type dateTest struct {
firstname, lastname, expected string
}
var DateTests = []dateTest{
{"karim", "salim", "2001/09/24"},
{"neno", "torres", "2001/14/44"},
{"harry", "potter", "2011/10/02"},
}
func TestIsLeap(t *testing.T) {
for _, test := range DateTests {
output := IsLeapYear(test.firstname, test.lastname). ---> error here !
expectedLeap := test.expected
if output != expectedLeap {
t.Errorf("Output %q not equal to expected %q", output, expectedLeap)
}
}
}
【问题讨论】:
-
请举个小例子。
-
IsLeapYear输入参数完全不合逻辑,毫无意义。考虑到它们的类型,您不仅没有正确命名它们,而且函数的主体根本没有引用它们,一次也没有。如果函数不会使用“名字”“姓氏”参数,那么它们的意义何在? -
@mkopriva 是的,你绝对是对的,我已经被困在这里一段时间了,我编写了没有参数的函数,所以我不能进行单元测试,这就是我在玩的原因试图想出一个解决方案,但谢谢你,这对我来说绝对是愚蠢的! .....如果我想用这个功能进行单元测试,你会推荐我做什么!我应该再次重写代码吗?或者我应该将所有脚本放在一个函数中......我将函数分别划分为各自的任务!我认为这更好!
标签: unit-testing go