这个 Moq 单元测试应该（假）检索列表有什么问题？

Question

我正在尝试测试这种方法，该方法旨在从数据库中检索数据并将它们存储到 List 中。我制作了这个假列表，旨在通过该方法找到。但是，该方法取而代之的是检索实际数据库并返回实际数量。我错过了什么？

    public class GetAllPhonesTests
    {
        private readonly Mock<IRepository<Phone>> _mockPhoneRepository;
        private readonly IPhoneService _phoneService;

        private readonly List<Phone> _fakePhones = new()
        {
            new Phone() { Id = 1, Brand = "Herp", Type = "Police" },
            new Phone() { Id = 2, Brand = "Derp", Type = "Fireman" },
            new Phone() { Id = 3, Brand = "Zerp", Type = "Nurse" },
            new Phone() { Id = 4, Brand = "Flurp", Type = "Doctor" },
            new Phone() { Id = 5, Brand = "Terp", Type = "Teacher" }
        };

        public GetAllPhonesTests()
        {
            _mockPhoneRepository = new Mock<IRepository<Phone>>();
            _phoneService = new PhoneService(_mockPhoneRepository.Object);
        }

        [Fact]
        public void Should_ReturnFullList_When_Called()
        {
            //Arrange
            _mockPhoneRepository.Setup(x => x.GetRecords(It.IsAny<SqlCommand>())).Returns(_fakePhones);

            //Act
            List<Phone> actual = _phoneService.GetAllPhones();

            //Assert
            actual.Count.Should().Be(_fakePhones.Count); 
        }
    }

来自服务的其他内容：

        public List<Phone> GetAllPhones()
        {
            string query = "SELECT * FROM phones INNER JOIN Brands ON Brands.BrandID=phones.BrandId;";
            using (var command = new SqlCommand(query))
            {
                return (List<Phone>)GetRecords(command);
            }
        }

来自 repo 的其他内容：

        public IEnumerable<T> GetRecords(SqlCommand command)
        {
            SqlDataReader reader = null;
            List<T> list = new();

            try
            {
                command.Connection = _connection;
                _connection.Open();
                reader = command.ExecuteReader();
                while (reader.Read())
                {
                    list.Add(PopulateRecord(reader));
                }

                reader.NextResult();
                if (reader.HasRows)
                {
                    while (reader.Read())
                    {
                        GetDataCount(Convert.ToInt32(reader["Count"].ToString()));
                    }
                }
                Status(false, "");
            }
            catch (Exception ex)
            {
                Status(true, ex.Message);
            }
            finally
            {
                reader.Close();
                _connection.Close();
            }

            return list;
        }

Answer 1

我认为问题可能在于您的设置顺序，因为它应该在您将存储库对象添加到模拟服务之前完成。您可以尝试将其更改为：

public class GetAllPhonesTests
{
    private readonly Mock<IRepository<Phone>> _mockPhoneRepository;
    private readonly IPhoneService _phoneService;

    private readonly List<Phone> _fakePhones = new()
    {
        new Phone() { Id = 1, Brand = "Herp", Type = "Police" },
        new Phone() { Id = 2, Brand = "Derp", Type = "Fireman" },
        new Phone() { Id = 3, Brand = "Zerp", Type = "Nurse" },
        new Phone() { Id = 4, Brand = "Flurp", Type = "Doctor" },
        new Phone() { Id = 5, Brand = "Terp", Type = "Teacher" }
    };

    public GetAllPhonesTests()
    {
        _mockPhoneRepository = new Mock<IRepository<Phone>>();
        _mockPhoneRepository.Setup(x => x.GetRecords(It.IsAny<SqlCommand> 
         ())).Returns(_fakePhones);
        _phoneService = new PhoneService(_mockPhoneRepository.Object);
    }

    [Fact]
    public void Should_ReturnFullList_When_Called()
    {
        //Act
        List<Phone> actual = _phoneService.GetAllPhones();

        //Assert
        actual.Count.Should().Be(_fakePhones.Count); 
    }
}

您的服务也应该使用 DI 来获取使用的存储库实现，例如：

    private readonly IRepository<Phone> _phoneRepo;

    public PhoneService(IRepository<Phone> phoneRepo){
        _phoneRepo = phoneRepo;
    }

    public List<Phone> GetAllPhones()
    {
        string query = "SELECT * FROM phones INNER JOIN Brands ON Brands.BrandID=phones.BrandId;";
        using (var command = new SqlCommand(query))
        {
            return (List<Phone>)_phoneRepo.GetRecords(command);
        }
    }