使用多个 SUB 更好还是将所有代码放在一个 SUB 中更好

Question

我一直在通过论坛和 YouTube 自学 VBA。我编写了一些使用If 语句的代码。如果该声明为真，我可以选择调用另一个 SUB 或仅在同一个 SUB 中编写代码。我的问题是，如果我调用 SUB 并且它使用 MS Word，如果代码使用循环，它是否相当于启动 MS Word 然后退出并一次又一次地重新启动它？属于第二个 SUB 的部分我评论了，下面没有包含。

Option Explicit

Sub CreateWordDocEarlyBinding()
    'Declared Variables for Sub.
    Dim sourceDoc As String
    Dim lastRow As Long
    Dim rowLoop As Long

    'Adding code for MS Word here
    Dim WdApp As Application
    Set WdApp = New Word.Application

'Not sure I need this for any reason.    
Dim columnLoop As Long

    'Find last row.
    lastRow = Sheet1.Cells(Sheet1.Rows.Count, 1).End(xlUp).Row

    'Looping through column.
    For rowLoop = 2 To lastRow

         'Not sure I  need at this point for code.
         'columnLoop = Sheet1.Range(rowLoop, 1)

        'Checking cells for A Conditon.
        If Sheet1.Cells(rowLoop, 1).Value = "Test String 1" Then
            If Sheet1.Cells(rowLoop, 1).Offset(0, 1).Value >= 0.1 Then
                If Sheet1.Cells(rowLoop, 1).Offset(0, 1).Value < 1 Then
                    sourceDoc = "Test1.docx"
                    Call CreateNewSourceDoc(sourceDoc, WdApp)
                Else
                    sourceDoc = "Test2.docx"
                    Call CreateNewSourceDoc(sourceDoc, WdApp)
                End If

            End If

        'Checking cells for B condition.
        ElseIf Sheet1.Cells(rowLoop, 1).Value = "Test String 2" Then
            If Sheet1.Cells(rowLoop, 1).Offset(0, 1).Value >= 0.5 Then
                If Sheet1.Cells(rowLoop, 1).Offset(0, 1).Value < 5 Then
                    sourceDoc = "Test3.docx"
                    Call CreateNewSourceDoc(sourceDoc, WdApp)
                Else
                    sourceDoc = "Test4.docx"
                    Call CreateNewSourceDoc(sourceDoc, WdApp)
                End If
            End If



        End If

    'Checking next row.
    Next

    WdApp.Quit
    Set WdApp = Nothing
End Sub

我在这里添加了第二个 SUB 的代码以进行澄清。这段代码每次循环时都会创建一个新的 word 实例吗？如果是这样，我最好去掉下面的SUB。

Sub CreateNewSourceDoc(sourceDoc As String, WdApp As Application)

    'Declaring variables
    Dim newFolderName As String
    Dim newFilePath As String
    'Source folder
     filePath = ThisWorkbook.Path & "\"

     'New Folder
      newFolderName = Sheet1.Cells(rowLoop, 1) & " " & Sheet1.Cells(rowLoop, 2)
      MkDir filePath & newFolderName

      'New file path
            newFilePath = filePath & newFolderName & "\"

     'I commented the below code out to see if it is correct.
    'Set WdApp = New Word.Application

    With WdApp

              .Visible = False

              '.Activate

              .Documents.Open filePath & sourceDoc

              .ActiveDocument.SaveAs2 Filename:=newFilePath & Sheet1.Cells(rowLoop, 1) & " " & Sheet1.Cells(rowLoop, 2) & ".docx"


          End With

          sourceDoc = vbNullString

End Sub

Answer 1

问题中的代码是正确的。

Word.Application (WdApp) 在“主”子 CreateWordDocEarlyBinding 中启动，并在那里退出并清理。

WdApp 连同使用的文档一起被传递给第二个 Sub 进行处理。

我注意到还有一件事可以在第二个过程（Sub）中进行优化：

我将为正在打开的文档声明并实例化一个 Word.Document 对象，然后保存，而不是“匿名”打开文档，然后依靠 ActiveDocument 成为正确的文档。所以...

Sub CreateNewSourceDoc(sourceDoc As String, WdApp As Application)

    'Declaring variables
    Dim newFolderName As String
    Dim newFilePath As String
    Dim wdDoc as Word.Document

     'New Folder
      newFolderName = Sheet1.Cells(rowLoop, 1) & " " & Sheet1.Cells(rowLoop, 2)
      MkDir filePath & newFolderName

     'New file path
     newFilePath = filePath & newFolderName & "\"

     With WdApp   
          .Visible = False
          Set wdDoc = .Documents.Open(filePath & sourceDoc)
          wdDoc.SaveAs2 Filename:=newFilePath & Sheet1.Cells(rowLoop, 1) & _
                        " " & Sheet1.Cells(rowLoop, 2) & ".docx"  
     End With

     sourceDoc = vbNullString
     Set wdDoc = Nothing
End Sub