将 cell.value 从一个范围传递到另一个子

Question

我有以下代码：

Dim WS1, WS2 As Worksheet
Dim chatRange As Range
Dim cell As Range
Dim txt As String
    
Sub NameTest()
    
    Set WS1 = ActiveWorkbook.Sheets("Page 1")
    Set WS2 = ActiveWorkbook.Sheets("Sheet1")
    x = 2
    lRow1 = WS1.Cells(Rows.Count, "B").End(xlUp).Row
    
    Set chatRange = WS1.Range("B" & x, "B" & lRow1)
    
    For Each cell In chatRange
        If cell.Offset(0, 11).Value = "Accepted" Then
            txt = cell.Offset(0, 18).Value
            NameSplit
        End If
    Next cell
    
End Sub

Sub NameSplit()
    Dim i As Integer
    Dim FullName As Variant
    Dim x As String, cell As Range
    Dim lRow2 As Long

    FullName = RemoveBlankLines(Split(txt, vbLf))
    lRow2 = WS2.Cells(Rows.Count, 2).End(xlUp).Row + 1
    WS2.Cells(lRow2, 1).Value = cell.Value                 '<===================
    WS2.Cells(lRow2, 2).Value = cell.Offset(0, 2).Value    '<===================
    WS2.Cells(lRow2, 3).Value = cell.Offset(0, 6).Value    '<===================
    WS2.Cells(lRow2, 4).Value = cell.Offset(0, 18).Value   '<===================
End Sub

这是读取一张纸然后将信息传递给另一张纸的测试代码的一部分。

我想使用第一个 sub 中设置的范围内的“单元格”中的信息来传输第二个 sub 中的详细信息。它适用于在顶部声明的 WS1 和 WS2，但它对范围的作用不同。

带箭头的四行是我正在努力解决的部分。 cell.value 回来了：

运行时错误“91”：对象变量或未设置块变量

我知道最好的办法是把它全部放在一个潜艇上，但如果可能的话，我想把它分开。

Answer 1

始终使用Option Explicit，尽管在这种情况下它不会突出显示问题。

如前所述，您将cell 声明为范围（在 NameSplit 函数中第二次），但从未设置它。这就是你至少得到错误的原因..

正如其他人提到的，如果您先声明它们，您可以轻松地将这些值传递给您的其他子。查看基于您的示例（未经测试）代码：

Option Explicit
'Use global variables only if really needed, but was a good try.

Sub NameTest()
    Dim WS1 As Worksheet, WS2 As Worksheet
    Dim chatRange As Range
    Dim cell As Range
    Dim txt As String

    Set WS1 = ActiveWorkbook.Sheets("Page 1")
    Set WS2 = ActiveWorkbook.Sheets("Sheet1")

    x = 2

    lRow1 = WS1.Cells(WS1.Rows.Count, "B").End(xlUp).row

    Set chatRange = WS1.Range("B" & x, "B" & lRow1)

    For Each cell In chatRange
        If cell.Offset(0, 11).Value = "Accepted" Then
            txt = cell.Offset(0, 18).Value
            Call NameSplit(WS2, cell, txt)
        End If

    Next cell

End Sub

Sub NameSplit(wsDest As Worksheet, rngCell As Range, strTxt As String)    'You can pass any objects through. By default they are passed ByRef (search for ByRef vs ByVal)
    Dim i As Integer
    Dim FullName As Variant
    Dim x As String
    Dim lRow2 As Long

    FullName = RemoveBlankLines(Split(strTxt, vbLf))
    lRow2 = WS2.Cells(WS2.Rows.Count, 2).End(xlUp).row + 1

    wsDest.Cells(lRow2, 1).Value = rngCell.Value
    wsDest.Cells(lRow2, 2).Value = rngCell.Offset(0, 2).Value
    wsDest.Cells(lRow2, 3).Value = rngCell.Offset(0, 6).Value
    wsDest.Cells(lRow2, 4).Value = rngCell.Offset(0, 18).Value
End Sub

编辑： 完全限定 Rows.Count 到 WS1.Rows.Count 和分别 WS2.Rows.Count 以防止错误，并更正评论中的默认值。 （感谢@chris neilsen 指出）。

Answer 2

你的NameSplit() 过程应该这样声明：

Sub NameSplit(WS2 as Worksheet, cell as Range)
'
'
'your code here
'
'
End Sub

它应该像这样调用：

call NameSplit(WS2, cell)

您可以从NameSplit() 的声明中删除cell as Range