通过输入 HashMap 值获取 HashMap 键未按预期工作

Question

问题出在方法getName()

public class Phonebook implements PhonebookInterface {

    private Map<String, Set<String>> phonebook;
    private Map<String, Address> address;

    public Phonebook() {
        this.phonebook = new HashMap<String, Set<String>>();
        this.address = new HashMap<String, Address>();
    }

    @Override
    public void addNumber(String person, String number) {
        if (!this.phonebook.containsKey(person)) {
            this.phonebook.put(person, new HashSet<String>());
        }

        this.phonebook.get(person).add(number);
    }

    @Override
    public void getName(String number) {
        for (String person : this.phonebook.keySet()) {
            if (this.phonebook.get(person).contains(number)) {
                System.out.println(" " + person);
            } else {
                System.out.println("  not found");
            }
        }
    }

    @Override
    public void getNumber(String person) {
        try {
            for (String n : this.phonebook.get(person)) {
                if (this.phonebook.get(person).size() > 1) {
                    System.out.println(" " + n);
                } else {
                    System.out.println("number: " + n);
                }
            }
        } catch (Exception e) {
            System.out.println("  not found");
        }
    }

    public void addAddress(String person, String street, String city) {
        this.address.put(person, new Address(street, city));
    }

    public void getInfo(String person) {
        if (this.address.containsKey(person)) {
            System.out.println("  address: " + this.address.get(person));

            if (this.phonebook.containsKey(person)) {
                System.out.println("  phone numbers:");
                for (String n : this.phonebook.get(person)) {
                    System.out.println("  " + n);
                }
            } else {
                System.out.println("  phone number not found");
            }
        } else {
            System.out.println("  not found");
        }
    }

    public void removeInfo(String person) {
        if (this.address.containsKey(person)) {
            this.address.remove(person);
        } else {
            System.out.println(" not found");
        }
    }
}

public class Address {

    private String street;
    private String city;

    public Address() {
    }

    Address(String street, String city) {
        this.street = street;
        this.city = city;
    }

    public String getStreet() {
        return this.street;
    }

    public String getCity() {
        return this.city;
    }

    public String toString() {
        return this.street + " " + this.city;
    }

}

class Main {

    public static void main(String[] args) {
        Phonebook p = new Phonebook();

        System.out.println("Search for number: ");

        System.out.println("Pekka :");
        p.addNumber("Pekka", "014-1234");
        p.addNumber("Pekka", "015-5344");
        p.getNumber("Pekka");

        System.out.println("Matti :");
        p.addNumber("Matti", "013-4321");
        p.getNumber("Matti");

        System.out.println("\nsearch for a person by phone number: ");

        p.getName("013-4321");
        p.getName("1234567");
    }
}

预期的输出是：

搜索号码：
佩卡：
014-1234
015-5344
马蒂：
电话：013-4321

通过电话号码搜索某人：
马蒂
没找到

但输出是：

搜索号码：
佩卡：
014-1234
015-5344
马蒂：
电话：013-4321

通过电话号码搜索某人：
没找到
马蒂
没找到
没找到

为什么输出打印“not found” 3 次而不是一次？

Answer 1

您遍历Map 的所有键并将相应的值与您要查找的值进行比较。如果没有匹配，则打印“未找到”。

您的 Map 有两个键，因此如果您正在搜索 Map 中存在的值，您将打印匹配的键，但您也会为另一个键打印“未找到”。

如果您正在搜索 Map 中不存在的值，您将打印两次“未找到”（每个键一次）。

您应该只在遍历所有键后打印“未找到”：

public void getName(String number) {   
    for (String person : this.phonebook.keySet()) {   
        if (this.phonebook.get(person).contains(number)) {   
            System.out.println(" " + person);
            return;
        }    
    }
    System.out.println("  not found"); 
}