【发布时间】:2019-02-24 11:04:31
【问题描述】:
在对性能至关重要的代码中,给了我 2 个大矩阵,(大小以千计)
期望, 实现
大小相同但包含不同的值。这些矩阵都以相同的方式在列上进行分区, 每个子矩阵都有不同数量的列。像这样的
submat1 submat2 submat3
-----------------------------
|...........| .......| .....|
|...........| .......| .....|
|...........| .......| .....|
|...........| .......| .....|
|...........| .......| .....|
-----------------------------
我需要通过以下方式填充第三个矩阵的最快方法 (伪代码)
for each submatrix
for each row in submatrix
pos= argmax(expectations(row,start_submatrix(col):end_submatrix(col)))
result(row,col) = realization(row,pos)
也就是说,对于每个子矩阵,我扫描每一行,找到期望子矩阵中最大元素的位置, 并将实现矩阵的对应值放入结果矩阵中。
我希望以最快的方式实现这一点,也许是通过智能并行化/缓存优化,因为我在算法上花费了大约 40% 的时间。 我使用 Visual Studio 15.9.6 和 Windows 10。
这是我的参考 C++ 实现,我使用 Armadillo(列优先)矩阵
#include <iostream>
#include <chrono>
#include <vector>
///Trivial implementation, for illustration purposes
void find_max_vertical_trivial(const arma::mat& expectations, const arma::mat& realizations, arma::mat& results, const arma::uvec & list, const int max_size_action)
{
const int number_columns_results = results.n_cols;
const int number_rows = expectations.n_rows;
#pragma omp parallel for schedule(static)
for (int submatrix_to_process = 0; submatrix_to_process < number_columns_results; submatrix_to_process++)
{
const int start_loop = submatrix_to_process * max_size_action;
//Looping over rows
for (int current_row = 0; current_row < number_rows; current_row++)
{
int candidate = start_loop;
const int end_loop = candidate + list(submatrix_to_process);
//Finding the optimal action
for (int act = candidate + 1; act < end_loop; act++)
{
if (expectations(current_row, act) > expectations(current_row, candidate))
candidate = act;
}
//Placing the corresponding realization into the results
results(current_row, submatrix_to_process) = realizations(current_row, candidate);
}
}
}
这是我能想到的最快的方法。可以改进吗?
///Stripped all armadillo functionality, to bare C
void find_max_vertical_optimized(const arma::mat& expectations, const arma::mat& realizations, arma::mat& values, const arma::uvec & list, const int max_block)
{
const int n_columns = values.n_cols;
const int number_rows = expectations.n_rows;
const auto exp_ptr = expectations.memptr();
const auto real_ptr = realizations.memptr();
const auto values_ptr = values.memptr();
const auto list_ptr = list.memptr();
#pragma omp parallel for schedule(static)
for (int col_position = 0; col_position < n_columns; col_position++)
{
const int start_loop = col_position * max_block*number_rows;
const int end_loop = start_loop + list_ptr[col_position]*number_rows;
const int position_value = col_position * number_rows;
for (int row_position = 0; row_position < number_rows; row_position++)
{
int candidate = start_loop;
const auto st_exp = exp_ptr + row_position;
const auto st_real = real_ptr + row_position;
const auto st_val = values_ptr + row_position;
for (int new_candidate = candidate + number_rows; new_candidate < end_loop; new_candidate+= number_rows)
{
if (st_exp[new_candidate] > st_exp[candidate])
candidate = new_candidate;
}
st_val[position_value] = st_real[candidate];
}
}
}
还有测试部分,我比较性能的地方
typedef std::chrono::microseconds dur;
const double dur2seconds = 1e6;
//Testing the two methods
int main()
{
const int max_cols_submatrix = 6; //Typical size: 3-100
const int n_test = 500;
const int number_rows = 2000; //typical size: 1000-10000
std::vector<int> size_to_test = {4,10,40,100,1000,5000 }; //typical size: 10-5000
arma::vec time_test(n_test, arma::fill::zeros);
arma::vec time_trivial(n_test, arma::fill::zeros);
for (const auto &size_grid : size_to_test) {
arma::mat expectations(number_rows, max_cols_submatrix*size_grid, arma::fill::randn);
arma::mat realizations(number_rows, max_cols_submatrix*size_grid, arma::fill::randn);
arma::mat reference_values(number_rows, size_grid, arma::fill::zeros);
arma::mat optimized_values(number_rows, size_grid, arma::fill::zeros);
arma::uvec number_columns_per_submatrix(size_grid);
//Generate random number of columns per each submatrices
number_columns_per_submatrix= arma::conv_to<arma::uvec>::from(arma::vec(size_grid,arma::fill::randu)*max_cols_submatrix);
for (int i = 0; i < n_test; i++) {
auto st_meas = std::chrono::high_resolution_clock::now();
find_max_vertical_trivial(expectations, realizations, optimized_values, number_columns_per_submatrix, max_cols_submatrix);
time_trivial(i) = std::chrono::duration_cast<dur>(std::chrono::high_resolution_clock::now() - st_meas).count() / dur2seconds;;
st_meas = std::chrono::high_resolution_clock::now();
find_max_vertical_optimized(expectations, realizations, reference_values, number_columns_per_submatrix, max_cols_submatrix);
time_test(i) = std::chrono::duration_cast<dur>(std::chrono::high_resolution_clock::now() - st_meas).count() / dur2seconds;
const auto diff = arma::sum(arma::sum(arma::abs(reference_values - optimized_values)));
if (diff > 1e-3)
{
std::cout <<"Error: " <<diff << "\n";
throw std::runtime_error("Error");
}
}
std::cout <<"grid size:"<< size_grid << "\n";
const double mean_time_trivial = arma::mean(time_trivial);
const double mean_time_opt = arma::mean(time_test);
std::cout << "Trivial: "<< mean_time_trivial << " s +/-" << 1.95*arma::stddev(time_trivial) / sqrt(n_test) <<"\n";
std::cout << "Optimized: "<< mean_time_opt <<" s ("<< (mean_time_opt/ mean_time_trivial-1)*100.0 <<" %) "<<"+/-" << 1.95*arma::stddev(time_test) / sqrt(n_test) << "\n";
}
}
【问题讨论】:
-
您有问题吗?
-
可能所有代码都阻塞了问题。我想提高我的代码的速度。我能够改进一点,但不多(15-30%)
-
如果我对问题的理解正确,您只需触摸输入数据的每个元素一次(与 matmul 不同,它是 O(N^3) 对 O(N^2) 个元素进行处理) ,并且您按顺序执行此操作,因此缓存阻塞没有用。在结果矩阵中,每个列范围都填充了一个重复值(输入矩阵中该范围内的最大值)。我希望编译器可以很好地自动向量化,使用 SSE2 或 AVX
maxps(float) 或 SSE4pmaxd(int) 进行扫描,然后存储整个向量。但是你说你有列主矩阵? -
是的,不幸的是,如果矩阵采用这种格式,生成这些矩阵的整个过程会更快。我还尝试转置它们(可以通过阻塞很好地完成),然后执行算法,但结果总体上似乎较慢。
-
您可以使用 SIMD 循环优化缓存,该循环可能读取 8 或 12 个完整的行向量,然后下一列的相同行。 (因此对于 32 位元素,并行 8*4 或 8*8 行)。如果您从对齐边界开始,那么希望您读取所有您接触的每个缓存行。但是希望您在一个块中的列足够少,当您循环回它时,用找到的最大值重写数据在 L1d 或至少 L2 缓存中仍然很热。 (所以你正在读取 2 到 6 个连续的缓存行,在读/写块之间有一个跨步。)