将多个 CTE 与一个 INSERT 语句一起使用。 [错误：列列表中的列多于指定的列]

Question

我有如下 CTE1 和 CTE2。 CTE2显示错误

CTE2 has more columns than specified in the column list

我想知道我做错了什么。这不可能是因为 Insert 语句的列数比 CTE2 多，因为 CTE1 之前工作正常。 CTE1 和 CTE2 都使用不同的表。是这个问题吗？

如果我删除CTE2(NewRoomCost,NewQuantity) 中的参数，则会出现错误

No Columns specified for Column3 of CTE2

以下是我尝试过的代码。任何帮助将不胜感激。

CREATE PROCEDURE dbo.SpTransactionGenerate
AS
BEGIN
SET NOCOUNT ON

    DECLARE @MinReservationId INT = (SELECT MIN(f.ReservationId) FROM dbo.Reservation AS f)
    DECLARE @MaxReservationId INT = (SELECT MAX(f.ReservationId) FROM dbo.Reservation AS f)

    DECLARE @FirstSeasonEndDate DATE= '2018-02-13';
    DECLARE @SecondSeasonEndDate DATE='2018-02-14';
    DECLARE @ThirdSeasonEndDate DATE='2018-12-31';

    WHILE @MinReservationId<=@MaxReservationId
    BEGIN   
        WITH CTE1(ServiceId,ServiceRate,Quantity) AS 
        (
           SELECT ServiceId,
                  ServiceRate,
                  ABS(CHECKSUM(NEWID())%3) + 1 AS Quantity 
           FROM dbo.[Service]                              
        ),
        CTE2(NewRoomCost,NewQuantity) AS 
        (
           SELECT 
                (SELECT roomRate.RoomCost FROM dbo.RoomRate as roomRate WHERE roomRate.RoomTypeId=
                (SELECT room.RoomTypeId FROM dbo.Room as room
                JOIN dbo.Reservation as res ON res.RoomId=room.RoomId WHERE res.ReservationId=@MinReservationId
                AND roomRate.SeasonId=(
                CASE WHEN (SELECT resv.CheckInDate FROM dbo.Reservation as resv WHERE resv.ReservationId=@MinReservationId)<=@FirstSeasonEndDate
                THEN (SELECT sea.SeasonId FROM dbo.Season as sea WHERE sea.SeasonEndDate=@FirstSeasonEndDate)
                WHEN (SELECT resv.CheckInDate FROM dbo.Reservation as resv WHERE resv.ReservationId=@MinReservationId)<=@SecondSeasonEndDate
                THEN (SELECT sea.SeasonId FROM dbo.Season as sea WHERE sea.SeasonEndDate=@SecondSeasonEndDate)
                ELSE (SELECT sea.SeasonId FROM dbo.Season as sea WHERE sea.SeasonEndDate=@ThirdSeasonEndDate) END
                )
                )) AS NewRoomCost,

                DATEDIFF(DAY,(SELECT r.CheckinDate FROM dbo.Reservation AS r WHERE r.ReservationId=@MinReservationId), (SELECT r.CheckOutDate FROM dbo.Reservation AS r WHERE r.ReservationId=@MinReservationId)) AS NewQuantity,                                                  
        )

        INSERT INTO dbo.[Transaction]
        (
            ReservationId,
            ServiceId,
            Rate,
            Quantity,
            Amount              
        )   
        SELECT 
            @MinReservationId,
            ServiceId,
            ServiceRate,
            Quantity,
            ServiceRate*Quantity
            FROM CTE1
            UNION
        SELECT 
            @MinReservationId,
            NULL,
            NewRoomCost,
            NewQuantity,
            NewRoomCost*NewQuantity
            FROM CTE2

        SELECT @MinReservationId=@MinReservationId+1    
    END
END

更新：由于 CTE2 中有一个额外的逗号导致错误。很抱歉提出了不必要的问题。

Answer 1

CTE2 中的问题是您在此行末尾多了一个逗号：

DATEDIFF(DAY,(SELECT r.CheckinDate FROM dbo.Reservation AS r WHERE r.ReservationId=@MinReservationId), (SELECT r.CheckOutDate FROM dbo.Reservation AS r WHERE r.ReservationId=@MinReservationId)) AS NewQuantity, 

旁注：我建议以后不要写明确的列名，而只是像使用 AS 关键字那样命名它们。它只是总体上提供了更大的灵活性。

Answer 2

因为您的第二个 CTE 定义了两列：

CTE2(NewRoomCost,NewQuantity) AS

但是您的 select 语句返回 3。

(SELECT roomRate.RoomCost FROM...

DATEDIFF(DAY,(SELECT r.CheckinDate...

(SELECT r.CheckOutDate FROM dbo.Reservation...