我应该总是处理参考返回向量吗？

Question

不确定here 发生了什么：

#include <iostream>
#include <vector>

class Voice
{
public:
    double mValue = 0.0;

    Voice() { }
    Voice(const Voice &copy) {
    }    
};

class VoiceManager
{
public:
    std::vector<Voice> mVoices;

    VoiceManager() {
        mVoices = std::vector<Voice>(numVoices, Voice());   

        for (int i = 0; i < numVoices; i++) {
            mVoices[i].mValue = 100.0;
        }        
    }

private:
    int numVoices = 16;    
};

int main()
{    
    VoiceManager voiceManager;
    Voice voice = voiceManager.mVoices[2];
    std::cout << voice.mValue << std::endl;
}

我为每个Voice 设置了mValue，其值为100，运算符为[]，但是当我尝试使用相同的[] 运算符检索对象时，它似乎返回的不是那个元素？它打印 0。

相反，如果我这样做：

Voice &voice = voiceManager.mVoices[2];

我终于可以看到更新的值了。

这里发生了什么？

Answer 1

如 cmets 所示，您的复制构造函数 a) 错误 b) 多余

class Voice
{
public:
    double mValue = 0.0;

    // don't provide default constructor, unless you have another constructor
    // use compiler-generated copy-constructor
};

class VoiceManager
{
    int numVoices = 16;    // move up here so that member-initialization works
public:
    std::vector<Voice> mVoices;

    VoiceManager() 
    :
        mVoices(numVoices) // member-initialize
    {
        for (int i = 0; i < numVoices; i++) {
            mVoices[i].mValue = 100.0;
        }        
    }
};

int main()
{    
    VoiceManager voiceManager;
    Voice voice = voiceManager.mVoices[2];
    std::cout << voice.mValue << std::endl;
}

Live Example

请注意，我还使用成员初始化语法对 VoiceManager 的构造函数进行了小幅清理。

至于另一个问题：初始化

Voice voice = voicemanager.mVoice[2]; 

实际上调用了你的复制构造函数

Voice(voicemanager.mVoice[2]);

（这里的= 符号并不意味着赋值！）