【发布时间】:2017-03-31 20:14:16
【问题描述】:
我应该实现一个包含数学表达式的二叉树,对每个二元或一元表达式使用不同的类。 例如:
Expression e = new Sin(
new Pow(
new Mul(
new Plus(
new Mul(new Num(2), new Var("x")),
new Var("y")),
new Num(4)),
new Var("x")));
树的叶子可以是变量或数字。每个变量都可以使用以下方法转换为另一个表达式:
Expression assign(String var, Expression expression)
我有 2 个用于一元和二元运算符的抽象类。
我在弄清楚如何将相同的表达式分配给表达式本身的变量之一时遇到了困难。例如:
Expression e1 = new Plus(1,"x");
e1.assign("x", e1);
System.out.println(e1.toString());
输出应该是:
((x+1)+1)
实际发生的是表达式的左侧部分指向自身,这导致了无限循环。有没有办法复制对象但使用不同的指针来避免它?或者也许是一种不同的方式来实现“分配”方法的工作方式?
这是我的实现:
BinaryExpression 类:
import java.util.List;
import java.util.Map;
abstract public class BinaryExpression extends BaseExpression implements Expression {
protected Expression first, second;
public BinaryExpression(Expression first, Expression second) {
this.setSecond(second);
this.setFirst(first);
}
public BinaryExpression(double number1, double number2) {
this(new Num(number1), new Num(number2));
}
public BinaryExpression(double number, String variable) {
this(new Num(number), new Var(variable));
}
public BinaryExpression(String variable, double number) {
this(new Var(variable), new Num(number));
}
public BinaryExpression(String variable1, String variable2) {
this(new Var(variable1), new Var(variable2));
}
public BinaryExpression(Expression expression, String variable) {
this(expression , new Var(variable));
}
public BinaryExpression(double number, Expression expression) {
this(new Num(number), expression);
}
public BinaryExpression(Expression expression, double number) {
this(expression, new Num(number));
}
public BinaryExpression(String variable, Expression expression) {
this(new Var(variable), expression);
}
public Expression getSecond() {
return second;
}
public void setSecond(Expression second) {
this.second = second;
}
public Expression getFirst() {
return first;
}
public void setFirst(Expression first) {
this.first = first;
}
public double evaluate(Map<String, Double> assignment) throws Exception {
try {
return operate(first.evaluate(assignment), second.evaluate(assignment));
} catch (Exception e) {
throw new Exception(e.getMessage());
}
}
abstract public double operate(double first, double second) throws Exception;
public List<String> getVariables() {
java.util.List<String> firstList, secondList;
firstList = this.first.getVariables();
secondList = this.second.getVariables();
for (int i = 0; i < secondList.size(); i++) {
boolean seen = false;
for (int j = 0; j < firstList.size(); j++) {
if (((String) firstList.get(j)).equals((String) secondList.get(i))) {
seen = true;
break;
}
}
if (!seen) {
firstList.add(secondList.get(i));
}
}
return firstList;
}
public Expression assign(String var, Expression expression) {
this.first = first.assign(var, expression);
this.second = second.assign(var, expression);
return this;
}
abstract public String operator();
public String toString() {
return "(" + this.first.toString() +
this.operator() +
this.second.toString() + ")";
}
}
变量类:
import java.util.ArrayList;
import java.util.List;
import java.util.Map;
public class Var implements Expression {
private String variable;
/**
* setting the desired variable.
* @param variable the variable to set
*/
public Var(String variable) {
this.variable = variable;
}
/**
* getting the variable string.
* @return the variable string
*/
public String getVariable() {
return variable;
}
/**
* setting the variable string.
* @param newVariable the string we want to set.
*/
public void setVariable(String newVariable) {
this.variable = newVariable;
}
@Override
public double evaluate(Map<String, Double> assignment) throws Exception {
if (assignment.containsKey(this.variable)) {
return assignment.get(this.variable);
} else {
throw new Exception("variable wasn't assigned");
}
}
@Override
public double evaluate() throws Exception {
throw new Exception("variable wasn't assigned");
}
@Override
public List<String> getVariables() {
java.util.List<String> singleVariable = new ArrayList<String>();
singleVariable.add(this.variable);
return singleVariable;
}
@Override
public Expression assign(String var, Expression expression) {
if (var.equals(this.variable)) {
return expression;
} else {
return this;
}
}
public String toString() {
return this.variable;
}
}
数字类:
import java.util.ArrayList;
import java.util.List;
import java.util.Map;
public class Num implements Expression {
private double value;
/**
* creating a new number.
* @param number the value to set.
*/
public Num(double number) {
this.setValue(number);
}
/**
* getting the number's value.
* @return the value to set.
*/
public double getValue() {
return value;
}
/**
* setting a new number.
* @param newValue the number to set.
*/
public void setValue(double newValue) {
this.value = newValue;
}
@Override
public double evaluate(Map<String, Double> assignment) {
return getValue();
}
@Override
public double evaluate() {
return getValue();
}
@Override
public List<String> getVariables() {
java.util.List<String> emptyList = new ArrayList<String>();
return emptyList;
}
@Override
public Expression assign(String var, Expression expression) {
return this;
}
public String toString() {
return Double.toString(this.value);
}
}
感谢任何形式的帮助。
我在这里添加我得到的错误:
Exception in thread "main" java.lang.StackOverflowError
at sun.misc.FloatingDecimal$BinaryToASCIIBuffer.dtoa(Unknown Source)
at sun.misc.FloatingDecimal$BinaryToASCIIBuffer.access$100(Unknown Source)
at sun.misc.FloatingDecimal.getBinaryToASCIIConverter(Unknown Source)
at sun.misc.FloatingDecimal.getBinaryToASCIIConverter(Unknown Source)
at sun.misc.FloatingDecimal.toJavaFormatString(Unknown Source)
at java.lang.Double.toString(Unknown Source)
at Num.toString(Num.java:50)
at BinaryExpression.toString(BinaryExpression.java:94)
at BinaryExpression.toString(BinaryExpression.java:94)
at BinaryExpression.toString(BinaryExpression.java:96)
at BinaryExpression.toString(BinaryExpression.java:94)
at BinaryExpression.toString(BinaryExpression.java:96)
at BinaryExpression.toString(BinaryExpression.java:94)
at BinaryExpression.toString(BinaryExpression.java:96)
at BinaryExpression.toString(BinaryExpression.java:94)
at BinaryExpression.toString(BinaryExpression.java:96)
at BinaryExpression.toString(BinaryExpression.java:94)
at BinaryExpression.toString(BinaryExpression.java:96)
at BinaryExpression.toString(BinaryExpression.java:94)
at BinaryExpression.toString(BinaryExpression.java:96)...
下面是 Plus 类中 clone 方法的一个例子:
public Expression clone() {
Expression newFirst = this.first, newSecond = this.second;
return new Plus(newFirst, newSecond);
}
我试图通过更改分配的 Var 方法来使用它:
public Expression assign(String var, Expression expression) {
if (var.equals(this.variable)) {
return expression.clone();
} else {
return this;
}
}
此外,在更改 var 中的方法后,我还尝试通过更改分配方法来修复它,但使用另一个函数不起作用:
public Expression assignHelp(String var, Expression expression) {
this.first = first.assignHelp(var, expression);
this.second = second.assignHelp(var, expression);
return this;
}
public Expression assign(String var, Expression expression) {
return assignHelp(var, expression.clone());
}
【问题讨论】:
-
为什么需要分配方法而不是创建一个新表达式?
-
如果 Expression 实现了 Clonable 你可以调用 expression.clone()。
-
我尝试通过为每个类创建一个克隆方法来做到这一点: Expression clone() { return new Expression(this.first, this.second);并在 var 类 reurning expression.clone() 中的 assign 方法中,但它不起作用,我不知道为什么。
-
我认为问题在于您没有对您的表达式进行深层复制,即,您还应该克隆
this.first和this.second,然后再将它们分配给您的新表达式。 -
@Ryan:您只是将
this.first分配给一个临时变量,而不是创建一个新实例。相反,你应该写newFirst = this.first.clone()(类似于右子树)。
标签: java math recursion binary-tree