【问题标题】:Infinite Loop in JavaScript - While LoopJavaScript 中的无限循环 - While 循环
【发布时间】:2016-02-16 15:59:46
【问题描述】:

有谁知道为什么这可能会导致无限循环。我就是不明白为什么!

我觉得问题可能出在我的 while 循环播放到五个。

while 循环应在 5 处停止,当玩家或计算机到达此位置时,游戏应停止。

这是石头、纸、剪刀。每场比赛的结果是玩家获胜、计算机获胜或平局。

游戏应在任一玩家达到 5 胜后结束。

问题是游戏没有按预期结束!

function getInput() {
  console.log("Please choose either 'rock', 'paper', or 'scissors'.");
  return prompt("Please choose either 'rock', 'paper', or 'scissors'");
}

function getPlayerMove() {
  return getInput();
}

function randomPlay() {
  var randomNumber = Math.random();
  if (randomNumber < 0.33) {
      return "rock";
  } 
  else if (randomNumber < 0.66) {
    return "paper";
  } 
  else {
    return "scissors";
  }
}


function getComputerMove() {
  return randomPlay();
}

function getWinner(playerMove,computerMove) {
  var winner;
  if (playerMove === 'rock' && computerMove === 'scissors') {  
    winner = 'Player';
  }  
  else if (playerMove === 'scissors' && computerMove === 'paper') {
    winner='Player';
  }  
  else if (playerMove === 'paper' && computerMove === 'rock') {
    winner='Player';
  } 
  else if (playerMove === 'paper' && computerMove === 'scissors') {
    winner='Computer';
  }  
  else if (playerMove === 'rock' && computerMove === 'paper') {
    winner='Computer';
  }  
  else if (playerMove === 'scissors' && computerMove === 'rock') {
    winner = 'Computer';
  }  
  else { 
  winner = "tie";
  }
  return winner;
}

// A big limitation of this game is the user is only allowed to choose once! To allow more choices you'd need to design the program differently 

function playToFive() {
  var playerWins = 0;
  var computerWins = 0;
  var playerMove = getPlayerMove();
  while ((playerWins <= 5) || (computerWins <= 5)) {
    var computerMove = getComputerMove();
    var winner = getWinner(getPlayerMove, getComputerMove);
    console.log('The player has chosen ' + playerMove + '. The computer has chosen ' + computerMove);
    if (winner === "player") {
        playerWins += 1; 
    } 
    else if (winner === "computer") {
        computerWins += 1;
    } 
    if ((playerWins = 5) || (computerWins = 5)) {
        console.log("The game is over! " + "The " + winner + " has taken out the game!");
        console.log("The final score was. " + playerWins + " to " + computerWins);
    }
    else {
        console.log("The " + winner + ' takes the round. It is now ' + playerWins + ' to ' + computerWins);
    }
  }
}

playToFive ();

【问题讨论】:

  • 如果循环应该在 either 玩家达到 5 时结束,则比较应该是 &lt;,并且测试应该与 &amp;&amp; 结合,而不是 ||。使用||,只要 loser 小于或等于 5,循环就会继续。
  • if ((playerWins = 5) || (computerWins = 5)) 应该是if ((playerWins == 5) || (computerWins == 5))

标签: javascript


【解决方案1】:

问题是这条线

var winner = getWinner(getPlayerMove, getComputerMove);

您正在将函数引用传递给 getWinner() 方法

var winner = getWinner(playerMove , computerMove );

这意味着您需要稍后再次移动,因此将您的方法更改为(在您的代码中修复了多个问题)

function playToFive() 
{
  var playerWins = 0;
  var computerWins = 0;
  while ((playerWins <= 5) && (computerWins <= 5))  //this line has && instead of ||
  {
    var computerMove = getComputerMove(); 
    var playerMove = getPlayerMove(); //this line is now inside while loop
    var winner = getWinner( playerMove , computerMove );
    console.log('The player has chosen ' + playerMove + '. The computer has chosen ' + computerMove);
    if (winner === "Player") { //P caps
        playerWins += 1; 
    } 
    else if (winner === "Computer") { //C caps
        computerWins += 1;
    } 
    if ((playerWins == 5) || (computerWins == 5)) { //= is replaced by ==
        console.log("The game is over! " + "The " + winner + " has taken out the game!");
        console.log("The final score was. " + playerWins + " to " + computerWins);
    }
    else {
        console.log("The " + winner + ' takes the round. It is now ' + playerWins + ' to ' + computerWins);
    }
  }
}

【讨论】:

    【解决方案2】:

    为了让 if 相应地运行:

    if ((playerWins = 5) || (computerWins = 5)) {}
    

    您需要使用== 运算符,因为只有一个= 用于赋值。

    if ((playerWins == 5) || (computerWins == 5)) {}
    

    【讨论】:

      【解决方案3】:

      首先在 while 循环中,您还需要将其更改为 && 语句,否则如果计算机为 8 且玩家为 3,则循环将继续,直到两个玩家都>5。

      【讨论】:

        【解决方案4】:

        我认为首先您应该了解 (==) 和 (===) here 之间的区别。

        使用此代码(条件代码不赋值)

         if ((playerWins == 5) || (computerWins == 5)) { //use logical Operator not assignment Oprtr.
                console.log("The game is over! " + "The " + winner + " has taken out the game!");
                console.log("The final score was. " + playerWins + " to " + computerWins);
            }
        

        而不是##

         if ((playerWins = 5) || (computerWins = 5)) { // Error Code.
                    console.log("The game is over! " + "The " + winner + " has taken out the game!");
                    console.log("The final score was. " + playerWins + " to " + computerWins);
                }
        

        问题是这条行

        您正在将函数引用传递给 getWinner() 方法

        使用这个

         var winner = getWinner(playerMove , computerMove );
        

        而不是

         var winner = getWinner(getPlayerMove, getComputerMove);
        

        对于这个函数...

        function getWinner(playerMove,computerMove) {
          var winner;
          if (playerMove === 'rock' && computerMove === 'scissors') {  
            winner = 'Player';
          }  
          else if (playerMove === 'scissors' && computerMove === 'paper') {
            winner='Player';
          }  
          else if (playerMove === 'paper' && computerMove === 'rock') {
            winner='Player';
          } 
          else if (playerMove === 'paper' && computerMove === 'scissors') {
            winner='Computer';
          }  
          else if (playerMove === 'rock' && computerMove === 'paper') {
            winner='Computer';
          }  
          else if (playerMove === 'scissors' && computerMove === 'rock') {
            winner = 'Computer';
          }  
          else { 
          winner = "tie";
          }
          return winner;
        }
        

        此方法每次都将tie设置为获胜者。

        但是你应该知道(==) equalto和(===) equal value and equal type之间的区别here

        【讨论】:

          【解决方案5】:

          谢谢各位。有很多问题。

          干杯,伙计们。绝对需要 && 而不是 ||。 ||甚至导致游戏继续进行

          还需要 var Winner = getWinner(getPlayerMove, getComputerMove)。这导致了无限循环。

          【讨论】:

          • 不要发布另一个只是概括别人告诉你的答案,相应地投票和接受。
          猜你喜欢
          • 1970-01-01
          • 1970-01-01
          • 1970-01-01
          • 2014-03-29
          • 2015-06-25
          • 2012-12-24
          • 2013-02-22
          • 2011-11-19
          • 1970-01-01
          相关资源
          最近更新 更多