【发布时间】:2020-11-02 17:31:51
【问题描述】:
我对 C++ 还很陌生,到目前为止,我正试图从这些令人筋疲力尽的错误消息中弄清楚。我真的陷入了这个困境,这真的毫无意义。我在下面分享的代码是我正在处理的个人有向图头文件的一部分。我不会分享所有内容,因为它有点长,其他部分似乎与我的问题无关。但如果需要请指定,我会分享。现在下面的功能是评估顶点(即节点)是否可以从给定的根顶点到达。它采用迭代定义的深度优先搜索来做到这一点。
代码可以编译,但我在运行时不断收到此错误消息,这完全没有意义,因为它似乎是由将 int 推送到 std::stack 引起的(当我注释掉我这样做的行时,代码运行)。这样 it->first 是一个 int。它是我的邻接列表中的一个索引,它的类型为 std::unordered_map,也代表一个顶点 ID。
到目前为止,我尝试了两种不同的方法。我将它->first 分配给一个单独的 int id 变量并尝试以这种方式推送它。我尝试将 std::stack 更改为 std::stack
我正在使用 Visual Studio 2017 和 MSVC 编译器。
顶点类:
template <typename T>
class Vertex {
private:
int id; //Id of the vertex
double weight; //Weight of the vertex
T data; //Custom data to be stored inside the vertex
public:
Vertex() {} //Default constructor.
Vertex(int x, double y, T d) : id(x), weight(y), data(d) {} //Constructor with custom data type T
Vertex(int x, double y) : id(x), weight(y) {} //Alternative constructor without type T, for graph use only
int getId() { return id; }
double getWeight() { return weight; }
T getData() { return data; }
};
DirectedGraph 类(抽象):
template <typename T>
class DirectedGraph {
private:
std::unordered_map<int, Vertex<T>> vertices; //Stores vertices
std::unordered_map<int, std::unordered_map<int, double>> adj_list; //Stores the graph in adjacency list format. Inner-most double type variable stores edge weight.
size_t n_edges; //Stores total number of edges
size_t n_vertices; //Stores total number of vertices
int is_acyclic; //Variable to record if the graph is acyclic or not. Convention for this is following, 1: Graph is acyclic, 0: Graph is not acyclic, -1: Not tested yet
public:
DirectedGraph();
~DirectedGraph();
bool contains(const int&) const; //Returns true if the graph contains the given vertex_id, false otherwise.
bool adjacent(const int&, const int&); //Returns true if the first vertex is adjacent to the second, false otherwise.
void addVertex(Vertex<T>&); //Adds the passed in vertex to the graph (with no edges).
void addEdge(const int&, const int&, const double&); //Adds a weighted edge from the first vertex to the second.
void removeVertex(const int&); //Removes the given vertex. Should also clear any incident edges.
void removeEdge(const int&, const int&); //Removes the edge between the two vertices, if it exists.
size_t inDegree(const int&); //Returns number of edges coming in to a vertex.
size_t outDegree(const int&); //Returns the number of edges leaving a vertex.
size_t degree(const int&); //Returns the degree of the vertex (both in edges and out edges).
size_t numVertices(); //Returns the total number of vertices in the graph.
size_t numEdges() const; //Returns the total number of edges in the graph.
std::unordered_map<int, Vertex<T>> getVertices(); //Returns a vector containing all the vertices.
Vertex<T> getVertex(const int& u_id); //Retruns specified vertex. If vertex doesn't exist, the id and weight of the returned vertex are both -1.
double getEdgeWeight(const int& u_id, const int& v_id); //Returns the weight of the specified edge. If the edge doesn't exist, it returns -1.
std::vector<Vertex<T>> getNeighbours(const int&); //Returns a vector containing all the vertices reachable from the given vertex. The vertex is not considered a neighbour of itself.
std::vector<Vertex<T>> getSecondOrderNeighbours(const int&); // Returns a vector containing all the second_order_neighbours (i.e., neighbours of neighbours) of the given vertex.
// A vector cannot be considered a second_order_neighbour of itself.
bool reachable(const int&, const int&); //Returns true if the second vertex is reachable from the first (can you follow a path of out-edges to get from the first to the second?). Returns false otherwise.
bool containsCycles(); // Return true if the graph contains cycles (there is a path from any vertices directly/indirectly to itself), false otherwise.
std::vector<Vertex<T>> depthFirstTraversal(const int&); //Returns the vertices of the graph in the order they are visited in by a depth-first traversal starting at the given vertex.
std::vector<Vertex<T>> breadthFirstTraversal(const int&); //Returns the vertices of the graph in the order they are visited in by a breadth-first traversal starting at the given vertex.
/*
* Following function is an iterative implementation of Dijkstra's SP algorithm.
* It returns a pair consisting of an array of shortest distances to all other
* vertices from the given root vertex u_id (vertices are identified via
* indexes in the array such that shortest distance to vertex i is placed to
* the i th element in the array), and a "previous vertex" unordered_map. (If
* you are unsure about what a "previous vertex" list is,
* see https://en.wikipedia.org/wiki/Dijkstra%27s_algorithm)
*/
std::pair<int *, std::unordered_map<int, int>> dijkstra(int u_id);
std::pair<int, std::vector<Vertex<T>>> shortestPath(int u_id, int v_id); //This function finds the shortest path to a single given target vertex (v_id) from a given vertex (u_id) as a pair that contains <distance, path>
std::vector<std::vector<Vertex<T>>> stronglyConnectedComponents(); //Identifies and returns strongly connected components as a vector of vectors
std::vector<Vertex<T>> topologicalSort(); //Returns a topologically sorted list of the graph. It requires the graph to be acyclic. If the graph isn't acyclic, it returns an empty vector.
};
reachable() 函数(我遇到问题的那个):
template <typename T>
bool DirectedGraph<T>::reachable(const int& u_id, const int& v_id)
{
//This function is a Depth First Search Algorithm that halts when latter vertex is found
//Returns true if v_id is reachable from u_id
std::stack<int> track; //Stack for DFS
bool* visited = new bool[numVertices()]{};
track.push(u_id);
while (!track.empty())
{
bool found = false;
auto it = adj_list[track.top()].begin();
while (it != adj_list[track.top()].end() && !found)
{
if (!visited[it->first])
{
if (it->first == v_id)
{
delete[] visited;
return true;
}
visited[it->first] = true;
track.push(it->first);// <--When I comment out this line, the code runs.
found = true;
}
++it;
}
if (!found) { track.pop(); }
}
delete[] visited;
return false;
}
完整的错误信息:
调试断言失败!
Filec:\program files(x86)\microsoft visual studio\2017\community\vc\tools\msvc\14.15.26726\include\list
线路:240
表达式:列表迭代器不兼容
【问题讨论】:
-
可能你在某个地方越界了。这是学习如何使用 Visual Studio 出色的调试器的绝佳机会。
-
可能
it->first不在您期望的范围内。我的建议是将访问更改为向量并使用 at() 成员。 -
我不知道这是否与您的问题有关,但您的
Vertex默认 ctor 不会初始化任何成员。 -
bool* visited = new bool[numVertices()]{};-- 为什么不std::vector<bool> visited(numVerticies());? -
while (it != adj_list[track.top()].end() && !found)-- 你在每次迭代中添加到track,从而改变track.top()。如果没有adj_list[track.top()],可能会发生错误。此外,返回向量、列表或映射的函数都不会返回对实际向量、列表或映射的引用——而是返回副本。也许这也是错误的一个原因。
标签: c++ visual-studio visual-studio-2017 c++17 stdstack