【发布时间】:2018-07-27 03:46:41
【问题描述】:
我正在使用 xUnit 对返回 ActionResult<T> 的 ASP.NET Core 2.1 控制器方法进行单元测试。控制器类装饰有[ApiController] 属性,以便该方法在实时运行时自动执行模型验证。但是,控制器方法不会在我的单元测试中自动触发模型验证,我不知道为什么。
这是我的单元测试。
[Fact]
public async Task post_returns_400_when_model_is_invalid()
{
// arrange
var mockHttpClientFactory = new Mock<IHttpClientFactory>();
var mockHttpMessageHandler = new Mock<FakeHttpMessageHandler> {CallBase = true};
mockHttpMessageHandler.Setup(mock => mock.Send(It.IsAny<HttpRequestMessage>()))
.Returns(new HttpResponseMessage(HttpStatusCode.Accepted)
{
Content = new StringContent("{\"response\": {\"numFound\": 0, \"start\": 0, \"docs\": []}}")
});
var httpClient =
new HttpClient(mockHttpMessageHandler.Object)
{
BaseAddress = new Uri("http://localhost:8983/"),
DefaultRequestHeaders = {{"Accept", "application/json"}}
};
mockHttpClientFactory.Setup(mock => mock.CreateClient("SolrApi")).Returns(httpClient);
var slackOptions = Options.Create<SlackOptions>(new SlackOptions());
var prdSolrService = new PrdSolrService(Options.Create<PrdOptions>(new PrdOptions()));
var slackMessageService = new PrdSlackMessageService(new HtmlTransformService(), slackOptions);
var controller = new SlackPrdController(slackOptions, mockHttpClientFactory.Object, prdSolrService, slackMessageService);
var slackRequest = new SlackRequest();
// act
var sut = await controller.Post(slackRequest);
// assert
// note: validation should fail and not return a SlackMessage, but validation is not firing
// auto-validation is part of [ApiController] attribute on the Controller class
Assert.IsType<BadRequestObjectResult>(sut.Result);
}
这是正在测试的 Controller 方法。
[HttpPost]
public async Task<ActionResult<SlackMessage>> Post(SlackRequest request)
{
if (request.Token != _slackOptions.Token)
{
ModelState.AddModelError("Token", "Invalid verification token.");
return BadRequest(ModelState);
}
var solrUri = _solrService.SlackRequestToSolrUri(request);
var client = _httpClientFactory.CreateClient("SolrApi");
var raw = await client.GetStringAsync(solrUri);
var response = _solrService.ParseSolrResponse(raw);
var slackMessage = _slackMessageService.InitialMessage(response);
return slackMessage;
}
这是 SlackRequest 模型,其中需要 Token 属性。
public class SlackRequest
{
public SlackRequest() {}
[JsonProperty("token")]
[Required]
public string Token { get; set; }
[JsonProperty("team_id")]
public string TeamId { get; set; }
[JsonProperty("team_domain")]
public string TeamDomain { get;set; }
[JsonProperty("enterprise_id")]
public string EnterpriseId { get; set; }
[JsonProperty("enterprise_name")]
public string EnterpriseName { get; set; }
[JsonProperty("channel_id")]
public string ChannelId { get; set; }
[JsonProperty("channel_name")]
public string ChannelName { get; set; }
[JsonProperty("user_id")]
public string UserId { get; set; }
[JsonProperty("user_name")]
public string UserName { get; set; }
[JsonProperty("command")]
public string Command { get;set; }
[JsonProperty("text")]
public string Text { get; set; }
[Url]
[JsonProperty("response_url")]
public string ResponseUrl { get; set; }
[JsonProperty("trigger_id")]
public string TriggerId { get; set; }
}
【问题讨论】:
-
您将
_slackOptions初始化为new SlackOptions()并且在您的SlackRequest中您也没有设置token。那你为什么期望request.Token != _slackOptions.Token表达式的计算结果为true?要么将条件更改为空/空令牌失败,要么发布与SlackOptions中的不同的token -
模型的 Token 属性有一个 [Required] 属性,在我将 request.Token 与 _slackOptions.Token 进行比较之前应该验证该属性,所以我认为比较不是问题。
标签: c# unit-testing asp.net-core-2.1