Android - 单元测试响应处理程序类 HttpException 代码

Question

我正在编写一个类来对我的 ResponseHandler 类进行单元测试。我是否需要为我在 getErrorMessage 函数中考虑的每个可能的 HTTP 错误代码编写一个方法？ 一个用于 400、401、403、404、503 等？

ResponseHandler.kt

enum class ErrorCodes(val code: Int) {
    SocketTimeOut(-1),
    NoConnection(0)
}

class ResponseHandler {

    fun <T : Any> handleSuccess(data: T): Resource<T> {
        return Resource.success(data)
    }

    fun <T : Any> handleException(e: Exception): Resource<T> {
        return when (e) {
            is HttpException -> Resource.error(getErrorMessage(e.code()), null)
            is SocketTimeoutException -> Resource.error(getErrorMessage(ErrorCodes.SocketTimeOut.code), null)
            is IOException -> Resource.error(getErrorMessage(ErrorCodes.NoConnection.code), null)
            else -> Resource.error(getErrorMessage(Int.MAX_VALUE), null)
        }
    }

    private fun getErrorMessage(code: Int): String {
        return when (code) {
            ErrorCodes.SocketTimeOut.code -> "Timeout"
            ErrorCodes.NoConnection.code -> "No Connection"
            HttpURLConnection.HTTP_BAD_REQUEST -> "Bad request"
            HttpURLConnection.HTTP_UNAUTHORIZED -> "Unauthorized"
            HttpURLConnection.HTTP_FORBIDDEN -> "Forbidden"
            HttpURLConnection.HTTP_NOT_FOUND -> "Not found"
            HttpURLConnection.HTTP_UNAVAILABLE -> "Service Unavailable"
            else -> "Something went wrong"
        }
    }
}

ResponseHandlerTest.kt

    @Test
    fun `when exception is HttpException and code is 404 then return Not found error message`() {
        val httpException = HttpException(Response.error<List<StylesData>>(HttpURLConnection.HTTP_NOT_FOUND, mock()))
        val result = responseHandler.handleException<List<StylesData>>(httpException)
        assertEquals("Not found", result.message)
    }

    @Test
    fun `when exception is SocketTimeoutException then return Timeout error message`() {
        val socketTimeoutException = SocketTimeoutException()
        val result = responseHandler.handleException<List<StylesData>>(socketTimeoutException)
        assertEquals("Timeout", result.message)
    }

    @Test
    fun `when exception is IOException then return No connection error message`() {
        val ioException = IOException()
        val result = responseHandler.handleException<List<StylesData>>(ioException)
        assertEquals("No Connection", result.message)
    }

Answer 1

在这种情况下，是的，但我会考虑将该处理程序划分为特定情况，如下所示：

@ControllerAdvice
class RestResponseEntityExceptionHandler {

    @ExceptionHandler(IOException::class)
    fun handle(ex: IOException?): ResponseEntity<String> {
        // ...
    }
}

我还将错误消息移动到资源文件或枚举中，这更适合此操作。

有了它，如果你想处理一个新的案例，你就不必接触你的代码，而且你也避免了一个不断增加的可能的异常列表。

文档的相关部分是here