【发布时间】：2016-05-15 18:20:27
【问题描述】：
我正在使用 Mac OS X 10.11.4 和 Xcode 7.3 以及 gcc 编译器。我使用自制软件下载了 valgrind 3.11。当我用 valgrind 运行我的 C 程序时，这是输出
==4297==
==4297== HEAP SUMMARY:
==4297== in use at exit: 30,208 bytes in 188 blocks
==4297== total heap usage: 265 allocs, 77 frees, 40,286 bytes allocated
==4297==
==4297== LEAK SUMMARY:
==4297== definitely lost: 0 bytes in 0 blocks
==4297== indirectly lost: 0 bytes in 0 blocks
==4297== possibly lost: 2,064 bytes in 1 blocks
==4297== still reachable: 4,096 bytes in 1 blocks
==4297== suppressed: 24,048 bytes in 186 blocks
==4297== Rerun with --leak-check=full to see details of leaked memory
==4297==
==4297== For counts of detected and suppressed errors, rerun with: -v
==4297== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0)
在整个程序中，我有 2 个 malloc 和 2 个 free，所以我不知道为什么有 265 个 alloc 和更少的 free。我向使用 ubuntu 的朋友寻求帮助，当他用他的 gcc 编译我的代码并用 valgrind 运行程序时，它带回了 3 个 allocs 和 3 个 frees，所以一切都是正确的。我发现这可能发生在某些编译器库中，或者如果它们不是最新的，但我不知道如何在 OS X 中更新它们。
- 这是我的代码
main.c
#include <stdio.h>
#include <stdlib.h>
#include <time.h>
#include <string.h>
#include "game.h"
int main(int argc, char** argv) {
GAME team1;
GAME team2;
int len = 0; //only for valgrind
if(argc == 2) {
char* word;
len = strlen(argv[1]) + 1;
word = (char*)malloc(sizeof(char)*(len));
strcpy(word, argv[1]);
team1.team_name = word;
len = strlen("Team 2") + 1;
word = (char*)malloc(sizeof(char)*(len));
strcpy(word, "Team 2");
team2.team_name = word;
} else if(argc == 3) {
char* word;
len = strlen(argv[1]) + 1;
word = (char*)malloc(sizeof(char)*(len));
strcpy(word, argv[1]);
team1.team_name = word;
len = strlen(argv[2]) + 1;
word = (char*)malloc(sizeof(char)*(len));
strcpy(word, argv[2]);
team2.team_name = word;
} else {
char* word;
len = strlen("Team 1") + 1;
word = (char*)malloc(sizeof(char)*(len));
strcpy(word, "Team 1");
team1.team_name = word;
len = strlen("Team 2") + 1;
word = (char*)malloc(sizeof(char)*(len));
strcpy(word, "Team 2");
team2.team_name = word;
}
int player1, player2, players_number;
do { //PVP or PVAI
printf("How many players will play this game? [1/2]: ");
scanf("%d", &players_number);
} while((players_number != 1) && (players_number != 2));
names(&team1, &team2); //add names
abilities(&team1, &team2); //add hp, def, att
render(&team1, &team2);
//choosing first players
printf("Choose player from Team 1: ");
scanf("%d", &player1);
while(getchar() != '\n')
;
if(players_number == 2){
printf("Choose player from Team 2: ");
scanf("%d", &player2);
while(getchar() != '\n')
;
} else { //If PVAI
srand(time(NULL));
player2 = rand() % 5 + 1;
printf("Choose player from Team 2: %d\n", player2);
}
/////////////////////////
do { //GAME
if(team1.hp[player1 - 1] == 0) {
printf("Choose player from Team 1: ");
scanf("%d", &player1);
while(getchar() != '\n')
;
}
if((team2.hp[player2 - 1] == 0) && (players_number == 2)) {
printf("Choose player from Team 2: ");
scanf("%d", &player2);
while(getchar() != '\n')
;
} else if(team2.hp[player2 - 1] == 0) { //If PVAI
do {
player2 = rand() % 5 + 1;
} while(team2.hp[player2 - 1] == 0);
printf("Choose players from Team 2: %d\n", player2);
}
printf("---------------------------\n");
battle(&team1, &team2, (player1 - 1), (player2 - 1));
render(&team1, &team2);
} while(who_wins(&team1, &team2) == 0);
printf("Team %d wins!\n", who_wins(&team1, &team2));
free(team1.team_name);
free(team2.team_name);
return 0;
}
游戏.c
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <time.h>
#include <unistd.h> //for delay
#include <sys/stat.h> //for file size
#include "game.h"
void render(GAME *team1, GAME *team2) { //rendering the gaming table
printf("%s\tHP\tDEF\tATT\n", team1->team_name);
printf("---------------------------\n");
for(int i = 0; i <= 4; i++) {
printf("%s\t%d\t%d\t%d\n", team1->name[i], team1->hp[i], team1->def[i], team1->att[i]);
}
printf("---------------------------\n");
printf("%s\n", team2->team_name);
printf("---------------------------\n");
for(int i = 0; i <= 4; i++) {
printf("%s\t%d\t%d\t%d\n", team2->name[i], team2->hp[i], team2->def[i], team2->att[i]);
}
printf("---------------------------\n");
}
void names(GAME *team1, GAME *team2) { //choose random names from *.txt file
printf("Generating teams...\n");
FILE *fr = fopen("NAMES.txt", "r");
if(fr == NULL) {
printf("The file with names is not allowed, we will use pre-defined names for you.\n");
non_generated_names(&team1, &team2);
return; //can use exit instead of return and exit the program if names are not allowed
}
struct stat st;
stat("NAMES.txt", &st);
int size = st.st_size;
srand(time(NULL));
for(int i = 0; i <= 4; i++) {
fseek(fr, ((rand() % size) + 1), SEEK_SET);
if(fscanf(fr, "%*s\n%20s", team1->name[i]) == EOF)
i--;
}
for(int i = 0; i <= 4; i++) {
fseek(fr, ((rand() % size) + 1), SEEK_SET);
if(fscanf(fr, "%*s\n%20s", team2->name[i]) == EOF)
i--;
}
printf("Success!\n");
printf("---------------------------\n");
fclose(fr);
}
void non_generated_names(GAME **team1, GAME **team2) { //if *.txt file is not allowed, this is used for adding pre-defined names
for(int i = 0; i <= 4; i++) {
switch(i) {
case 0:
strcpy((*team1)->name[i], "Jack");
break;
case 1:
strcpy((*team1)->name[i], "Jim");
break;
case 2:
strcpy((*team1)->name[i], "John");
break;
case 3:
strcpy((*team1)->name[i], "Tom");
break;
case 4:
strcpy((*team1)->name[i], "Hank");
break;
}
}
for(int i = 0; i <= 4; i++) {
switch(i) {
case 0:
strcpy((*team2)->name[i], "Tim");
break;
case 1:
strcpy((*team2)->name[i], "Mark");
break;
case 2:
strcpy((*team2)->name[i], "Alf");
break;
case 3:
strcpy((*team2)->name[i], "Ted");
break;
case 4:
strcpy((*team2)->name[i], "Bil");
break;
}
}
}
void abilities(GAME *team1, GAME *team2) { //add HP, ATT and DEF to players
srand(time(NULL));
for(int i = 0; i <= 4; i++) {
team1->hp[i] = 5;
team2->hp[i] = 5;
team1->def[i] = rand() % 4 + 1;
team1->att[i] = 5 - team1->def[i];
team2->def[i] = rand() % 4 + 1;
team2->att[i] = 5 - team2->def[i];
}
}
int who_wins(GAME *team1, GAME *team2) { //tests if someone and who wins the game
int win = 2;
for(int i = 0; i <= 4; i++) {
if(team1->hp[i] != 0) {
win = 1;
break;
}
}
if(win == 2)
return 2;
for(int i = 0; i <= 4; i++) {
if(team2->hp[i] != 0) {
win = 0;
break;
}
}
if(win == 1)
return 1;
return 0;
}
void change_attacker(int *attacker) { //swap 1 and 2
if(*attacker == 1)
*attacker = 2;
else if(*attacker == 2)
*attacker = 1;
}
void battle(GAME *team1, GAME *team2, int player1, int player2) { //Battle engine
srand(time(NULL));
int attacker = rand() % 2 + 1; //random team to start
printf("Battle begins in few seconds...\n");
//sleep(1); //disabled delays for testing
if(attacker == 1) {
printf("%s will starts...\n", team1->team_name);
} else
printf("%s will starts...\n", team2->team_name);
//sleep(1);
printf("\n!!!START!!!\n\n");
printf("---------------------------\n");
while((team1->hp[player1] != 0) && (team2->hp[player2] != 0)) {
//sleep(1); //delay
if(attacker == 1) {
if((rand() % (team1->att[player1] + team2->def[player2]) + 1) > team2->def[player2]) {
team2->hp[player2]--;
printf("Attacker wins!\n");
if(team2->hp[player2] != 0)
printf("%s from %s has been hit, %d HP remaining.\n", team2->name[player2], team2->team_name, team2->hp[player2]);
else
printf("%s from %s is dead!\n", team2->name[player2], team2->team_name);
printf("---------------------------\n");
} else {
printf("Defender wins!\n");
printf("---------------------------\n");
}
} else if(attacker == 2) {
if((rand() % (team1->def[player1] + team2->att[player2]) + 1) > team1->def[player1]) {
team1->hp[player1]--;
printf("Attacker wins!\n");
if(team1->hp[player1] != 0)
printf("%s from %s has been hit, %d HP remaining.\n", team1->name[player1], team1->team_name, team1->hp[player1]);
else
printf("%s from %s is dead!\n", team1->name[player1], team1->team_name);
printf("---------------------------\n");
} else {
printf("Defender wins!\n");
printf("---------------------------\n");
}
}
change_attacker(&attacker);
}
}
【问题讨论】：
-
不看C代码很难回答你的问题
-
采纳 Valgrind 输出中的建议并“使用 --leak-check=full 重新运行以查看泄漏内存的详细信息”可能会有所帮助。
-
旁白：将
srand(time(NULL));移出不总是执行的else块（以及所有其他拥有它的函数）到main的顶部。 -
调试请贴
game.h文件内容 -
在调用任何内存分配函数（malloc、calloc、realloc）时，1) 始终检查 (!=NULL) 返回值以确保操作成功。 2) 在 C 中，返回的类型是
void*，可以分配给任何变量。所以不要通过转换返回值来弄乱代码。 3）表达式：sizeof(char)在标准中定义为1，所以作为参数中的乘数没有意义。