【问题标题】:bash scripting - how to process a comma separated list as input parameters to a functionbash 脚本 - 如何处理逗号分隔的列表作为函数的输入参数
【发布时间】:2017-10-17 04:50:52
【问题描述】:

我试图弄清楚如何将逗号, 分隔的列表作为输入传递,并让我的函数一次处理一个值。

我的功能:

addToWhitelist ()
{
   host='127.0.0.1'
   db='mytest'
   _mongo=$(which mongo);
   echo "${_ip}";
   read -a arr <<<${_ip};
   for i in ${arr[@]};
   do
     exp="db.account.update({\"account\":'${_account}'},{\$addToSet:{\"ip_list\": {\$each:['${_ip}'] }}})";
     ${_mongo} ${host}/${db} --eval "$exp"
   done
}

我这样运行我的脚本:

./myscript.sh -m add -a pizzahut -i 123.456.790.007,123.456.790.008

我的代码正在进行中:

#!/usr/local/bin/bash
set -e
set -x

# Usage for getopts
usage () {
    echo "Example: $0 -m find -a pizzahut"
    echo "Example: $0 -m add -a pizzahut -i 10.10.123.456"
    exit 1;
}

while getopts ":m:a:i:" o; do
  case "${o}" in
    m)
    _mode=${OPTARG}
         if [[ "${_mode}" != find && "${_mode}" != add ]]; then
        usage
        fi
    ;;
    a)
    _account=${OPTARG}
    ;;
    i)
    _ip=${OPTARG}
        set -f
        IFS=,
    ;;
    *)
       usage
       ;;
  esac
done
shift $((OPTIND-1))


getWhitelist ()
{
   host='127.0.0.1'
   db='mytest'
   _mongo=$(which mongo);
   exp="db.account.find({\"account\":'${_account}'},{ip_list: 1}).pretty();";
   ${_mongo} ${host}/${db} --eval "$exp"
}

# Read a list
addToWhitelist ()
{
   host='127.0.0.1'
   db='mytest'
   _mongo=$(which mongo);
   echo "${_ip}";
   read -a arr <<<${_ip};
   for i in ${arr[@]};
   do
     exp="db.account.update({\"account\":'${_account}'},{\$addToSet:{\"ip_list\": {\$each:['${_ip}'] }}})";
     ${_mongo} ${host}/${db} --eval "$exp"
   done
}


case "${_mode}" in
  'find')
      echo "Finding information for the account ${_account}"
      getWhitelist
      ;;
  'add')
      echo "Adding the following IP: ${_ip}"
      addToWhitelist
      ;;
esac

set +x

但是,我在调用该函数时遇到的问题是将值作为单个字符串插入:

  "ip_list" : [
    "123.456.790.006",
    "123.456.790.007,123.456.790.008",
    "123.456.790.009"
  ]
}

期待:

  "ip_list" : [
    "123.456.790.006",
    "123.456.790.007",
    "123.456.790.008",
    "123.456.790.009"
  ]
}

【问题讨论】:

    标签: bash unix scripting getopts


    【解决方案1】:

    由于您的脚本接收到以逗号分隔的 IP 列表,因此实际上类似于:

    _ip="123.456.790.007,123.456.790.008"
    

    您需要将列表按, 拆分,并用引号将每个IP 括起来,然后再将其提供给Mongo 的$each 操作员。

    首先,将IFS的重新定义本地化为仅read命令,然后利用printf在提供更多参数时重用相同格式字符串的行为(扩展数组"${arr[@]}"),存储结果通过-v 选项到变量,并从结果中去除前导,:

    IFS=, read -a arr <<<"${_ip}"
    printf -v ips ',"%s"' "${arr[@]}"
    ips="${ips:1}"
    

    对于上面给出的_ip 值,此脚本将存储在ips 变量中:

    "123.456.790.007","123.456.790.008"
    

    因此,将其应用于您的程序,首先更改您的 i) 大小写,例如:

    case "${o}" in
        # ...
        i) _ip=${OPTARG};;
    esac
    

    然后修复addToWhitelist函数:

    addToWhitelist() {
        host='127.0.0.1'
        db='mytest'
        _mongo=$(which mongo)
        IFS=, read -a arr <<<"${_ip}"
        printf -v ips ',"%s"' "${arr[@]}"
        ips="${ips:1}"
        exp="db.account.update({'account': '${_account}'}, {\$addToSet:{'ip_list': {\$each:[$ips]}}})";
        "${_mongo}" "${host}/${db}" --eval "$exp"
    }
    

    【讨论】:

    • 哇!非常感谢您对此的帮助。使用printf 是一种很好的处理方式。感谢您的帮助!
    【解决方案2】:

    试试下面,

    ip=$(echo ${OPTARG}|sed "s/,/,\n/g")

    所以完整的脚本会是这样的,

    #!/usr/local/bin/bash
    set -e
    set -x
    
    # Usage for getopts
    usage () {
        echo "Example: $0 -m find -a pizzahut"
        echo "Example: $0 -m add -a pizzahut -i 10.10.123.456"
        exit 1;
    }
    
    while getopts ":m:a:i:" o; do
      case "${o}" in
        m)
        _mode=${OPTARG}
             if [[ "${_mode}" != find && "${_mode}" != add ]]; then
            usage
            fi
        ;;
        a)
        _account=${OPTARG}
        ;;
         i)
        _ip=$(echo ${OPTARG}|sed "s/,/,\n/g")
            set -f
            IFS=,
        ;;
        *)
           usage
           ;;
      esac
    done
    shift $((OPTIND-1))
    getWhitelist ()
    {
       host='127.0.0.1'
       db='mytest'
       _mongo=$(which mongo);
       exp="db.account.find({\"account\":'${_account}'},{ip_list: 1}).pretty();";
       ${_mongo} ${host}/${db} --eval "$exp"
    }
    
    # Read a list
    addToWhitelist ()
    {
       host='127.0.0.1'
       db='mytest'
       _mongo=$(which mongo);
       echo "${_ip}";
       read -a arr <<<${_ip};
       for i in ${arr[@]};
       do
       exp="db.account.update({\"account\":'${_account}'},{\$addToSet:{\"ip_list\": {\$each:['${_ip}'] }}})";
         ${_mongo} ${host}/${db} --eval "$exp"
       done
    }
    
    
    case "${_mode}" in
      'find')
          echo "Finding information for the account ${_account}"
          getWhitelist
          ;;
      'add')
       echo "Adding the following IP: ${_ip}"
          addToWhitelist
          ;;
    esac
    
    set +x
    

    【讨论】:

    • 感谢您的回复。我试过了,但没有运气。我echo 看到输出,它仍然是一样的。 123.456.790.007,123.456.790.008
    • 你可以试试echo -e ${OPTARG}|sed "s/,/,\n/g" 吗?
    • 这是我的输出使用 - echo -e ${OPTARG}|sed "s/,/,\n/g" 123.456.790.016,n123.456.790.017
    猜你喜欢
    • 2022-01-25
    • 1970-01-01
    • 2021-04-16
    • 1970-01-01
    • 1970-01-01
    • 2012-07-15
    • 2019-02-15
    • 1970-01-01
    • 2012-06-05
    相关资源
    最近更新 更多