在for循环中嵌套if循环

Question

此代码只是生成一个随机数作为温度并每小时记录一次。我的 for 循环在获取代码的最大值和最小值时遇到问题。它对我来说看起来是正确的，并且与我看到的所有示例相似，但它给了我错误的输出。

谢谢

#include <stdio.h>
#include <stdlib.h>

void GetValue(int[], int x);
#define array_size 25
int main()  {
    int x, max, min, temperature[25];
    float sum;
    float average;
    int array[array_size];

printf("Temperature Conditions on October 9, 2015:\n");
       printf("Time of Day \t Temperature in Degrees F\n");

for (x = 0; x < 25; x++)    {
    //if statements to get min and max
    GetValue(temperature, x);
    if (temperature[x] > max)   {
        max = temperature[x];
    }
    if (temperature[x] < min)   {
        min = temperature[x];
    }
    printf("%d \t \t \t %d\n", x,temperature[x]);
}

//prints statements

printf("\nMaximum Temperature for the day: %d Degrees F\nMinimum Temperature for the day: %d Degrees F\n", temperature[12],max, min);

//adds up all temps

sum=0;

for (x=0;x<25;x++){

    sum=(sum+temperature[x]);
}

//prints and creates average

average=sum/25;

printf("Average Temperature for the day: %.2f Degrees F\n",average);

return 0;

}
//gets values and puts them into array

void GetValue(int value[], int x) {

value[x] = (rand()%(100-60+1))+60;
}

Answer 1

您通过使用具有自动存储持续时间的未初始化变量的值调用了未定义行为，这是不确定的。

• 只有在为变量赋值后才能使用它们的值。
• 正确格式化您的代码。
• 匹配printf() 的格式说明符和数据。
• 避免使用幻数。在这种情况下，使用 #defined 数字作为元素数。

更正的代码：

#include <stdio.h>
#include <stdlib.h>

void GetValue(int[], int x);
#define array_size 25
int main(void) {
    int x, max = 0, min = 0, temperature[array_size];
    float sum;
    float average;

    printf("Temperature Conditions on October 9, 2015:\n");
    printf("Time of Day \t Temperature in Degrees F\n");

    for (x = 0; x < array_size; x++)    {
        //if statements to get min and max
        GetValue(temperature, x);
        // in the first iteration, there won't be a valid number in max and min
        if (x == 0 || temperature[x] > max)   {
            max = temperature[x];
        }
        if (x == 0 || temperature[x] < min)   {
            min = temperature[x];
        }
        printf("%d \t \t \t %d\n", x, temperature[x]);
    }

    //prints statements

    printf("\nMaximum Temperature for the day: %d Degrees F\nMinimum Temperature for the day: %d Degrees F\n", max, min);

    //adds up all temps

    sum=0;

    for (x=0;x<array_size;x++){

        sum=(sum+temperature[x]);
    }

    //prints and creates average

    average=sum/array_size;

    printf("Average Temperature for the day: %.2f Degrees F\n", average);

    return 0;

}
//gets values and puts them into array

void GetValue(int value[], int x) {

    value[x] = (rand()%(100-60+1))+60;
}