为什么循环在我的 Windows 窗体应用程序中不起作用？ [复制]

Question

我正在尝试在 Windows 窗体应用程序中组合素数、偶数和奇数及其结果。我已经在控制台中测试了代码，但在 Windows 窗体中它不会循环到下一个适用的数字。例如：在控制台 1 - 10 中，素数会导致“2、3、5、7”，但在 Windows 窗体应用程序中会导致“2”

public partial class NumberCalc : Form
{
    public NumberCalc()
    {
        InitializeComponent();
    }

    private void Primes_CheckedChanged(object sender, EventArgs e)
    {
        {
            int f = Convert.ToInt32(Min.Text);
            int i = Convert.ToInt32(Max.Text);
            bool isPrime = true;

            for (f = 0; f <= i; f++)
            {
                for (int j = 2; j <= i; j++)
                {

                    if (f != j && f % j == 0)
                    {
                        isPrime = false;
                        break;
                    }

                }
                if (isPrime)
                {
                    string final;
                    final = ("The Prime Numbers Are:" + f);
                    Result.Text = final;
                }
                isPrime = true;
            }
        }
    }

    private void Result_TextChanged(object sender, EventArgs e)
    {

    }

    private void Min_TextChanged(object sender, EventArgs e)
    {

    }

    private void Evens_CheckedChanged(object sender, EventArgs e)
    {
        int f = Convert.ToInt32(Min.Text);
        int i = Convert.ToInt32(Max.Text);

        for (f = 0; f >= i; f++)
        {
            if (f % 2 == 0)
            {
                {
                    string final;
                    final = ("The Even Numbers Are:" + f);
                    Result.Text = final;
                }
            }
        }

    }

    private void Odds_CheckedChanged(object sender, EventArgs e)
    {

        int f = Convert.ToInt32(Min.Text);
        int i = Convert.ToInt32(Max.Text);

        for (f = 0; f <= i; f++)
        {
            if (f % 2 != 0)
            {
                {
                    string final;
                    final = ("The Even Numbers Are:" + f);
                    Result.Text = final;
                }
            }
        }
    }
}

}

Answer 1

我觉得LINQ更适合这里，你可以试试这个：

int[] numbers = Enumerable.Range(f, i-f).ToArray<int>();
string oddNumbers=string.Join(",", from number in numbers 
                                   where (number % 2)!=0
                                   select number);

string evenNumbers = string.Join(",", from number in numbers
                                      where (number % 2) == 0
                                      select number);
Result.Text = "The Even Numbers Are:" + evenNumbers;
Result.Text = "The Odd Numbers Are:" + oddNumbers;

素数更新：

var primeNumbers= string.Join(",",from number in numbers
                                 where (IsPrime(number))
                                 select number);

IsPrime()方法在哪里定义如下？

private static bool IsPrime(int number)
 {
   for (int i = 2; i < number; i ++)
     if (number % i == 0) return false;
   return true;
 }

Answer 2

将您的代码更改为：

    private void Primes_CheckedChanged(object sender, EventArgs e)
    {
        {
            string final = "The Prime Numbers Are:";// you need to keep the result out of the loop instead of reset it everytime
            int f = Convert.ToInt32(Min.Text);
            int i = Convert.ToInt32(Max.Text);
            bool isPrime = true;

            for (f = 0; f <= i; f++)// why set f=0 here ? Does not f = min already ?
            {
                for (int j = 2; j <= i; j++)// maybe j < f not j <= i
                {

                    if (f != j && f % j == 0)// then remove f != j here
                    {
                        isPrime = false;
                        break;
                    }

                }
                if (isPrime)
                    final = final + " " + f;// then add your found number to the result here
                isPrime = true;
            }
            Result.Text = final;
        }
    }

偶数和奇数是一样的。顺便说一句，1 不是质数，对吗？

Answer 3

我会将您的循环/检查组合成一种方法，如下所示：

    private void Form1_Load(object sender, EventArgs e)
    {
        this.Primes.CheckedChanged += Options_CheckedChanged;
        this.Evens.CheckedChanged += Options_CheckedChanged;
        this.Odds.CheckedChanged += Options_CheckedChanged;
        this.Min.TextChanged += Range_Changed;
        this.Max.TextChanged += Range_Changed;
        CheckNumbers();
    }

    private void Range_Changed(object sender, EventArgs e)
    {
        CheckNumbers();
    }

    private void Options_CheckedChanged(object sender, EventArgs e)
    {
        CheckNumbers();
    }

    private void CheckNumbers()
    {
        int min, max;
        try
        {
            min = Convert.ToInt32(Min.Text);
            max = Convert.ToInt32(Max.Text);
        }
        catch (Exception)
        {
            Results.Text = "Invalid Range!";
            return;
        }

        List<int> lstPrimes = new List<int>();
        List<int> lstEvens = new List<int>();
        List<int> lstOdds = new List<int>();

        if (Primes.Checked || Evens.Checked || Odds.Checked)
        {
            bool isPrime;
            for (int f = min; f <= max; f++)
            {
                if (Primes.Checked)
                {
                    isPrime = true;
                    for (int j = 2; j <= max; j++)
                    {

                        if (f != j && f % j == 0)
                        {
                            isPrime = false;
                            break;
                        }

                    }
                    if (isPrime)
                    {
                        lstPrimes.Add(f);
                    }
                }
                int modResult = f % 2;
                if (Evens.Checked && modResult == 0)
                {
                    lstEvens.Add(f);
                }
                if (Odds.Checked && modResult != 0)
                {
                    lstOdds.Add(f);
                }
            }
        }

        StringBuilder sb = new StringBuilder();
        if (Primes.Checked)
        {
            sb.AppendLine("The Prime Numbers Are:" + String.Join(",", lstPrimes));
        }
        if (Evens.Checked)
        {
            sb.AppendLine("The Even Numbers Are:" + String.Join(",", lstEvens));
        }
        if (Odds.Checked)
        {
            sb.AppendLine("The Odd Numbers Are:" + String.Join(",", lstOdds));
        }
        Results.Text = sb.ToString();
    }