如何干燥此 Ruby 代码（Active Admin/rails 3.2）[关闭]

Question

我觉得我在这里重复了太多相同的内容并希望DRY它但我不知道如何。

我有一个 Prize 模型，其中一个属性是 prize_type，这是一个选择（您可以选择一个名为 PRIZE_TYPE 的 CONSTANT 内的 4 个值之一）。对于每种类型的奖品，我都有一个table_for。

例如，我想使用某种映射 (.map?)，以防有一天，如果我在数组 PRIZE_TYPE 中添加第五个或第六个值，我希望我的面板自动添加它们无需我在下面复制/粘贴另一个table_for：

show do 

    def custom_number_to_currency(u)
      number_to_currency u,
        separator: ".",
        delimiter: ",",
        precision: 0,
        raise: true  
    end    



 panel "Details of Prizes" do

  table_for deal.prizes.where(:prize_type => PRIZE_TYPES[0]) do |t|
    h3 "The deal has #{deal.prizes.where(:prize_type => PRIZE_TYPES[0]).count} #{PRIZE_TYPES[0]}s
    initially set in the campaign for a total value of #{custom_number_to_currency (deal.prizes.where(:prize_type => PRIZE_TYPES[0]).sum(:prize_unit_certified_market_value)) }", class: 'title-within-table'
    if deal.prizes.where(:prize_type => PRIZE_TYPES[0]).count > 0 # if there is at least one record of 'jackpot prize'
      t.column("Prize")             { |prize| link_to( image_tag( prize.prize_image_url, class: 'main_img_in_admin_interface' ), admin_prize_path(prize), target: :blank ) }
      t.column("Name")              { |prize| link_to prize.prize_name, admin_prize_path(prize), target: :blank }
      t.column("Category")          { |prize| prize.prize_category }
      t.column("Initial quantity")  { |prize| prize.prize_initial_stock_quantity }
      t.column("Remaining quantity"){ |prize| if prize.prize_remaining_stock_quantity == 0
                                                status_tag('no prizes left (all won)', :class => 'green')
                                              else
                                                prize.prize_remaining_stock_quantity
                                              end } 

  end

  table_for deal.prizes.where(:prize_type => PRIZE_TYPES[1]) do |t|
    h3 "The deal has #{deal.prizes.where(:prize_type => PRIZE_TYPES[1]).count} #{PRIZE_TYPES[1]}s
    initially set in the campaign for a total value of #{custom_number_to_currency (deal.prizes.where(:prize_type => PRIZE_TYPES[1]).sum(:prize_unit_certified_market_value)) }", class: 'title-within-table'
    if deal.prizes.where(:prize_type => PRIZE_TYPES[1]).count > 0 # if there is at least one record of 'in-modal prize'
      t.column("Prize")             { |prize| link_to( image_tag( prize.prize_image_url, class: 'main_img_in_admin_interface' ), admin_prize_path(prize), target: :blank ) }
      t.column("Name")              { |prize| link_to prize.prize_name, admin_prize_path(prize), target: :blank }
      t.column("Category")          { |prize| prize.prize_category }
      t.column("Initial quantity")  { |prize| prize.prize_initial_stock_quantity }
      t.column("Remaining quantity"){ |prize| if prize.prize_remaining_stock_quantity == 0
                                                status_tag('no prizes left (all won)', :class => 'green')
                                              else
                                                prize.prize_remaining_stock_quantity
                                              end } 

  end

  table_for deal.prizes.where(:prize_type => PRIZE_TYPES[2]) do |t|
    h3 "The deal has #{deal.prizes.where(:prize_type => PRIZE_TYPES[2]).count} #{PRIZE_TYPES[2]}s
    initially set in the campaign for a total value of #{custom_number_to_currency (deal.prizes.where(:prize_type => PRIZE_TYPES[2]).sum(:prize_unit_certified_market_value)) }", class: 'title-within-table'
    if deal.prizes.where(:prize_type => PRIZE_TYPES[2]).count > 0 # if there is at least one record of 'Consolation prize'
      t.column("Prize")             { |prize| link_to( image_tag( prize.prize_image_url, class: 'main_img_in_admin_interface' ), admin_prize_path(prize), target: :blank ) }
      t.column("Name")              { |prize| link_to prize.prize_name, admin_prize_path(prize), target: :blank }
      t.column("Category")          { |prize| prize.prize_category }
      t.column("Initial quantity")  { |prize| prize.prize_initial_stock_quantity }
      t.column("Remaining quantity"){ |prize| if prize.prize_remaining_stock_quantity == 0
                                                status_tag('no prizes left (all won)', :class => 'green')
                                              else
                                                prize.prize_remaining_stock_quantity
                                              end } 

  end

  table_for deal.prizes.where(:prize_type => PRIZE_TYPES[3]) do |t|
    h3 "The deal has #{deal.prizes.where(:prize_type => PRIZE_TYPES[3]).count} #{PRIZE_TYPES[3]}s
    initially set in the campaign for a total value of #{custom_number_to_currency (deal.prizes.where(:prize_type => PRIZE_TYPES[3]).sum(:prize_unit_certified_market_value)) }", class: 'title-within-table'
    if deal.prizes.where(:prize_type => PRIZE_TYPES[3]).count > 0 # if there is at least one record of 'Activation prize'
      t.column("Prize")             { |prize| link_to( image_tag( prize.prize_image_url, class: 'main_img_in_admin_interface' ), admin_prize_path(prize), target: :blank ) }
      t.column("Name")              { |prize| link_to prize.prize_name, admin_prize_path(prize), target: :blank }
      t.column("Category")          { |prize| prize.prize_category }
      t.column("Initial quantity")  { |prize| prize.prize_initial_stock_quantity }
      t.column("Remaining quantity"){ |prize| if prize.prize_remaining_stock_quantity == 0
                                                status_tag('no prizes left (all won)', :class => 'green')
                                              else
                                                prize.prize_remaining_stock_quantity
                                              end } 

  end

Answer 1

你不能这样做吗？

panel "Details of Prizes" do   
    PRIZE_TYPES.each do |prize_type|
      table_for deal.prizes.where(:prize_type => prize_type) do |t|
        h3 "The deal has #{deal.prizes.where(:prize_type => prize_type).count} #{prize_type}s
        initially set in the campaign for a total value of #{custom_number_to_currency (deal.prizes.where(:prize_type => prize_type).sum(:prize_unit_certified_market_value)) }", class: 'title-within-table'
        if deal.prizes.where(:prize_type => prize_type).count > 0 # if there is at least one record of 'jackpot prize'
          t.column("Prize")             { |prize| link_to( image_tag( prize.prize_image_url, class: 'main_img_in_admin_interface' ), admin_prize_path(prize), target: :blank ) }
          t.column("Name")              { |prize| link_to prize.prize_name, admin_prize_path(prize), target: :blank }
          t.column("Category")          { |prize| prize.prize_category }
          t.column("Initial quantity")  { |prize| prize.prize_initial_stock_quantity }
          t.column("Remaining quantity"){ |prize| if prize.prize_remaining_stock_quantity == 0
                                                    status_tag('no prizes left (all won)', :class => 'green')
                                                  else
                                                    prize.prize_remaining_stock_quantity
                                                  end }  
   end
end