【发布时间】:2012-01-17 20:26:13
【问题描述】:
所以我使用 Observer / Observable 方法掌握了 Java 中的基本 MVC 模式。现在为了保持它的清洁和可读性,在我继续讨论如何很好地组织我的视图之前,我想要一些指示,因为这是我的课程最充实的地方。我们在学校被告知将每个班级的文件大小保持在 20kb 以下,以保持其可读性和以后更易于维护。
这是我的看法:
package view;
import model.*;
import helper.*;
import java.awt.*;
import java.awt.event.*;
import javax.swing.*;
import java.util.Observable;
import java.util.Observer;
import net.miginfocom.swing.MigLayout;
public class View extends JFrame implements Observer
{
private Model model;
private JPanel left = new JPanel(new MigLayout());
private JPanel center = new JPanel(new MigLayout());
private JPanel right = new JPanel(new MigLayout());
private void setConstraints()
{
this.left.setMinimumSize(new Dimension(252, 540));
this.left.setMaximumSize(new Dimension(252, 37500));
this.center.setMinimumSize(new Dimension(298, 540));
this.right.setMinimumSize(new Dimension(250, 540));
this.right.setMaximumSize(new Dimension(250, 37500));
}
//Left panel contents
private Towers box = new Towers();
private Modules tree = new Modules();
private JPanel setupLeft()
{
this.left.add(this.box, "growx, pushx, wrap");
this.left.add(new JScrollPane(this.tree), "grow, push");
return this.left;
}
//Center panel contents
private Browser browser = new Browser();
private JPanel setupCenter()
{
this.center.add(new JScrollPane(this.browser), "grow, push");
return this.center;
}
//Right panel contents
private JLabel tower = new JLabel("No tower selected.");
private JLabel cap = new JLabel("Capacitor");
private JLabel cpu = new JLabel("CPU");
private JLabel shield = new JLabel("0");
private JLabel armor = new JLabel("0");
private JLabel em = new JLabel("0.0");
private JLabel th = new JLabel("0.0");
private JLabel kn = new JLabel("0.0");
private JLabel ex = new JLabel("0.0");
private JPanel setupRight()
{
this.right.add(this.tower, "span, wrap");
this.right.add(this.cap, "span, wrap");
this.right.add(this.cpu, "span, wrap");
this.right.add(this.shield, "span, wrap");
this.right.add(this.armor, "span, wrap");
this.right.add(this.em, "span, wrap");
this.right.add(this.th, "span, wrap");
this.right.add(this.kn, "span, wrap");
this.right.add(this.ex, "span, wrap");
return this.right;
}
public View(Model ui_model)
{
model = ui_model;
this.setTitle("MVC Experiment 6");
this.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
this.setExtendedState(JFrame.MAXIMIZED_BOTH);
this.setMinimumSize(new Dimension(800, 600));
this.setLayout(new MigLayout());
this.setConstraints();
this.add(this.setupLeft(), "dock west");
this.add(this.setupCenter(), "dock center");
this.add(this.setupRight(), "dock east");
}
//Left panel contents - Listeners and methods for addressing JComponents
public void xTowersBrowser(ActionListener event)
{
this.box.addActionListener(event);
}
public void xModulesBrowser(MouseListener event)
{
this.tree.addMouseListener(event);
}
public Towers getTowersBrowser()
{
return this.box;
}
public Modules getModulesBrowser()
{
return this.tree;
}
//Left panel - END
//Center panel - components :: listeners and methods
public void xBrowser(MouseListener event)
{
this.browser.addMouseListener(event);
}
public Browser getBrowser()
{
return this.browser;
}
//Center panel - END
public void update(Observable o, Object arg)
{
}
}
任何关于在新类中分离什么或如何最小化代码的建议都是有帮助的。这只是我的主视图类的一部分,仍然缺少很多 JComponents,所以它会变得更加混乱。
【问题讨论】:
-
这可能更适合codereview。你不需要在任何地方都使用
this,在Java中你不需要将左大括号放在一个新的行中。 -
UI 编程因生成非常长的文件而臭名昭著。
-
哦,哇,我不知道 codereview,谢谢。我理解“这个”部分,这只是 PHP 时代的一个旧习惯等。
-
我确实理解您在进行 UI 工作时会收到大文件,但我正在努力学习如何做到最好,以使其接近行业标准。因此,如果有人在我之后查看代码,他就会明白发生了什么
标签: java model-view-controller swing user-interface