【问题标题】:Thread blocked forever when waits on lock operation等待锁定操作时线程永远阻塞
【发布时间】:2011-04-05 22:58:43
【问题描述】:

我正在编写一个用于两阶段锁定的 java 实现。所以,我正在使用可重入锁(读写锁)。问题是当线程执行 lock.readLock.lock() 或 lock.writeLock().lock() 并且锁已经被锁定时,即使使用 lock.readLock().unlock 解锁锁,它也会永远卡住() 或 lock.writeLock().unlock()。所以,看起来解锁并没有唤醒服务员!!! 这是导致问题的代码:

class LockTable
{
//    /*******************************************************************************
//     * This class is used to represent an individual lock.
//     * @param tid     the id of the transaction holding the lock
//     * @param shared  whether the lock is shared (true) or exclusive (false)
//     */
//    void Lock (int tid, boolean shared)
//    {
//        Semaphore sem = new Semaphore (0);
//    } // Lock class

    /** Associative map of locks held by transactions of the form (key = oid, value = lock)
     */
    private HashMap<Integer,MyLock> locks;

    public LockTable(){
        locks= new HashMap<Integer,MyLock>();

    }

    /*******************************************************************************
     * Acquire a shared/read lock on data object oid.
     * @param tid  the transaction id
     * @param oid  the data object id
     */
    void rl (int tid, int oid) throws InterruptedException
    {

        MyLock lock=null;
        boolean wait = false;
        synchronized(this) {
            try {
                lock = locks.get(oid);             // find the lock

                if((lock != null) && (lock.lock.isWriteLocked())){

                   wait = true;

                  // System.out.println(locks.get(oid).shared);
                }

                if(lock == null){
                 lock = new MyLock(tid, true);
                 lock.lock.readLock().lock();
                 lock.readers.add(tid);
                 locks.put(oid, lock);
              }

            } catch(Exception e) {
                System.out.println(e.getStackTrace());        // lock not found, so oid is not locked;
            } // try
        }//synch


        if (wait){

            System.out.println("Transaction " + tid + " is waiting..");
            Main.g.addEdge(tid, lock.tid);
                    if(Main.g.hasCycle())
                        restart(tid);

            //to exclude the restarted thread
            if(!Main.trans[tid].terminate){

                lock.lock.readLock().lock();
                Main.g.removeEdge(tid, lock.tid);
                synchronized(this){
                lock.readers.add(tid);
                }//synchronized
            }//if isInturrupted
            else
                return;
        }
       else
        synchronized(this) {
              lock.lock.readLock().lock();
              lock.readers.add(tid);
      } // synchronized

    } // rl

    /*******************************************************************************
     * Acquire an exclusive/write lock on data object oid.
     * @param tid  the transaction id
     * @param oid  the data object id
     */
    void wl (int tid, int oid) throws InterruptedException
    {
         //type to determine the last lock type in order
         //to be able to remove the edges from waitfor graph
        int type = 0;
        MyLock lock = null;
        boolean wait = false;

        synchronized(this) {
            try {
                lock = locks.get(oid);             // find the lock
                if(lock != null && (lock.lock.isWriteLocked() || lock.readers.size() > 0))
                {
                    wait = true;
                }
                if(lock == null){
                    lock = new MyLock(tid);
                    lock.lock.writeLock().lock();
                    locks.put(oid,lock);
                }
            } catch(Exception e) {
                System.out.println(e.getStackTrace());        // lock not found, so oid is not locked;
            } // try
      }
         if (wait){
                System.out.println("Transaction " + tid + " is waiting..");
                if(lock.lock.isWriteLocked())
                    Main.g.addEdge(tid, lock.tid);
                else{
                    type = 1;
                    for(int reader : lock.readers)
                         Main.g.addEdge(tid, reader);
                    }//else

                            if(Main.g.hasCycle())
                            {
                                restart(tid);
                            }//if
           if(!Main.trans[tid].terminate){
                System.out.println("I'm waiting here in wl");
                lock.lock.writeLock().lock();
                System.out.println("Wakeup..");
                if(type == 0)
                    Main.g.removeEdge(tid, lock.tid);
                else
                    for(int reader : lock.readers)
                        Main.g.removeEdge(tid, reader);
                lock.tid = tid;
             }
            else
                return;

        }// if(wait) ==> for the lock to be released
        else 
            lock.lock.writeLock().lock();

    } // wl

    void restart(int tid){
     synchronized(this) {
        MyLock lock;
        List<Integer> toRemove = new ArrayList();
        for(int i : locks.keySet()){
           lock = locks.get(i);

               //lock.sem.release();
               if(lock.lock.isWriteLockedByCurrentThread()){

                   System.out.println("Transaction"+tid+" unlock object "+ i +" in order to restart");
                   lock.lock.writeLock().unlock();
                    System.out.println("number of write holders: " + lock.lock.writeLock().getHoldCount());
                    System.out.println("number of read holders: " + lock.lock.getReadHoldCount());
                    System.out.println("number of waiters: " + lock.lock.getQueueLength());
                   toRemove.add(i);

               }
           if(!lock.lock.isWriteLocked())
               if(lock.readers.contains(tid)){
                   // lock.numberOfReaders --;

                      System.out.println("Transaction"+tid+" unlock object "+ i +" in order to restart");
                      lock.readers.remove(lock.readers.indexOf(tid));
                      lock.lock.readLock().unlock();
                      System.out.println("number of write holders: " + lock.lock.getWriteHoldCount());
                      System.out.println("number of read holders: " + lock.lock.getReadHoldCount());
                      System.out.println("number of waiters: " + lock.lock.getQueueLength());
                      toRemove.add(i);  

                  }//if
        }//for
        for(int i = 0; i < toRemove.size() ; i ++)
            locks.remove(toRemove.get(i));
        Main.g.removeEdges(tid);

       // Thread.currentThread().interrupt();
        Main.trans[tid].terminate = true;

        System.out.println("Transaction" + tid + " restarted");

        }//sync
    }

    /*******************************************************************************
     * Unlock/release the lock on data object oid.
     * @param tid  the transaction id
     * @param oid  the data object id
     */
    void ul (int tid, int oid)
    {
       MyLock lock = null;
        boolean error = false;
        synchronized(this) {
            try {
                lock = locks.get(oid);                    // find the lock
                if( lock == null)
                    System.out.println("println: lock not found");

            } catch(Exception e) {
                System.out.println("lock not found");   // lock not found
            } // try
        }//sync
            if((lock != null) && (lock.lock.isWriteLockedByCurrentThread())){

                      System.out.println("tid: " + tid + " unlock object: " + oid);
                      lock.lock.writeLock().unlock();
                      System.out.println("done with unlock");
                      System.out.println("number of write holders: " + lock.lock.writeLock().getHoldCount());
                      System.out.println("number of read holders: " + lock.lock.getReadHoldCount());
                      System.out.println("number of waiters: " + lock.lock.getQueueLength());
          }// if lock != null
            else
              if((lock != null) && (lock.readers.size()>0)){
                  if(lock.readers.contains(tid)){
                    lock.readers.remove(lock.readers.indexOf(tid));
                    lock.lock.readLock().unlock();
                    System.out.println("Transaction"+tid+" unlocked shared lock on object "+oid);
                    //System.out.println("number of write holders: " + lock.lock.readLock().);
                    System.out.println("number of read holders: " + lock.lock.getReadHoldCount());
                    System.out.println("number of waiters: " + lock.lock.getQueueLength());

                  }//if lock.readers
              }//if


        if (error) 
            System.out.println ("Error: ul: no lock for oid = " + oid + " found/owned");
    } // ul

【问题讨论】:

  • 你能把它清理一下,只留下相关的代码行吗?读起来有点难……
  • 你得到了哪个输出,你期望得到哪个输出?您的示例无法以这种方式执行,因此我们无法尝试。
  • 另外,您可能想使用jstack 工具查看所有线程卡住时的堆栈状态。它向您显示哪个线程持有哪些锁,以及哪个线程正在等待哪个锁。
  • Paulo 如果您想查看可执行代码,我可以将其发送到您的邮箱,如果您可以将您的邮箱地址发送到 khaleefh@hotmail.com
  • 我回滚了编辑,因为原始帖子更能说明问题所在。

标签: java multithreading locking reentrantreadwritelock


【解决方案1】:
Method A:
...snip...
synchronized(this) {
    ...snip...
    lock.lock.readLock().lock();
    ...snip...
}

Method B:
...snip...
synchronized(this) {
    ...snip...
    lock.lock.readLock().unlock();
    ...snip...
}

您遇到的问题是由于基本上阻塞一个同步器而持有另一个同步器而导致死锁。当您在synchronized(this) 代码块内调用Lock.lock() 时,Thread 将进入BLOCKING 状态,同时继续保持this 上的内在锁定。由于实际持有 Lock 以获取 this 上的内在锁的线程,并且内在锁永远不会被释放,因此您遇到了死锁。

例如:
Thread1进入方法A,获得this上的锁
Thread2进入方法A,获取不到this所以阻塞
Thread1 获得 Readlock
Thread1 发布this
Thread2 获得this
Thread2 阻塞等待读锁
线程1进入方法B,无法获取this所以阻塞
死锁

【讨论】:

    【解决方案2】:

    另外,不要忘记不快乐的道路。确保将你的 unlock() 放在 finally 中,否则如果抛出异常,unlock() 永远不会被调用,你最终会陷入死锁。

    【讨论】:

      猜你喜欢
      • 2017-08-26
      • 2010-12-21
      • 2011-10-27
      • 2016-06-03
      • 1970-01-01
      • 1970-01-01
      • 1970-01-01
      • 1970-01-01
      • 2022-11-22
      相关资源
      最近更新 更多