c# 中随机 # 生成器的问题（已编辑）

Question

已编辑

我在 Main 中有这个，我在其中设置对象并调用 Player 类。很抱歉代码中缺少 cmets。

        Player MyPlayer;
    MyPlayer = new Player();
    Hiders[] MyHiders = new Hiders[4];



    for (i = 0; i < 4; i++)
    {
        MyHiders[i] = new Hiders();
    }

    while (FoundAll == false)
    {
        MyPlayer.Move();
        for (i = 0; i < 4; i++)
        {
            MyHiders[i].DisplayDistance(MyPlayer.x, MyPlayer.y);
        }
        for (i = 0; i < 4; i++)
        {
            MyHiders[i].CheckCapture(MyPlayer.x, MyPlayer.y);
        }

        FoundAll = true;
        for (i = 0; i < 4; i++)
        {
            if (MyHiders[i].Found == false)
            {
                FoundAll = false;
            }
        }
    }
    Console.WriteLine("You Win!");

还有这些类

    class Player
{
    public int x;
    public int y;

    public void Move()
    {
        string buffer;
        Console.WriteLine("Where would you like to move?");
        buffer = Console.ReadLine();
        if (buffer == "u")
        {
            x++;
        }
        if (buffer == "d")
        {
            x--;
        }
        if (buffer == "l")
        {
            y--;
        }
        if (buffer == "r")
        {
            y++;
        }
    }
}
class Hiders
{
    private int x;
    private int y;

    public bool Found;
    int[,] map = new int[10, 10];
    Random MyRandom = new Random();
    int Randomhx;
    int Randomhy;

    public Hiders(int hx, int hy)
    {
        MyRandom = new Random();
        Randomhx = MyRandom.Next(1, 10);
        Randomhy = MyRandom.Next(1, 10);
    }

    public Hiders()
    {

    }

    public void DisplayDistance(int px, int py)
    {
        double distance;

        distance = Math.Sqrt(Math.Pow(x - px, 2) + Math.Pow(y - py, 2));

        Console.WriteLine(distance);
    }

    public void CheckCapture(int px, int py)
    {
        if (Randomhx == px & Randomhy == py)
        {

            Found = true;


        }
    }
}

所有的隐藏者都得到相同的值。我如何使它从1-10改变。这应该可以工作。

Answer 1

每个 Hiders 实例都在实例化自己的 Random 实例。由于它们几乎同时被实例化，并且 Random 使用系统时钟作为默认种子，因此 Random 的所有实例将产生相同的值序列。我的建议是让 Hiders 实例共享一个 Random 实例。

Answer 2

随机的默认构造函数使用系统时间作为种子。尝试使用随机种子，例如 Guid.NewGuid().GetHashCode()

var rnd = new Random(Guid.NewGuid().GetHashCode());

Answer 3

根据@DeveloperGuo 的回答，您应该使用不同的种子，以便获得不同的随机值。此更改应该有效。

public Hiders()
{
   MyRandom = new Random( Guid.NewGuid().GetHashCode() );
   x = MyRandom.Next( 1, 10 );
   y = MyRandom.Next( 1, 10 );
}

编辑：

因为我上面的例子实际上并不是一个好的做法，所以这里是另一个镜头：

  public Start_New_Game()
  {
     bool FoundAll = false;
     int i;
     Player MyPlayer;
     MyPlayer = new Player();
     Hiders[] MyHiders = new Hiders[ 4 ];
     HiderGenerator hiderGenerator = new HiderGenerator();

     for ( i = 0 ; i < 4 ; i++ )
     {
        MyHiders[ i ] = hiderGenerator.Get_New_Hider();
     }

     while ( FoundAll == false )
     {
        MyPlayer.Move();
        for ( i = 0 ; i < 4 ; i++ )
        {
           MyHiders[ i ].DisplayDistance( MyPlayer.x, MyPlayer.y );
        }
        for ( i = 0 ; i < 4 ; i++ )
        {
           MyHiders[ i ].CheckCapture( MyPlayer.x, MyPlayer.y );
        }

        FoundAll = true;
        for ( i = 0 ; i < 4 ; i++ )
        {
           if ( MyHiders[ i ].Found == false )
           {
              FoundAll = false;
           }
        }
     }
     Console.WriteLine( "You Win!" );
  }

  class Player
  {
     public int x;
     public int y;

     public void Move()
     {
        string buffer;
        Console.WriteLine( "Where would you like to move?" );
        buffer = Console.ReadLine();
        if ( buffer == "u" )
        {
           x++;
        }
        if ( buffer == "d" )
        {
           x--;
        }
        if ( buffer == "l" )
        {
           y--;
        }
        if ( buffer == "r" )
        {
           y++;
        }
     }
  }

  class HiderGenerator
  { 
     Random MyRandom = new Random();
     public Hiders Get_New_Hider()
     {
        return new Hiders( MyRandom.Next(1,10), MyRandom.Next(1,10) );
     }
  }

  class Hiders
  {
     private int x;
     private int y;

     public bool Found;
     int[,] map = new int[ 10, 10 ];

     public Hiders( int x, int y )
     {
        this.x = x;
        this.y = y;
     }

     public void DisplayDistance( int px, int py )
     {
        if ( Found )
           return;

        double distance;

        distance = Math.Sqrt( Math.Pow( x - px, 2 ) + Math.Pow( y - py, 2 ) );

        Console.WriteLine( distance );
     }

     public void CheckCapture( int px, int py )
     {
        if ( Found )
           return;

        if ( x == px && y == py )
        {
           Found = true;
        }
     }
  }

这不是一个完美的答案，但至少可以作为一个起点。