SearchView 与 RecyclerView（应用程序在返回包含 recyclerview 的片段时关闭）

Question

我有片段包含Recyclerview和Searchview（在cardview而不是appbar中），关于搜索过程，应用程序工作正常，但问题是何时从包含recyclerview的片段返回并返回它，应用关闭。

Logcat：

java.lang.NullPointerException: Attempt to invoke interface method 'java.lang.Object[] java.util.Collection.toArray()' on a null object reference
            at java.util.ArrayList.addAll(ArrayList.java:588)
            at com.quiltur.blocks.BlockListAdapter$3.publishResults(BlockListAdapter.java:174)
            

适配器：

public class BlockListAdapter extends RecyclerView.Adapter<BlockListAdapter.BlockViewHolder> implements Filterable {



    private FirebaseFirestore firebaseFirestore;
    private FirebaseAuth firebaseAuth;
    private String userId;
    public Context context;


    private List<BlockListModel> blockListModels;
    private List<BlockListModel> blockListModelsFull;
    private OnBlockListItemClicked onBlockListItemClicked;

    public BlockListAdapter(OnBlockListItemClicked onBlockListItemClicked) {
        this.onBlockListItemClicked = onBlockListItemClicked;
    }

    public void setBlockListModels(List<BlockListModel> blockListModels) {
        this.blockListModels = blockListModels;
        blockListModelsFull = new ArrayList<>(blockListModels);
    }

    @NonNull
    @Override
    public BlockViewHolder onCreateViewHolder(@NonNull ViewGroup parent, int viewType) {
        View view = LayoutInflater.from(parent.getContext()).inflate(R.layout.single_list_item, parent, false);
        context = parent.getContext();
        return new BlockViewHolder(view);
    }

    @Override
    public void onBindViewHolder(@NonNull BlockViewHolder holder, int position) {
        holder.listTitle.setText(blockListModels.get(position).getName());
        String blockId = blockListModels.get(position).getBlock_id();
        String imageUrl = blockListModels.get(position).getImage();

        Shimmer shimmer = new Shimmer.ColorHighlightBuilder()
                .setDuration(1800) // how long the shimmering animation takes to do one full sweep
                .setBaseAlpha(0.9f) //the alpha of the underlying children
                .setHighlightAlpha(0.8f) // the shimmer alpha amount
                .setDirection(Shimmer.Direction.LEFT_TO_RIGHT)
                .setAutoStart(true)
                .setBaseColor(Color.WHITE)
                .build();

        ShimmerDrawable shimmerDrawable = new ShimmerDrawable();
        shimmerDrawable.setShimmer(shimmer);

        Glide   .with(holder.itemView.getContext())
                .load(imageUrl)
                .centerCrop()
                .placeholder(shimmerDrawable)
                .into(holder.listImage);


        firebaseFirestore = FirebaseFirestore.getInstance();
        firebaseAuth = FirebaseAuth.getInstance();
        userId = firebaseAuth.getCurrentUser().getUid();

        //Get Fav
        firebaseFirestore.collection("Users/" + userId + "/Favorites").document(blockId).addSnapshotListener(new EventListener<DocumentSnapshot>() {
            @RequiresApi(api = Build.VERSION_CODES.LOLLIPOP)
            @Override
            public void onEvent(@Nullable DocumentSnapshot documentSnapshot, @Nullable FirebaseFirestoreException e) {

                if (documentSnapshot.exists()){
                    holder.listFav.setImageDrawable(context.getDrawable(R.drawable.fav_btn_full));
                }else {
                    holder.listFav.setImageDrawable(context.getDrawable(R.drawable.fav_btn_emp));
                }

            }
        });


        //Fav Feature
        holder.listFav.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View v) {

                firebaseFirestore.collection("Users/" + userId + "/Favorites").document(blockId).get().addOnCompleteListener(new OnCompleteListener<DocumentSnapshot>() {
                    @Override
                    public void onComplete(@NonNull Task<DocumentSnapshot> task) {

                        if (!task.getResult().exists()){

                            Map<String,Object> favMap = new HashMap<>();
                            favMap.put("id", blockId);
                            firebaseFirestore.collection("Users/" + userId + "/Favorites").document(blockId).set(favMap);

                        }else {
                            firebaseFirestore.collection("Users/" + userId + "/Favorites").document(blockId).delete();
                        }
                    }
                });
            }
        });
    }

    @Override
    public int getItemCount() {
        if(blockListModels == null){
            return 0;
        } else {
            return blockListModels.size();
        }}

    @Override
    public Filter getFilter() {
        return blocksFilter;
    }

    private Filter blocksFilter = new Filter() {
        @Override
        protected FilterResults performFiltering(CharSequence constraint) {
            List<BlockListModel> filteredList = new ArrayList<>();
            if (constraint == null || constraint.length() == 0) {
                filteredList.addAll(blockListModelsFull);
            }else {
                String filterPattern = constraint.toString().toLowerCase().trim();

                for (BlockListModel item : blockListModelsFull) {
                    if (item.getName().toLowerCase().contains(filterPattern)) {
                        filteredList.add(item);
                    }
                }
            }

            FilterResults results = new FilterResults();
            results.values = filteredList;
            results.count = filteredList.size();
            return results;
        }

        @Override
        protected void publishResults(CharSequence constraint, FilterResults results) {
        blockListModels.clear();
        blockListModels.addAll((List) results.values);
        notifyDataSetChanged();
        }
    };

    public class BlockViewHolder extends RecyclerView.ViewHolder implements View.OnClickListener {

        private ImageView listImage;
        private TextView listTitle;
        private ImageButton listFav;

        public BlockViewHolder(@NonNull View itemView) {
            super(itemView);

            listImage = itemView.findViewById(R.id.list_image);
            listTitle = itemView.findViewById(R.id.list_title);
            listFav = itemView.findViewById(R.id.favBtn);

            listTitle.setOnClickListener(this);
            listImage.setOnClickListener(this);

        }

        @Override
        public void onClick(View v) { onBlockListItemClicked.onItemClicked(getAdapterPosition());

        }
    }
        public interface OnBlockListItemClicked {
        void onItemClicked(int position);
    }
}

片段中的搜索功能：

searchView = view.findViewById(R.id.search_text);
        searchView.setImeOptions(EditorInfo.IME_ACTION_DONE);
        searchView.setQueryHint("Search");

        searchView.setOnQueryTextListener(new SearchView.OnQueryTextListener() {
            @Override
            public boolean onQueryTextSubmit(String query) {
                return false;
            }

            @Override
            public boolean onQueryTextChange(String newText) {

                if(newText.length() > 0){
                    recoView.setVisibility(View.GONE);
                    recommended.setVisibility(View.GONE);

                }else {
                    recoView.setVisibility(View.VISIBLE);
                    recommended.setVisibility(View.VISIBLE);

                }
                adapter.getFilter().filter(newText);
                return false;
            }
        });

注意：我按照lesson 将搜索添加到我的应用程序。

Answer 1

at java.util.ArrayList.addAll(ArrayList.java:588)
at com.quiltur.blocks.BlockListAdapter$3.publishResults(BlockListAdapter.java:174)

publishResults() 中存在导致 NPE 的问题。我怀疑当您再次从片段返回到适配器时，blockListModels 会得到一个空值，不确定片段中是否有东西让它为空；所以在设置它的值之前尽量避免在它上面调用方法

我注释掉了旧代码并添加了新代码。

    @Override
    protected void publishResults(CharSequence constraint, FilterResults results) {
       // blockListModels.clear();
       // blockListModels.addAll((List) results.values);

       blockListModels = (List<BlockListModel>) results.values;
       notifyDataSetChanged();
    }

更新

尝试此代码时，应用程序没有关闭，但出现了两个新问题。第一个是当recyclerview 回到fragment 时消失。第二个在搜索时，recyclerview的项目位置出现不平衡（在旧代码中不会发生这种情况）

现在回滚上述技巧以保持blockListModels 不为空，并有意将其设置在performFiltering 内

所以过滤器将是：

private Filter blocksFilter = new Filter() {
        @Override
        protected FilterResults performFiltering(CharSequence constraint) {
            List<BlockListModel> filteredList = new ArrayList<>();
            if (constraint == null || constraint.length() == 0) {
                filteredList.addAll(blockListModelsFull);
            }else {
                String filterPattern = constraint.toString().toLowerCase().trim();

                for (BlockListModel item : blockListModelsFull) {
                    if (item.getName().toLowerCase().contains(filterPattern)) {
                        filteredList.add(item);
                    }
                }
        
            }

            // Setting the blockListModels
            blockListModels = filteredList; // <<< Here is the change 
        
            FilterResults results = new FilterResults();
            results.values = filteredList;
            results.count = filteredList.size();
            return results;
        }

        @Override
        protected void publishResults(CharSequence constraint, FilterResults results) {
            blockListModels.clear();
            blockListModels.addAll((List) results.values);
            notifyDataSetChanged();
        }
};