构造函数中的函数以某种方式调用自身

Question

此代码引发错误 - “无法读取未定义的属性 'x'”。 我想分配这个函数，然后用一个参数调用它（函数“crash”回答关于与其他对象碰撞的问题）。

function Obj(x, y, height, width, type) {
            this.x = x;
            this.y = y;
            this.width = width;
            this.height = height;

            if(type == "obstacle") {
                this.speedX = levelManager.level;
            }

            var self = this;
            this.isNotUsed = function() {
                return self.x < 0;
            };

            this.drawSelf = function(img) {
                ctx.drawImage(img, self.x, self.y, self.width, self.height);
            };
            if(type == "hero"){
                this.crash = function(otherObj) {
                    var myLeft = this.x;
                    var myRight = this.x + this.width;
                    var myBottom = this.y + this.height;
                    var otherLeft = (otherObj.x) || 0;  //error occurs here
                    var otherRight = (otherObj.x + otherObj.width) || 0;
                    var otherTop = otherObj.y || 0;
                    var collision = true;

                    if((myBottom < otherTop) ||
                        (myRight < otherLeft) ||
                        (myLeft > otherRight)) {collision = false;}

                    return collision;
                };
            }
        }
var hero = new Obj(0, 0, 40, 40, "hero");

Answer 1

代码运行良好（参见 sn-p）。如果您在没有任何参数的情况下调用hero.crash()，您可能会遇到的唯一错误。为避免这种情况，您可以将 crash() 函数更改为函数otherObject = otherObject || {}; 的第一行。或者更好，如 cmets 中所建议，如果 otherObject 未定义，则返回：

if (!otherObject) return false;

或者如果它不是一个对象

if (typeof otherObject !== 'object') return false;

function Obj(x, y, height, width, type) {
            this.x = x;
            this.y = y;
            this.width = width;
            this.height = height;

            if(type == "obstacle") {
                this.speedX = levelManager.level;
            }

            var self = this;
            this.isNotUsed = function() {
                return self.x < 0;
            };

            this.drawSelf = function(img) {
                ctx.drawImage(img, self.x, self.y, self.width, self.height);
            };
            if(type == "hero"){
                this.crash = function(otherObj) {
                    var myLeft = this.x;
                    var myRight = this.x + this.width;
                    var myBottom = this.y + this.height;
                    var otherLeft = (otherObj.x) || 0;  //error occurs here
                    var otherRight = (otherObj.x + otherObj.width) || 0;
                    var otherTop = otherObj.y || 0;
                    var collision = true;

                    if((myBottom < otherTop) ||
                        (myRight < otherLeft) ||
                        (myLeft > otherRight)) {collision = false;}

                    return collision;
                };
            }
        }


var hero = new Obj(0, 0, 40, 40, "hero");
console.log('THIS IS PRINTED')
console.log(hero.crash('{}'));
console.log('BUT FROM HERE NO MORE');
console.log(hero.crash());