【发布时间】:2021-12-09 13:15:00
【问题描述】:
下面的这个 Perl 脚本每行插入需要 1 秒,当要插入很多行时,它的效率非常低。如果输入文件有超过 1,000,000 行,此脚本将需要大约 1,000,000 行。 12 天插入。
样本数据(行)
/mnt/SYN/TEST-Dropbox/Documents/TempBM/10-07-19.docx
/mnt/SYN/CLIENT-DROPBOX-GSUITE/Dropbox-TEST/My Mac (TEST-iMac-Pro.local)/Documents/TempBM/10-07-19.docx
/mnt/SYN/TEST-Dropbox/Documents/TO BE TRANSCRIBED LATER/LASTNAME, FIRSTNAME, Tape 2 (Inaudible)/LASTNAME, FIRSTNAME, TAPE 2 SIDE B (Inaudible).mp3
/mnt/SYN/CLIENT-SYNOLOGY/A. TO BE TRANSCRIBED/*TO BE TRANSCRIBED LATER/LASTNAME, FIRSTNAME, Tape 2 (Inaudible)/LASTNAME, FIRSTNAME, TAPE 2 SIDE B (Inaudible).mp3
/mnt/SYN/CLIENT-SYNOLOGY/DropboxBackup/*TO BE TRANSCRIBED LATER/LASTNAME, FIRSTNAME, Tape 2 (Inaudible)/LASTNAME, FIRSTNAME, TAPE 2 SIDE B (Inaudible).mp3
/mnt/SYN/CLIENT-DROPBOX-GSUITE/Dropbox-TEST/My Mac (TEST-iMac-Pro.local)/Documents/TO BE TRANSCRIBED LATER/LASTNAME, FIRSTNAME, Tape 2 (Inaudible)/LASTNAME, FIRSTNAME, TAPE 2 SIDE B (Inaudible).mp3
脚本
use strict;
use warnings;
use DateTime;
use DBI;
my $inputfile = shift || "-1";
my $startline = shift || "-1";
my $endline = shift || "-1";
if (($inputfile eq "-1") || ($startline eq "-1") || ($endline eq "-1") ){
print "USAGE: $0 <name_of_file.txt> START_LINE_NUMBER END_LINE_NUMBER\n";
}
my $group_id = 1;
my $linecounter = 0;
my $dsn = "DBI:MariaDB:Potato1";
my $username = "root";
my $password = "";
my %attr = ( PrintError=>1, RaiseError=>1);
my $dbh = DBI->connect($dsn, $username, $password, \%attr);
print "Connected to MYSQL database";
my $sql = "INSERT INTO GMCfiles_tbl(file_id, file_add_date, group_id, filename, status, status_author, status_date) VALUES (?, ?, ?, ?, ?, ?, ?)";
my $stmt = $dbh->prepare($sql);
open(INFILE, "< $inputfile") or die "Could NOT open $inputfile";
while(<INFILE>) {
my $data = $_;
$linecounter++;
if (length($data) < 5) {
$group_id++;
sleep 2;
} else {
my $file_add_date = DateTime->now;
my $filename = $data;
my $status = "New";
my $status_author="";
my $status_date = DateTime->now;
if ( ($linecounter >= $startline) && ($linecounter <= $endline) ) {
if ($stmt->execute($linecounter, $file_add_date, $group_id, $filename, $status, $status_author, $status_date)){
print "Row inserted successfully LINE $linecounter -- GROUP $group_id\n";
}
if ( ($linecounter > 0) && (($linecounter % 10) == 0) ) {
print "We're processing LINE $linecounter\n";
}
}
}
}
close(INFILE);
$stmt->finish();
$dbh->disconnect;
因为这个脚本会运行几天。有人能指出提高效率的方法吗?
【问题讨论】:
-
将所有插入包装在一个事务中?
-
DBIx::Connector是一个很好的事务管理包装器,或者只使用 DBIbegin_work()和commit()方法。 -
微优化:您不需要在循环中创建两个不同的
DateTime对象。或者那些$status和$status_author变量,当分配给它们的值永远不会改变时。使用文字或将它们提升到循环之外。 -
尝试运行你的程序并注释掉execute()方法调用。这将告诉您问题出在 perl 端还是 DB 端。乍一看,脚本不可能每行占用一秒钟。
-
您的代码中有一行
sleep 2。这将使您的程序等待输入文件中少于 5 个字符(包括换行符)的每行 2 秒。你不知道吗?