【发布时间】:2020-05-13 16:06:49
【问题描述】:
我编写了一个递归求和并行函数,它获取一个数字向量、一个线程池和向量大小,它应该返回向量的总和,但是当我想使用时,如下例所示,20 个单元格大小的向量,我必须使用至少 8 个线程,否则程序将被卡住并且无法完成(并且不会抛出错误)。
这是我正在使用的线程池代码:
#ifndef THREAD_POOL_H
#define THREAD_POOL_H
#include <vector>
#include <queue>
#include <memory>
#include <thread>
#include <mutex>
#include <condition_variable>
#include <future>
#include <functional>
#include <stdexcept>
class ThreadPool {
public:
ThreadPool(size_t);
template<class F, class... Args>
auto enqueue(F&& f, Args&&... args)
-> std::future<typename std::result_of<F(Args...)>::type>;
~ThreadPool();
private:
// need to keep track of threads so we can join them
std::vector< std::thread > workers;
// the task queue
std::queue< std::function<void()> > tasks;
// synchronization
std::mutex queue_mutex;
std::condition_variable condition;
bool stop;
};
// the constructor just launches some amount of workers
inline ThreadPool::ThreadPool(size_t threads)
: stop(false)
{
for(size_t i = 0;i<threads;++i)
workers.emplace_back(
[this]
{
for(;;)
{
std::function<void()> task;
{
std::unique_lock<std::mutex> lock(this->queue_mutex);
this->condition.wait(lock,
[this]{ return this->stop || !this->tasks.empty(); });
if(this->stop && this->tasks.empty())
return;
task = std::move(this->tasks.front());
this->tasks.pop();
}
task();
}
}
);
}
// add new work item to the pool
template<class F, class... Args>
auto ThreadPool::enqueue(F&& f, Args&&... args)
-> std::future<typename std::result_of<F(Args...)>::type>
{
using return_type = typename std::result_of<F(Args...)>::type;
auto task = std::make_shared< std::packaged_task<return_type()> >(
std::bind(std::forward<F>(f), std::forward<Args>(args)...)
);
std::future<return_type> res = task->get_future();
{
std::unique_lock<std::mutex> lock(queue_mutex);
// don't allow enqueueing after stopping the pool
if(stop)
throw std::runtime_error("enqueue on stopped ThreadPool");
tasks.emplace([task](){ (*task)(); });
}
condition.notify_one();
return res;
}
// the destructor joins all threads
inline ThreadPool::~ThreadPool()
{
{
std::unique_lock<std::mutex> lock(queue_mutex);
stop = true;
}
condition.notify_all();
for(std::thread &worker: workers)
worker.join();
}
#endif
这是我的求和并行函数:
int Sum_Parallelled(int *begin, ThreadPool *threadPool,int size) {
if (size == 1) {
return *begin;
} else {
auto res = threadPool->enqueue(Sum_Parallelled, (begin), threadPool, size / 2);
if (size % 2 == 0) {
return Sum_Parallelled(begin + (size / 2), threadPool, size / 2) + res.get();
} else {
return Sum_Parallelled(begin + (size / 2), threadPool, size / 2 + 1) + res.get();
}
}
}
这是主要的功能代码:
int main() {
std::vector<int> vec;
for(int i = 0; i < 20; i++){ // creating a vector with x cells.
vec.push_back(i);
}
ThreadPool threadPool(8); // creating a threadpool with y threads.
int size = vec.size();
int sum = threadPool.enqueue(Sum_Parallelled,vec.data(),&threadPool,size).get();
std::cout << "The sum in the parallel sum: " << sum << std::endl;
return 0;
}
【问题讨论】:
-
请提取并提供minimal reproducible example 作为您问题的一部分。我看到了一些看起来有问题的东西,但是如果没有您的代码的更多部分,就无法判断。
-
我尝试调试它,但它停止工作,我不知道为什么,这就是我给出示例的原因
-
我相信你,但这不是重点。这里的每个人都应该能够获取您的代码,将其放入单个文件并进行编译。没有多个文件,没有修改代码,没有手动输入(这里不是问题)——代码应该可以用作您问题的示例。
标签: c++ recursion parallel-processing sum threadpool