【发布时间】:2019-12-12 12:58:34
【问题描述】:
大家好,我正在尝试实现基本的 CRUD 功能,但困扰我的是 CrudRepository 在保存重复实体时没有抛出任何异常,你能告诉我这里缺少什么吗?
我无法通过的测试如下:
@Test
void onDuplicate() {
ReviewEntity duplicated = savedReviewEntity;
assertEquals(savedReviewEntity.getId(), duplicated.getId());
assertThrows(DataIntegrityViolationException.class, () -> {
reviewRepository.save(duplicated);
});
}
这是实体的样子:
@NoArgsConstructor
@AllArgsConstructor
@Builder
@Getter
@Setter
@Entity
@Table(name = "reviews", indexes = { @Index(name = "reviews_unique_idx", unique = true, columnList = "movieId,reviewId") })
public class ReviewEntity {
@Id
@GeneratedValue
private Integer id;
@Version
private Integer version;
private Integer movieId;
private Integer reviewId;
private String author;
private String subject;
private String content;
private String serviceAddress;
}
我正在使用 CrudRepository
public interface ReviewRepository extends CrudRepository<ReviewEntity, Integer> {
@Transactional(readOnly = true)
List<ReviewEntity> findByMovieId(int movieId);
}
我想看看整个测试类的样子:
@ExtendWith(SpringExtension.class)
@DataJpaTest
@Transactional(propagation = NOT_SUPPORTED)
class ReviewRepositoryTest {
public static final int BASE_MOVIE_ID = 1;
public static final int BASE_REVIEW_ID = 2;
@Autowired
ReviewRepository reviewRepository;
ReviewEntity savedReviewEntity;
@Autowired
EntityManager entityManager;
@BeforeEach
void setUp() {
reviewRepository.deleteAll();
ReviewEntity reviewEntity = ReviewEntity.builder()
.movieId(BASE_MOVIE_ID)
.reviewId(BASE_REVIEW_ID)
.author("Fake Author")
.content("Fake Content")
.subject("Fake Subject")
.serviceAddress("Fake Service Address")
.build();
savedReviewEntity = reviewRepository.save(reviewEntity);
assertReview(reviewEntity, savedReviewEntity);
}
@Test
void create() {
reviewRepository.deleteAll();
ReviewEntity reviewEntity = ReviewEntity.builder()
.movieId(BASE_MOVIE_ID)
.reviewId(BASE_REVIEW_ID)
.author("Fake Author")
.content("Fake Content")
.subject("Fake Subject")
.serviceAddress("Fake Service Address")
.build();
ReviewEntity saved = reviewRepository.save(reviewEntity);
assertReview(reviewEntity, saved);
}
@Test
void update() {
String updatedContent = "Updated Content";
savedReviewEntity.setContent(updatedContent);
reviewRepository.save(savedReviewEntity);
ReviewEntity updated = reviewRepository.findById(savedReviewEntity.getId()).get();
assertEquals(updatedContent, updated.getContent());
}
@Test
void delete() {
reviewRepository.delete(savedReviewEntity);
assertEquals(0, reviewRepository.count());
}
@Test
void findByMovieId() {
List<ReviewEntity> reviewEntities = reviewRepository.findByMovieId(savedReviewEntity.getMovieId());
ReviewEntity firstEntity = reviewEntities.get(0);
assertThat(reviewEntities, hasSize(1));
assertReview(savedReviewEntity, firstEntity);
}
@Test
void onDuplicate() {
ReviewEntity duplicated = savedReviewEntity;
assertEquals(savedReviewEntity.getId(), duplicated.getId());
assertThrows(DataIntegrityViolationException.class, () -> {
reviewRepository.save(duplicated);
});
}
@Test
void optimisticLockVerification() {
String r1ConcurrentContent = "r1ConcurrentContent";
String r2ConcurrentContent = "r2ConcurrentContent";
ReviewEntity r1 = reviewRepository.findById(savedReviewEntity.getId()).get();
ReviewEntity r2 = reviewRepository.findById(savedReviewEntity.getId()).get();
r1.setContent(r1ConcurrentContent);
reviewRepository.save(r1);
try {
r2.setContent(r2ConcurrentContent);
reviewRepository.save(r2);
fail("Expected an OptimisticLockingFailureException");
} catch (OptimisticLockingFailureException e) {
System.out.println("OptimisticLockingFailureException should be throw.");
}
ReviewEntity updated = reviewRepository.findById(savedReviewEntity.getId()).get();
assertEquals(1, (int) updated.getVersion());
assertEquals(r1ConcurrentContent, updated.getContent());
}
private void assertReview(ReviewEntity expected, ReviewEntity actual) {
assertAll("Executing assertReview(..)", () -> {
assertEquals(expected.getId(), actual.getId());
assertEquals(expected.getVersion(), actual.getVersion());
assertEquals(expected.getMovieId(), actual.getMovieId());
assertEquals(expected.getReviewId(), actual.getReviewId());
assertEquals(expected.getContent(), actual.getContent());
assertEquals(expected.getAuthor(), actual.getAuthor());
assertEquals(expected.getSubject(), actual.getSubject());
assertEquals(expected.getServiceAddress(), actual.getServiceAddress());
});
}
}
【问题讨论】:
-
能否提供SQL模型和约束?
-
我还没有真正的sql数据库。作为数据库环境,我现在使用的是 H2。
-
我猜你需要在
reviews表的idcolumn 上添加一个唯一约束,除非你不会有任何重复的异常。
标签: spring hibernate jpa integration-testing junit5