【发布时间】：2017-12-28 09:33:46
【问题描述】：
我有一个函数，它使用 JPA Criteria API 根据我传递给它的一些参数从数据库中检索数据。
参数使用gridParams 对象传递，如下：
public List<MyObjectDTO> find(final GridParamsDTO gridParams) {
final CriteriaBuilder builder = getCriteriaBuilder();
final List<Predicate> predicates = new ArrayList<>();
final CriteriaQuery<MyObjectDTO> criteriaQuery = builder.createQuery(MyObjectDTO.class);
final Root<MyObject> from = criteriaQuery.from(MyObject.class);
Join<MyObject, AnotherObject> join = from.join(MyObject_.anotherObject, JoinType.LEFT);
if ((gridParams.getFilter() != null) && (gridParams.getFilter().length > 0)) {
for (final GridFilterDTO filter : gridParams.getFilter()) {
if ("fieldX".equals(filter.getField())) {
final List<Predicate> sqPredicates = new ArrayList<>();
Subquery<Long> sq = criteriaQuery.subquery(Long.class);
Root<ObjectX> sqFrom = sq.from(ObjectX.class);
sqPredicates
.add(builder.equal(sqFrom.get(ObjectX_.organismeIDE), filter.getFilterSingleValue()));
sq.select(sqFrom.get(ObjectX_.referentielID).get(MyObject_.objectX));
sq.where(builder.and(sqPredicates.toArray(new Predicate[sqPredicates.size()])));
predicates.add(builder.in(from.get(MyObject_.objectX)).value(sq));
}
if ("fieldA".equals(filter.getField()) || "fieldB".equals(filter.getField())) {
final GridFilterOperatorEnum gridFilterEnumValues = GridFilterOperatorEnum.values()[filter.getOperator().ordinal()];
switch (gridFilterEnumValues) {
case TEXT_CONTAINS:
predicates.add(builder.like(builder.upper(from.get(filter.getField())), "%" + filter.getFilterSingleValue().toUpperCase() + "%"));
break;
case TEXT_START_WITH:
predicates.add(builder.like(builder.upper(from.get(filter.getField())), filter.getFilterSingleValue().toUpperCase() + "%"));
break;
case TEXT_DIFFERENT:
predicates.add(builder.notEqual(from.get(filter.getField()), filter.getFilterSingleValue()));
break;
case TEXT_END_WITH:
predicates.add(builder.like(builder.upper(from.get(filter.getField())), "%" + filter.getFilterSingleValue().toUpperCase()));
break;
case TEXT_EQUALS:
predicates.add(builder.equal(builder.upper(from.get(filter.getField())), filter.getFilterSingleValue().toUpperCase()));
break;
default:
break;
}
}
if ("dateField1".equals(filter.getField()) || "dateField2".equals(filter.getField())) {
final GridFilterOperatorEnum gridFilterEnumValues = GridFilterOperatorEnum.values()[filter.getOperator().ordinal()];
switch (gridFilterEnumValues) {
case DATE_EQUALS:
predicates.add(builder.equal(from.<LocalDate> get(filter.getField()), LocalDate.parse(filter.getFilterSingleValue())));
break;
case DATE_BEFORE:
predicates.add(builder.lessThan(from.<LocalDate> get(filter.getField()), LocalDate.parse(filter.getFilterSingleValue())));
break;
case DATE_AFTER:
predicates.add(builder.greaterThan(from.<LocalDate> get(filter.getField()), LocalDate.parse(filter.getFilterSingleValue())));
break;
case DATE_BETWEEN:
predicates.add(
builder.between(from.<LocalDate> get(filter.getField()), LocalDate.parse(filter.getFilterSetValues()[0]),
LocalDate.parse(filter.getFilterSetValues()[1])));
break;
default:
break;
}
}
if ("anotherField".equals(filter.getField())) {
if (filter.getFilterSetValues().length > 0) {
predicates
.add(builder.isTrue(join.get(AnotherObject_.lib).in((Object[]) filter.getFilterSetValues())));
} else {
predicates.add(join.get(AnotherObject_.lib).isNull());
}
}
}
}
if (gridParams.hasSort()) {
List<Order> orderList = new ArrayList<>();
for (IGridSort gridSort : gridParams.getSort()) {
if (ArrayUtils.contains(new String[] { "fieldA", "dateField1", "dateField2", "fieldB" }, gridSort.getField())) {
if (gridSort.getSort().equalsIgnoreCase(GridSortDTO.ASC)) {
orderList.add(builder.asc(from.get(gridSort.getField())));
} else if (gridSort.getSort().equalsIgnoreCase(GridSortDTO.DESC)) {
orderList.add(builder.desc(from.get(gridSort.getField())));
}
}
if (gridSort.getField().equalsIgnoreCase("anotherField")) {
if (gridSort.getSort().equalsIgnoreCase(GridSortDTO.ASC)) {
orderList.add(builder.asc(join.get(AnotherObject_.lib)));
} else if (gridSort.getSort().equalsIgnoreCase(GridSortDTO.DESC)) {
orderList.add(builder.desc(join.get(AnotherObject_.lib)));
}
}
}
if (!orderList.isEmpty()) {
criteriaQuery.orderBy(orderList);
}
}
predicates.add(builder.between(builder.literal(LocalDate.now()), from.get(MyObject_.dateDebut),
from.get(MyObject_.dateFin)));
criteriaQuery.multiselect(from.get(MyObject_.objectX), from.get(MyObject_.dateDebut), from.get(MyObject_.dateFin),
from.get(MyObject_.lib), from.get(MyObject_.coleur), join,
from.get(MyObject_.refExterne));
criteriaQuery.where(builder.and(predicates.toArray(new Predicate[predicates.size()])));
criteriaQuery.distinct(true);
final TypedQuery<MyObjectDTO> typedQuery = getEntityManager().createQuery(criteriaQuery);
if (gridParams.hasStart()) {
typedQuery.setFirstResult(gridParams.getStartRow());
}
if (gridParams.hasEnd()) {
typedQuery.setMaxResults(gridParams.getEndRow() - Math.max(0, gridParams.getStartRow()));
}
return typedQuery.getResultList();
}
}
问题是SonarQube抱怨这个方法“find”的圈复杂度是31，大于授权的30，我做了一些研究，我发现我必须重构我的函数以降低圈复杂度。
在这个函数中，我必须测试gridParams 是否定义了 4 个字段：（开始、结束、排序和过滤），排序和过滤是对象数组，所以我必须遍历它们。
最终我需要检查很多字段，如果没有大量检查，我看不到如何做到这一点：/
我该如何解决这个问题？
【问题讨论】：
-
乍一看，你需要摆脱深层的
if-else层次结构才能快速修复它。 -
这个方法很臃肿，所以为了摆脱声纳问题，只需将方法拆分成更小的方法
标签： java refactoring cyclomatic-complexity