RSpec 在 POST 中失败并出现错误：失败/错误未实现：调用

Question

我正在尝试测试来自 Slack API 的方法 postMessage 端点，该端点负责在 Slack 上发送消息。

如您所见，这是一个简单的 HTTPost 请求：

module Slack
  class Messenger
    def initialize(event)
      @event = event
    end

    def call
      HTTParty.post('https://slack.com/api/chat.postMessage', body: params, headers: headers)
    end

    private

    attr_reader :event

    def params
      {
        token: Settings.slack_token,
        channel: Slack::GetUserId.new(parsed_email).call,
        text: Slack::ReporterTextMessage.new(parsed_name, parsed_ticket_number).call,
        as_user: true
      }
    end
#here are methods: parsed_email, parsed_name, parsed_ticket_number

所以我做了 RSpec 测试：

RSpec.describe Slack::Messenger do
  subject { described_class.new(event) }
  let(:event) { File.new('./spec/support/events/event.json').read }

  describe 'call' do
    let(:valid_params) do
      {
        token: 'token',
        channel: '12345',
        text: 'This is a message',
        as_user: true
      }
    end
    let(:response) { subject.call }
    before do
      allow(HTTParty).to receive(:post).and_return(valid_params)
    end

    it "returns specific params" do
      allow_any_instance_of(Slack::SlackMessenger).to receive(:call).and_return(valid_params)
      expect(response).to receive(:call).with(valid_params)
    end
  end
end

我的模拟很糟糕，因为我遇到了一个错误：

 Failure/Error: expect(response).to receive(:call).with(valid_params)
   {:token=>"token", :channel=>"12345", :text=>"This is a message", :as_user=>true} does not implement: call

编辑： 嘲笑后我得到一个错误：

1) Slack::SlackMessenger call call HTTParty
   Failure/Error: subject.call

   TypeError:
     no implicit conversion of nil into String
   # /Users/usr/.rvm/gems/ruby-2.5.0/gems/json-2.2.0/lib/json/common.rb:156:in `initialize'
   # /Users/usr/.rvm/gems/ruby-2.5.0/gems/json-2.2.0/lib/json/common.rb:156:in `new'
   # /Users/usr/.rvm/gems/ruby-2.5.0/gems/json-2.2.0/lib/json/common.rb:156:in `parse'
   # ./source/parsers/jira_parser.rb:9:in `initialize'
   # ./source/slack/messenger.rb:30:in `new'
   # ./source/slack/messenger.rb:30:in `parsed_email'
   # ./source/slack/messenger.rb:23:in `params'
   # ./source/slack/messenger.rb:13:in `call'
   # ./spec/source/slack/messenger_spec.rb:56:in `block (3 levels) in <top (required)>'

Answer 1

我觉得应该是这样的：

RSpec.describe Slack::Messenger do
  subject { described_class.new(event) }
  let(:event) { File.new('./spec/support/events/event.json').read }

  describe 'call' do
    before do
      allow(HTTParty).to receive(:post).with(any_args)
    end

    it "call HTTParty" do
      subject.call
      expect(HTTParty).to have_received(:post)
    end
  end
end

但我建议存根这些参数：

def params
  {
    token: Settings.slack_token,
    channel: Slack::GetUserId.new(parsed_email).call,
    text: Slack::ReporterTextMessage.new(parsed_name, parsed_ticket_number).call,
    as_user: true
  }
end

让它看起来像：

RSpec.describe Slack::Messenger do
  subject { described_class.new(event) }
  let(:event) { File.new('./spec/support/events/event.json').read }

  describe 'call' do
    let(:slack_url) { 'https://slack.com/api/chat.postMessage' }
    let(:valid_params) do
      {
        token: 'token',
        channel: '12345',
        text: 'This is a message',
        as_user: true
      }
    end

    before do
      allow(Settings).to receive(:slack_token).and_return(valid_params[:token])
      ...
      allow(HTTParty).to receive(:post).with(slack_url, body: valid_params, header: ..)
    end

    it "call HTTParty with valid params" do
      subject.call
      expect(HTTParty).to have_received(:post).with(slack_url, body: valid_params, header: ..)
    end
  end
end