【问题标题】:panic: sync: negative WaitGroup counter恐慌:同步:负 WaitGroup 计数器
【发布时间】:2018-11-22 14:52:21
【问题描述】:

我的目标是使用 goroutines 和 channel,我想学习如何在不同的 goroutines 之间进行通信,并且我想避免死锁。我设法使用sync.WaitGroup,它工作得很好。

但是我收到一个错误提示

1 恐慌:同步:负 WaitGroup 计数器

goroutine 19 [运行中]:

这个程序的目标很简单。

  1. 创建开发者
  2. 指派他/她创建网站
  3. 取决于网站的数量
  4. 网站完成后,将其附加到数组中
  5. 让有20个网站和5个开发者
  6. 每个开发者将创建 4 个网站并将其附加到网站数组中
  7. 我想同时做,这样其他开发者就不用等了

代码:

package main

import (
  "fmt"
  "sync"
  "time"
)

type developer struct {
    name              string
    setTimeForWebsite time.Time
}

type website struct {
   owner   string
   created time.Time
}

var developers []developer
var websites []website

// A function to create a developer
 func hireDeveloper(wg *sync.WaitGroup, workNumber int, 
   developerCreatedc chan developer, devs []developer) {
   defer wg.Done()
   developerNumber := fmt.Sprintf("developer_%d", workNumber)
   d := developer{name: developerNumber}
   fmt.Println("Hired", d.name)
   developerCreatedc <- d
 }

 // A function to create a website
  func createComputer(wg *sync.WaitGroup, developerCreatedc chan developer, websitePerComputer int, websites []website) {
  defer wg.Done()
   // Assign the developer to the website creation // N number of the website
  d := <-developerCreatedc
  for i := 0; i <= websitePerComputer; i++ {
    fmt.Println("Delegate", d.name, "to set the time to start 
    building the website")
    d.setTimeForWebsite = time.Now()
    fmt.Println(d.name, "Finish calculating to build the website", d.setTimeForWebsite)
    web := website{owner: d.name, created: d.setTimeForWebsite}
    websites = append(websites, web)
    fmt.Println(len(websites))
    time.Sleep(time.Second * 2)
    fmt.Println(d.name, "Created website at", web.created)
   }

  }

func main() {

  // Make a channel for when developer is hired 
  developerCreatedC := make(chan developer)
  // create a sync group
  wg := &sync.WaitGroup{}
  // Assume that number of websites are 20
  numberOfWebsites := 20
  // Assume that number of developers are 5
  numberOfDevelopers := 5
  // Divide the websites to 5 developers
  websitePerDeveloper := numberOfWebsites / numberOfDevelopers
  // add the sync
  wg.Add(1)
  for i := 1; i <= numberOfDevelopers; i++ {
    go func(producerNumber int) {
        hireDeveloper(wg, producerNumber, developerCreatedC, 
        developers)
    }(i)
   }

  wg.Add(1)
  for i := 1; i <= websitePerDeveloper; i++ {
    createComputer(wg, developerCreatedC, 5, websites)
  }

  wg.Wait()
}

游乐场 https://play.golang.org/p/QSOv5jp3T94

这种行为有时有点,一位开发人员创建了超过 4 个网站,即使它应该只创建 4 个

谢谢

【问题讨论】:

    标签: go concurrency


    【解决方案1】:

    wg.Add() 应该等于你正在运行的 goroutine 的数量。 createComputer(wg, developerCreatedC, websitePerDeveloper, websites) 也应该是每个开发者的基础。

    package main
    
    import (
        "fmt"
        "sync"
        "time"
    )
    
    type developer struct {
        name              string
        setTimeForWebsite time.Time
    }
    
    type website struct {
        owner   string
        created time.Time
    }
    
    var developers []developer
    var websites []website
    
    // A function to create a developer
    func hireDeveloper(wg *sync.WaitGroup, workNumber int, developerCreatedc chan developer, devs []developer) {
        defer wg.Done()
        developerNumber := fmt.Sprintf("developer_%d", workNumber)
        d := developer{name: developerNumber}
        fmt.Println("Hired", d.name)
        developerCreatedc <- d
    }
    
    // A function to create a website
    func createComputer(wg *sync.WaitGroup, developerCreatedc chan developer, websitePerComputer int, websites []website) {
        defer wg.Done()
        // Assign the developer to the website creation // N number of the website
        d := <-developerCreatedc
        for i := 0; i <= websitePerComputer; i++ {
            fmt.Println("Delegate", d.name, "to set the time to start building the website")
            d.setTimeForWebsite = time.Now()
            web := website{owner: d.name, created: d.setTimeForWebsite}
            websites = append(websites, web)
            fmt.Println(len(websites))
            time.Sleep(time.Second * 2)
            fmt.Println(d.name, "Created website at", web.created)
        }
    
    }
    
    func main() {
    
        // Make a channel for when developer is hired 
        developerCreatedC := make(chan developer)
        // create a sync group
        wg := &sync.WaitGroup{}
        // Assume that number of websites are 20
        numberOfWebsites := 20
        // Assume that number of developers are 5
        numberOfDevelopers := 5
        // Divide the websites to 5 developers
        websitePerDeveloper := numberOfWebsites / numberOfDevelopers
    
        for i := 1; i <= numberOfDevelopers; i++ {
            // add the sync
            wg.Add(1)
            go func(producerNumber int) {
                hireDeveloper(wg, producerNumber, developerCreatedC, developers)
            }(i)
    
            wg.Add(1)
            go createComputer(wg, developerCreatedC, websitePerDeveloper, websites)
        }
    
        wg.Wait()
    }
    

    【讨论】:

    • 为什么网站的长度是0?
    • 在我把它添加到网站到数组之后?
    • @sinusGob 你发送websites 作为函数中的值调用。
    • 我如何通过引用发送? *网站?
    • 你能给我举个例子吗?
    【解决方案2】:

    您收到错误是因为您在循环之前执行了wg.Add(1)。 每次调用hireDeveloper() 和createComputer() 都会调用wg.Done(),所以已经在第一个for 循环中wg 想要倒计时到-4,这是不可能的,因此会出现恐慌。

    一个可能的解决方案是:

    wg.Add(numberOfDevelopers)
    for i := 1; i <= numberOfDevelopers; i++ {...}
    ....
    wg.Add(websitePerDeveloper)
    for i := 1; i <= websitePerDeveloper; i++ {...}
    

    或者你将 wg.Add 拉入 for 循环:

          for i := 1; i <= numberOfDevelopers; i++ {
            wg.Add(1)
            go func(producerNumber int) {
                hireDeveloper(wg, producerNumber, developerCreatedC, 
                developers)
            }(i)
       }
    

    【讨论】:

    • 我收到fatal error: all goroutines are asleep - deadlock!
    • 原因可能在于您的频道。现在它正确地阻塞在 wg.wait 并且你的主要 go 例程永远等待而不是提前退出。如果我发现了什么,我会更新答案。
    • @sinusGob 所以你收到一个死锁,因为你调用了 'createComputer' 20 次。在“createComputer”中,您要求开发人员(20 次,因为您将其称为 20 倍)但您只创建了 5 个。由于“d :=
    猜你喜欢
    • 2018-09-22
    • 1970-01-01
    • 2021-06-03
    • 2021-09-15
    • 1970-01-01
    • 1970-01-01
    • 1970-01-01
    • 1970-01-01
    • 2015-12-04
    相关资源
    最近更新 更多