【发布时间】:2015-12-06 15:35:27
【问题描述】:
解决方案 不小心剪掉了100个
我正在编写一个客户端-服务器程序,其中服务器是一个简单的 shell
所有命令都在工作,除了 /bin/sleep -- 即 rrsh> /bin/sleep 1&
我已经包含了我的整个 shell 代码——其中包括: - 从有效命令列表中检查命令是否有效 - 如果是则执行它
我的 shell 代码如下所示:
while((n = Rio_readlineb(&rio, buf, MAXLINE)) != 0){ //loop until connection has been terminated
if (!strcmp(buf, "quit\n")){
printf("User %s disconnected.\n", username);
flag1 = 0; //the user will need to login again
}
if (flag1 == 1){ //the user is loged in
bg = p3parseline(buf, argv_for_shell);
strtok(buf, "\n");
printf("User %s sent the command '%s' to be executed.\n", username, buf);
strcat(argv_for_shell[0], "\n");
//check if the command is allowed
flag2 = 0; //set command allowed? flag back to false
file = Fopen("rrshcommands.txt", "r");
while (Fgets(command, MAXLINE, file) != NULL){
if (!strcmp(argv_for_shell[0], command)){
flag2 = 1;
}
}
Fclose(file);
strtok(argv_for_shell[0], "\n");
if (flag2 == 0){ //case where the command is not allowed
printf("The command '%s' is not allowed.\n", buf);
strcpy(buf, "Command not allowed\n");
Rio_writen(connfd, buf, strlen(buf));
}
else{
if ((pid = fork()) == 0) { /* Child runs user job */
printf("Fork/Execing the command %s on behalf of the user.\n", argv_for_shell[0]);
Dup2(connfd, 1);
if (execve(argv_for_shell[0], argv_for_shell, environ) < 0) {
printf("%s: Command not found.\n", argv_for_shell[0]);
exit(0);
}
}
/* Parent waits for foreground job to terminate */
if (!bg) {
int status;
if (waitpid(pid, &status, 0) < 0)
unix_error("waitfg: waitpid error");
memset(&buf[0], 0, sizeof(buf)); //flush the buffer
Rio_writen(connfd, buf, strlen(buf));
}
else{
memset(&buf[0], 0, sizeof(buf)); //flush the buffer
Rio_writen(connfd, buf, strlen(buf));
}
signal(SIGCHLD, reap_background);
}
}
Close(connfd);
}
当我执行 /bin/sleep 1& 时,它应该移动到最后一个 else 块并向客户端写回一个空字符串
从调试开始,它卡在了一个奇怪的地方
93 if ((pid = fork()) == 0) { /* Child runs user job */
(gdb) p bg
$1 = 1
(gdb) n
104 if (!bg) {
(gdb) Fork/Execing the command /bin/sleep on behalf of the user.
/bin/sleep: invalid time interval ‘’
Try '/bin/sleep --help' for more information.
您可以看到 bg == 1,所以我猜它挂在 execve 代码中——这就是我收到该错误的原因。但是为什么 gdb 会移动到下一行呢?
【问题讨论】:
-
看起来
/bin/sleep被调用时使用了第二个参数的空字符串。argv_for_shell在fork之前是什么样子的? -
@dbush 抱歉,我忘了包含我的命令输入,我没有遗漏数字
-
如果我运行
/bin/sleep "",我会得到/bin/sleep: invalid time interval "" -
@dbush 我正在运行 /bin/sleep 1&
-
也许你认为你是,但这不是错误消息所说的。使用 gdb 在
fork之前打印argv_for_shell以进行验证。
标签: c shell background exec sleep