【发布时间】:2018-07-24 22:05:39
【问题描述】:
我在我们的一项 iOS 应用测试中遇到了问题。非常感谢任何帮助解决问题!
测试代码:
func testOpenExternalBrowser_for_valid_urls() {
// Given
let vc = MockDashboardViewController()
vc.openInternalBrowserCalled = false
vc.openExternalBrowserCalled = false
vc.webview = WKWebView()
vc.webview.navigationDelegate = vc
// When
let url = URL.init(string: "https://example.com/restOfUrl")
XCTAssertTrue(url!.absoluteString.contains("https://example.com"), "initial url string is wrong")
vc.webview.load(URLRequest(url: url!));
waitSeconds(duration: 2)
// Then
XCTAssertFalse(vc.openExternalBrowserCalled, "openExternalBrowserCalled value is wrong")
XCTAssertTrue(vc.openInternalBrowserCalled, "openInternalBrowserCalled value is wrong")
}
这给了我错误:
错误:-[Tests.ViewControllerTests testOpenExternalBrowser_for_valid_urls]:失败:被捕获 "NSInternalInconsistencyException", "完成处理程序传递给 -[ViewController webView:decidePolicyForNavigationAction:decisionHandler:] 不是 叫”
这是相关的 WKWebKit ViewController 代码:
// MARK: WKNavigationDelegate methods
func webView(_ webView: WKWebView, decidePolicyFor navigationAction: WKNavigationAction, decisionHandler: @escaping (WKNavigationActionPolicy) -> Void) {
guard let url = navigationAction.request.url, let urlScheme = url.scheme, let urlHost = url.host else {
//if we can't convert the URL, deny the action
decisionHandler(WKNavigationActionPolicy.cancel);
return;
}
var isPortValid = false;
if let urlPort = url.port {
isPortValid = urlPort == HostDefinitions.PORT;
} else {
isPortValid = urlScheme == DashboardConstants.HTTPS;
}
if(isPortValid && urlScheme == HostDefinitions.SCHEME && urlHost.compare(HostDefinitions.HOST) == ComparisonResult.orderedSame) {
openInternalBrowser(url: url, decisionHandler: decisionHandler)
return;
}
decisionHandler(WKNavigationActionPolicy.cancel);
openExternalBrowser(url: url)
}
func openInternalBrowser(url: URL, decisionHandler:@escaping (WKNavigationActionPolicy) -> Void) {
if(url.path == PathDefinitions.Login) {
//the user has logged out or visited the login page. We will now de-auth them and direct them back to the login page
OperationQueue.main.addOperation {
AuthManager.logout()
_ = self.navigationController?.popToRootViewController(animated: true);
}
decisionHandler(WKNavigationActionPolicy.cancel);
} else {
decisionHandler(WKNavigationActionPolicy.allow);
}
}
func openExternalBrowser(url: URL) {
AppManager.openExternalBrowser(url: url)
}
有什么想法吗?我尝试添加一个 return 语句并将决策处理程序添加到函数 openExternalBrowser 但都不起作用。应用程序正常运行(在 Safari 中打开外部 URL)但测试失败。
谢谢!
编辑: 这是 MockDashboardViewController 代码:
class MockDashboardViewController: DashboardViewController {
var openInternalBrowserCalled = false
var openExternalBrowserCalled = false
var presentNotificationCalled = false
var webviewURLString = ""
override func openInternalBrowser(url: URL, decisionHandler:@escaping (WKNavigationActionPolicy) -> Void) {
openInternalBrowserCalled = true
}
override func openExternalBrowser(url: URL) {
openExternalBrowserCalled = true
}
override func presentNotification(notification: DashboardNotification, showAlertView: Bool) {
presentNotificationCalled = true
}
}
【问题讨论】:
-
"这是相关的 WKWebKit ViewController 代码" 但它是相关的 MockDashboardViewController 代码吗? — 另外,
waitSeconds是错误的。有一种方法可以测试异步的东西,但不是这样。确实,有人可能会争辩说您可能正在测试错误的东西。您应该嘲笑您的decidePolicyFor,而不是在真实情况下使用真实的网络视图对其进行测试;我们已经知道 web 视图可以工作,所以测试它是没有意义的。 -
嗨@Matt;感谢您的回复!我添加了 MockDashboardViewController 代码。我只需要调用 decisionHandler(WKNavigationActionPolicy.allow);而不是在模拟控制器中?
-
是的,或致电
super。请参阅我的答案中的完整说明。