【发布时间】:2018-07-27 13:38:44
【问题描述】:
我们的系统中有 GUID 作为标识符。因为很容易搞砸并将一个实体的 id 传递给一个期望另一个实体 id 的方法(假设您错误地将 OrderId 传递给 InvoiceId,因为它都是Guids),我们为 Guids 创建了自己的类型,所以编译器可以很容易地告诉我“嘿,不要在这里传递 OrderId,我需要一个 InvoiceId”。
所以基本上,我们有很多围绕 Guid 的包装器。这些包装器运行良好,它们基本上是 Guid 接口的副本,将所有工作委托给其内部存储的 Guid。
我无法弄清楚的一件事是,我们的两个自定义标识符上的 Assert.AreEqual(a, b) 会失败。它调用object.Equals(a, b),然后调用a == b,它不会调用我的operator ==,而是调用别的东西并返回false。但它不适用于Guid,我无法弄清楚我错过了什么。
如果我的自定义类型已经在operator == 上运行,我需要实现什么才能真正工作并在object.Equals(a, b) 上返回true?
namespace ConsoleApp13
{
using System;
using System.Runtime.InteropServices;
//// Same signature, interfaces and and attributes as
//// https://referencesource.microsoft.com/#mscorlib/system/guid.cs
[StructLayout(LayoutKind.Sequential)]
[Serializable]
[ComVisible(true)]
// not accessible for me: [System.Runtime.Versioning.NonVersionable]
public struct CustomId : IFormattable, IComparable, IComparable<CustomId>, IEquatable<CustomId>
{
public static readonly CustomId Empty = new CustomId();
private readonly Guid internalGuid;
private CustomId(Guid guid)
{
this.internalGuid = guid;
}
public static bool operator ==(CustomId a, CustomId b)
{
return a.internalGuid == b.internalGuid;
}
public static bool operator !=(CustomId a, CustomId b)
{
return !(a.internalGuid == b.internalGuid);
}
public static CustomId NewGuid()
{
return new CustomId(Guid.NewGuid());
}
public static implicit operator Guid(CustomId value)
{
return value.internalGuid;
}
public static explicit operator CustomId(Guid value)
{
return new CustomId(value);
}
public override string ToString()
{
return "[" + this.GetType().Name + ":" + this.internalGuid.ToString("D") + "]";
}
public override int GetHashCode()
{
return this.internalGuid.GetHashCode();
}
public override bool Equals(object obj)
{
return this.internalGuid.Equals(obj);
}
public bool Equals(CustomId other)
{
return this.internalGuid.Equals(other.internalGuid);
}
public int CompareTo(object obj)
{
return this.internalGuid.CompareTo(obj);
}
public int CompareTo(CustomId other)
{
return this.internalGuid.CompareTo(other.internalGuid);
}
public string ToString(string format, IFormatProvider formatProvider)
{
return this.internalGuid.ToString(format, formatProvider);
}
}
internal static class Program
{
internal static void Main()
{
{
var a = CustomId.NewGuid();
var b = a;
// shows true false
Console.WriteLine("{0} {1}", a == b, object.Equals(a, b));
}
{
var a = Guid.NewGuid();
var b = a;
// shows true true
Console.WriteLine("{0} {1}", a == b, object.Equals(a, b));
}
Console.WriteLine(@"Done.");
Console.ReadLine();
}
}
}
【问题讨论】:
-
是的,我会忽略该评论 - 这是结构的完美场景;尽管如果您使用的是最新的 C# 版本,我会很想将其声明为
readonly struct。几乎所有的结构都应该是readonly struct。
标签: c# guid equality custom-type