【问题标题】:Issue with Game of Life生命游戏的问题
【发布时间】:2011-11-20 03:53:28
【问题描述】:

作为我自己的个人项目,我正在开发 Conway 的人生游戏的 Java 实现。到目前为止,它有效,但规则出现了错误。预期的模式没有出现应有的情况。我的代码有问题吗?

import javax.swing.*;
import java.awt.*;
import java.awt.event.*;

public class Cell extends JComponent implements MouseListener {

  private int row, col;
  private boolean isLiving;

  public Cell(int r, int c) {
    this.row = r;
    this.col = c;
    this.addMouseListener(this);
  }

  public void isAlive(int neighbors) {
    if (this.isLiving) {
      if (neighbors < 2) {
        this.isLiving = false;
      } else if (neighbors == 2 || neighbors == 3) {
        this.isLiving = true;
      } else if (neighbors > 3) {
        this.isLiving = false;
      }
    } else {
      if (neighbors == 3) {
        this.isLiving = true;
      }
    }
  }

  public boolean isLiving() {
    return this.isLiving;
  }

  public void paintComponent(Graphics g) {
    if (this.isLiving) {
      g.fillRect(0, 0, 10, 10);
    } else {
      g.drawRect(0, 0, 10, 10);
    }
  }

  public void mouseClicked(MouseEvent e) {
    this.isLiving = !this.isLiving;
  }

  public void mouseEntered(MouseEvent e) {
  }

  public void mouseExited(MouseEvent e) {
  }

  public void mousePressed(MouseEvent e) {
  }

  public void mouseReleased(MouseEvent e) {
  }
}

【问题讨论】:

  • 代码审查只针对工作代码。一旦您的代码用于样式/性能建议,请随时将您的代码带回代码审查。
  • 如果你说如何他们是错误的,并且包括你用来计算一个单元格的邻居的代码会更容易。还需要知道您是在环绕还是在无尽的世界中。
  • "Issue with Game of Life" 如果你不把生活看成一场游戏...?
  • 请提供一个sscce,表明您描述的问题。
  • “有人知道我是否正确地实现了它们吗?” 显然没有,但只有 SSCCE 才能确定。

标签: java swing conways-game-of-life


【解决方案1】:

怀疑1您的代码的问题是,一旦检查了邻居,它就会将单元格设置为活的或死的。这导致我早期的代码变体失败。必须将状态更改延迟到检查整个网格(生物圈)。

这个例子展示了典型的生命游戏行为。

  1. 请注意,“怀疑无法回答”,因此最好发布 SSCCE。

import java.awt.*;
import java.awt.event.*;
import javax.swing.*;
import java.util.Random;

public class GameOfLife extends JPanel {

    private final int row, col;
    private boolean isLiving;

    public static Random random = new Random();

    public GameOfLife(int r, int c) {
        this.row = r;
        this.col = c;
        MouseListener listener = new MouseAdapter() {
            @Override
            public void mouseClicked(MouseEvent e) {
                isLiving = !isLiving;
                repaint();
            }
        };
        this.addMouseListener(listener);
        isLiving = random.nextBoolean();
    }

    public boolean isAlive(int neighbors) {
        boolean alive = false;
        if (this.isLiving) {
            if (neighbors < 2) {
                alive = false;
            } else if (neighbors == 2 || neighbors == 3) {
                alive = true;
            } else if (neighbors > 3) {
                alive = false;
            }
        } else {
            if (neighbors == 3) {
                alive = true;
            }
        }
        return alive;
    }

    public void setAlive(boolean alive) {
        isLiving = alive;
    }

    public boolean isLiving() {
        return this.isLiving;
    }

    @Override
    public void paintComponent(Graphics g) {
        super.paintComponent(g);
        if (this.isLiving) {
            g.fillRect(0, 0, getWidth() - 1, getHeight() - 1);
        } else {
            g.drawRect(0, 0, getWidth() - 1, getHeight() - 1);
        }
    }

    public static void main(String[] args) {
        final int s = 40;
        final GameOfLife[][] biosphere = new GameOfLife[s][s];
        final JPanel gui = new JPanel(new GridLayout(s, s, 2, 2));
        for (int ii = 0; ii < s; ii++) {
            for (int jj = 0; jj < s; jj++) {
                GameOfLife cell = new GameOfLife(ii, jj);
                cell.setPreferredSize(new Dimension(10, 10));
                gui.add(cell);
                biosphere[ii][jj] = cell;
            }
        }

        ActionListener al = (ActionEvent ae) -> {
            boolean[][] living = new boolean[s][s];
            for (int ii = 0; ii < s; ii++) {
                for (int jj = 0; jj < s; jj++) {
                    int top = (jj > 0 ? jj - 1 : s - 1);
                    int btm = (jj < s - 1 ? jj + 1 : 0);
                    int lft = (ii > 0 ? ii - 1 : s - 1);
                    int rgt = (ii < s - 1 ? ii + 1 : 0);
                    int neighbors = 0;
                    if (biosphere[ii][top].isLiving()) {
                        neighbors++;
                    }
                    if (biosphere[ii][btm].isLiving()) {
                        neighbors++;
                    }
                    if (biosphere[lft][top].isLiving()) {
                        neighbors++;
                    }
                    if (biosphere[lft][btm].isLiving()) {
                        neighbors++;
                    }
                    if (biosphere[lft][jj].isLiving()) {
                        neighbors++;
                    }
                    if (biosphere[rgt][jj].isLiving()) {
                        neighbors++;
                    }
                    if (biosphere[rgt][top].isLiving()) {
                        neighbors++;
                    }
                    if (biosphere[rgt][btm].isLiving()) {
                        neighbors++;
                    }
                    living[ii][jj] = biosphere[ii][jj].isAlive(neighbors);
                }
            }
            for (int ii = 0; ii < s; ii++) {
                for (int jj = 0; jj < s; jj++) {
                    biosphere[ii][jj].setAlive(living[ii][jj]);
                }
            }
            gui.repaint();
        };

        Timer timer = new Timer(50, al);
        timer.start();

        JOptionPane.showMessageDialog(null, gui);
        timer.stop();
    }
}

【讨论】:

    猜你喜欢
    • 2017-03-15
    • 1970-01-01
    • 1970-01-01
    • 1970-01-01
    • 1970-01-01
    • 1970-01-01
    • 2013-02-15
    • 2010-12-01
    • 1970-01-01
    相关资源
    最近更新 更多