生成删除查询

Question

我正在尝试编写一个查询，它会根据要求自动生成删除查询。我会从不同的表中删除数据并转储到临时表中，然后使用这个临时表我需要使用 IN 运算符编写查询，请建议我，这是我尝试过的。

SET NOCOUNT ON

DECLARE @DeleteDisbursement TABLE (DisbursementId BIGINT, PolicyNumber NVARCHAR(10),DisbursementAmount DECIMAL(19,4))
DECLARE @DeleteRecords Table(DisbursementId BIGINT,ActivityId BIGINT)
INSERT INTO @DeleteDisbursement (DisbursementId,PolicyNumber,DisbursementAmount) 
VALUES 
(4576,'12345',3.00),
(1232,'65455',143.44),
(2341,'34234',228.95),
(1111,'23155',414.89)

SELECT * from @DeleteDisbursement

DECLARE @GenerateScriptCount BIGINT =0
DECLARE @DisbursementIDValue BIGINT =0
DECLARE @ActivityIdValue BIGINT =0

WHILE EXISTS(SELECT Top 1 1 FROM @DeleteDisbursement)
BEGIN
   DECLARE @DisbursementId BIGINT =0
   DECLARE @PolicyNumber NVARCHAR(10)
   DECLARE @AccountId BIGINT =0
   DECLARE @ActivityId BIGINT
   DECLARE @DisbursementAmount DECIMAL(19,4)

SELECT TOP 1 @DisbursementId =DisbursementId ,@PolicyNumber = PolicyNumber,@DisbursementAmount = DisbursementAmount
  FROM @DeleteDisbursement

SET @ActivityId = (SELECT ActivityId FROM ActivityLog WHERE ActivityAmount = @DisbursementAmount)  
  
  IF (@ActivityId > 0)
    BEGIN
      
     INSERT INTO @DeleteRecords (DisbursementId,ActivityId) VALUES(@DisbursementId,@ActivityId)
    
    END
  DELETE FROM @DeleteDisbursement WHERE DisbursementId = @DisbursementId

END
    
    WHILE EXISTS(SELECT Top 1 1 FROM @DeleteRecords)
    BEGIN

        SELECT TOP 1 @DisbursementIDValue= @DisbursementId,@ActivityIdValue = @ActivityId FROM @DeleteRecords 

         PRINT 'DELETE FROM Disbursement Where DisbursementId IN (' + CONVERT(NVARCHAR(MAX), @DisbursementIDValue) +')' 

         PRINT 'DELETE FROM ActivityLog WHERE ActivityId IN (' + CONVERT(NVARCHAR(MAX), @ActivityIdValue) +')'  

        DELETE FROM @DeleteRecords WHERE DisbursementId = @DisbursementId

    END

SET NOCOUNT OFF;

但它不起作用，请帮助我如何编写查询仅包含在 IN 运算符中的 1 个查询，如下所示：-

DELETE FROM Disbursement Where DisbursementId IN (4576,1232,2341,1111)
DELETE FROM ActivityLog WHERE ActivityId IN (1000,2000,3000,4000)

Answer 1

我知道这不是在回答您的直接问题，但我很确定它会更快并避免您的任何问题。毫无疑问，您必须进行调整以匹配您的实际版本，但这应该会给出想法。

begin transaction

delete Disbursement
from DeleteDisbursement dd
join Disbursement on Disbursement.DisbursementId=dd.DisbursementId

delete ActivityLog
from DeleteDisbursement dd
join ActivityLog on ActivityLog.ActivityAmount=dd.DisbursementAmount

commit work

Answer 2

您不需要这么复杂。您首先将值存储在临时表中，然后将临时表重用于您的删除语句。或者您可以使用 STRING_AGG 函数生成 id 列表（从 SQL 2017 开始支持）。

DECLARE @sqlStmt NVARCHAR(MAX) = '
CREATE TABLE #DeleteDisbursement (DisbursementId BIGINT, PolicyNumber NVARCHAR(10),DisbursementAmount DECIMAL(19,4))
CREATE TABLE #DeleteRecords (DisbursementId BIGINT,ActivityId BIGINT)


INSERT INTO #DeleteDisbursement (DisbursementId,PolicyNumber,DisbursementAmount) 
VALUES 
(4576,'12345',3.00),
(1232,'65455',143.44),
(2341,'34234',228.95),
(1111,'23155',414.89)

INSERT INTO #DeleteRecords (DisbursementId,ActivityId) 
SELECT DisbursementId , ActivityId FROM ActivityLog AS al
INNER JOIN #DeleteDisbursement  AS dd
ON dd.DisbursementAmount =  al.ActivityAmount
'

• 方法 1（使用 Temp 表作为 Id 列表）

SET @sqlStmt  += '

DELETE FROM Disbursement Where DisbursementId IN (SELECT 
DisbursementId FROM #DeleteRecords)
DELETE FROM ActivityLog WHERE ActivityId IN (SELECT 
ActivityId FROM #DeleteRecords)'

PRINT @sqlStmt  

• 方法 2（使用 STRING_AGG 生成 Id 列表）

SET @sqlStmt  += '

DELETE FROM Disbursement Where DisbursementId IN (' + SELECT STRING_AGG(DisbursementId ,',') FROM #DeleteRecords + ');'+ CHAR(13) + CHAR(10) + 'GO' + CHAR(13) + CHAR(10) + 
'DELETE FROM ActivityLog WHERE ActivityId IN (' + SELECT 
STRING_AGG(ActivityId ,',')  FROM #DeleteRecords+ ');'+ CHAR(13) + CHAR(10) + 'GO' 

PRINT @sqlstmt