为每个打开的工作簿执行功能

Question

我正在创建一个带有命令按钮的空白工作簿，单击该按钮后，我希望它对当前打开的每个打开的工作簿执行操作（因为我将拥有其他非空白的工作簿，我希望它对其执行操作)。

运行时出现下标超出范围错误：

Sub Button1_Click()
'
' Button1_Click Macro
' Fire Ext. Comments
'
'
Dim w As Workbook

' For every open workbook...
For Each w In Application.Workbooks

    ' Activate the current workbook
    w.Activate

    ' Find the comments column (K12 should be the "Comments" column)
    If Worksheets("FIRE EXT.").Range("K12").Value = "Comments" Then

        ' Then we loop through all cells in the specified range (anything below the header row)
        Dim rng As Range, cell As Range

        ' I'm using a range of 500 to look for values, so if a file has more than 500 rows, you'll have to look at it manually
        Set rng = Range("A1:A500")

        ' No loop to change all comments
        For Each cell In rng
.......................

...在“If Worksheets("FIRE EXT.").Range("K12").Value = "Comments" Then" 行。所以我认为它是从空白工作簿开始而不是找到名为“FIRE EXT.”的工作表，所以首先测试激活的工作簿是否首先具有该工作表名称的最佳实践是什么，否则继续下一个工作簿?谢谢！

更新

这对我有用，但其他响应也可以。谢谢大家！

Sub Button1_Click()
'
' Button1_Click Macro
' Fire Ext. Comments
'
'
Dim w As Workbook

' For every open workbook...
For Each w In Application.Workbooks

    ' Don't work on the current/blank workbook
    If w.FullName <> ThisWorkbook.FullName Then

    ' Find the comments column (K12 should be the "Comments" column)
    If w.Sheets("FIRE EXT.").Range("K12").Value = "Comments" Then

        ' Then we loop through all cells in the specified range (anything below the header row)
        Dim rng As Range, cell As Range

        ' I'm using a range of 500 to look for values, so if a file has more than 500 rows, you'll have to look at it manually
        Set rng = w.Worksheets("FIRE EXT.").Range("A13:A500")

        ' No loop to change all comments
        For Each cell In rng

Answer 1

您需要完全限定您的所有参考资料。您还可以进行检查以确保它跳过空白工作簿（请参阅此更新代码中的我的 cmets）：

Sub Button1_Click()
'
' Button1_Click Macro
' Fire Ext. Comments
'
'
Dim w As Workbook

' For every open workbook...
For Each w In Application.Workbooks

    If w.FullName <> ThisWorkbook.FullName Then     '<-- TA: Add check to verify you're not working on the blank workbook

        'TA: I removed the .Activate line, that is never necessary.  Instead, fully qualify all your references

        ' Find the comments column (K12 should be the "Comments" column)
        If w.Worksheets("FIRE EXT.").Range("K12").Value = "Comments" Then   '<-- TA: Note that Worksheets is now qualified to w so that it is checking worksheets in the current w workbook

            ' Then we loop through all cells in the specified range (anything below the header row)
            Dim rng As Range, cell As Range

            ' I'm using a range of 500 to look for values, so if a file has more than 500 rows, you'll have to look at it manually
            Set rng = w.Worksheets("FIRE EXT.").Range("A1:A500")    '<-- TA: Note that Range is now qualified to w.Worksheets("FIRE EXT.") (if that isn't the correct sheet name, change this to the correct sheet name)

            ' Now loop to change all comments
            For Each cell In rng
.......................

Answer 2

我想输入一条评论，但是太长了。

1. 如果工作表名称为“FIRE EXT”，您将收到错误消息。 （带句点）在您正在使用的工作簿上不存在。您正在循环所有工作簿，如果您有一个没有该工作表的工作簿，则会出错。
2. 最好在使用工作表名称时使用Sheets，在使用工作表编号时最好使用Worksheets。 Sheets("SheetName") 与 Worksheets(1)

3. 通过在代码中使用分配的工作簿变量来避免使用激活/选择，即“w”

   Sub Button1_Click()
   Dim w As Workbook
   
   ' For every open workbook...
   For Each w In Application.Workbooks
   
       ' Find the comments column (K12 should be the "Comments" column)
       If w.Sheets("FIRE EXT.").Range("K12").Value = "Comments" Then
   
           ' Then we loop through all cells in the specified range (anything below the header row)
           Dim rng As Range, cell As Range
   
           ' I'm using a range of 500 to look for values, so if a file has more than 500 rows, you'll have to look at it manually
           Set rng = w.Sheets("FIRE EXT.").Range("A1:A500")
   
           ' Now loop to change all comments
           For Each cell In rng
           ' Now here you dont use "w.Sheets("FIRE EXT.")" because it is already set on `rng'
           ' so you can just use `cell` like cell.value = "Blah"
   .........