【发布时间】:2016-12-20 13:38:29
【问题描述】:
以下代码用于将 HotelReportModel 数据写入 csv 文件。我打算用 try-with-resources 语句替换 try 但我应该如何处理 filewriteter.flush?在 finally 块内。
FileWriter fileWriter = null;
try {
fileWriter = new FileWriter(tempCSVFilePath);
fileWriter.append(hotelReportModel.getHeader());
fileWriter.append(NEW_LINE_SEPARATOR);
for(HotelReportModel imageStat:hotelReportModel.getContent()){
fileWriter.append(imageStat.getMarketerName());
fileWriter.append(COMMA_DELIMITER);
fileWriter.append(imageStat.getChainCode());
fileWriter.append(COMMA_DELIMITER);
fileWriter.append(imageStat.getPropertyId());
fileWriter.append(COMMA_DELIMITER);
fileWriter.append(imageStat.getContentProvider());
fileWriter.append(COMMA_DELIMITER);
fileWriter.append(String.valueOf(imageStat.getPropertyImageCount()));
fileWriter.append(NEW_LINE_SEPARATOR);
}
LOGGER.info("CSV file was created successfully !!!");
} catch (Exception e) {
LOGGER.error("Error in CsvFileWriter !!!",e);
} finally {
try {
if(fileWriter != null) {
fileWriter.flush();
fileWriter.close();
}
} catch (IOException e) {
LOGGER.error("Error while flushing/closing fileWriter !!!",e);
}
}
下面用资源试试对吗?
try(FileWriter fileWriter = = new FileWriter(tempCSVFilePath) ) {
fileWriter.append(hotelReportModel.getHeader());
fileWriter.append(NEW_LINE_SEPARATOR);
for(HotelReportModel imageStat:hotelReportModel.getContent()){
fileWriter.append(imageStat.getMarketerName());
fileWriter.append(COMMA_DELIMITER);
fileWriter.append(imageStat.getChainCode());
fileWriter.append(COMMA_DELIMITER);
fileWriter.append(imageStat.getPropertyId());
fileWriter.append(COMMA_DELIMITER);
fileWriter.append(imageStat.getContentProvider());
fileWriter.append(COMMA_DELIMITER);
fileWriter.append(String.valueOf(imageStat.getPropertyImageCount()));
fileWriter.append(NEW_LINE_SEPARATOR);
}
LOGGER.info("CSV file was created successfully !!!");
} catch (Exception e) {
LOGGER.error("Error in CsvFileWriter !!!",e);
}
}
【问题讨论】:
-
close无论如何都会调用flush,所以你不需要。 -
乔恩你的意思是说我可以删除完整的 finally 块吗?
-
如果你使用 try-with-resources,是的。
标签: java collections try-catch file-handling