试图将类作为参数传递给不同的类构造函数，但出现“转换”错误

Question

所以我试图将一个类作为参数传递给另一个类（在不同的标头中）并不断收到我似乎无法调试的错误。

错误：

'wanderingSoul::wanderingSoul(wanderingSoul &&)': 无法将参数 1 从 'player' 转换为 'const warningSoul &'

主要问题在于 game.cpp 文件，在“//Battle Test”下面，我称之为“wanderingSoul wonderS(main)”。

'player'是一个类，流浪的灵魂也是一个类，我不明白的是如何正确传递/引用玩家类，因为它在传递给函数时效果很好，但不适用于这个类构造函数。

• game.cpp

#include <iostream>
#include <string>
#include <ctime>
#include <cstdlib>
#include "player.h"
#include "npc.h"
#include "enemy.h"
#include "map.h"
#include "items.h"
#include "dialog.h"

/* To Do List
 * Multiple chars per battle if in party.
 * Add inventory & powers
 * Add battles
 * Finish "story" & dialogues
 * Make map
 * Add dialog trees (instead of if/else & switch/case)
 * Add relation between characters using weighted graph
 */

void battle(player plyr, enemy nme)
{
  std::cout << "You have entered a battle with " << nme.name << std::endl;
  while (!plyr.dead() && !nme.dead())
  {

  }
}

int roll()
{
  return rand() % 12 + 1;
}

int main()
{
  srand(time(NULL));
  std::string playerName;
  char optionChoice;
  int dialogChoice;
  npc Lexa("Lexa", 80, 80);

BEGIN_GAME:
  system("cls");
  std::cout << Lexa.nameText() << "Hey... Hey, are you awake now?" << std::endl;
  std::cout
      << Lexa.nameText() 
      << "I was starting to get worried. You've been out for quite some time. Do you remember your name?" 
      << std::endl;
INSERT_NAME:
  std::cout << "(Name): ";
  std::cin >> playerName;
  std::cout << Lexa.nameText() << "Huh. " << playerName << ". Is that right? (y/n)" << std::endl;
  std::cin >> optionChoice;
  if (optionChoice != 'y' && optionChoice != 'Y')
  {
      //system("cls");
      std::cout << Lexa.nameText() << "Please try to remember, I need to make sure you're stable. " << std::endl;
      goto INSERT_NAME;
  }

  player main(playerName);

INTRODUCTION:
  system("cls");
  //Print location
  initInfo(main, Lexa);

  //BATTLE TEST
  wanderingSoul wanderS(main);
  battle(main, wanderS.ws);

  //TRAVEL TEST

  system("pause");
  return 0;
}

• enemy.h

#pragma once
#include <vector>
#include "powers.h"
#include "items.h"
#include "player.h"
//Need to include map?

class enemy
{
private:
  /**Stat Properties*********
  * Health: 0->100
  *     0 = Death/GameOver
  * Level: 1->100
  * Attack: 1->10
  * Defense: 1->10
  * Mana: 0->100
  * Affiliation: -100->100
  **************************/

  /*
  * Add inventory
  *      -list of pointers to inventory items
  * Add powers
  *      -list of pointers to powers
  */
  class currPowers //Keeps track of current powers have
  {
  private:

  public:

  };
public:
  unsigned int health, level, attackPWR, defensePWR, mana;
  int affiliation;
  std::string name;
  enemy()
  {
      health = 100;
      level = 1;
      attackPWR = 1;
      defensePWR = 1;
      mana = 100;
      affiliation = 0;
  }
  enemy(std::string t_name)
  {
      name = t_name;
      health = 100;
      level = 1;
      attackPWR = 1;
      defensePWR = 1;
      mana = 100;
      affiliation = 0;
  }
  /*
  void attack(player plyr, power pwr)
  {

  }
  */
  void defend()
  {

  }
  bool dead()
  {
      if (health == 0 || level == 0)
      {
          if (level == 0)
          {
              std::cout << name << " had a heart attack." << std::endl;
          }
          else
          {
              std::cout << name << " has been defeated. Hoorah!" << std::endl;
          }
          return true;
      }
      return false;
  }
  std::string nameText()
  {
      return name + ": ";
  }
};
/* ENEMY LIST
 *        STD/COMMON
 * Wandering Soul
 * Red Royal Soldier
 * Wolf (Pack)
 * B.A.R
 * Disciples
 *        UNCOMMON
 * Tech Soldier
 * Banished Mage
 * Tech Hound
 * Dark Mage
 *        RARE
 * Cyber Cyclops
 * Hellhound
 * Elite Androids
 * Follower of The Void
 * Banshee
 *        BOSS
 * Mantis
 * Mary S.
 * The Summoner
 * NOX-322
 * The Void
 */

class wanderingSoul
{
public:
  /*
  Name: Wandering Soul
  Health: 75/100
  Level: |player level| - 1, level > 0.
  Attack:
  Defense:
  Mana:
  Affiliation:
  Powers:
  */
  enemy ws;
  int diceRoll;
  wanderingSoul(player plyr)
  {
      ws.name = "Wandering Soul";
      diceRoll = roll(); //Rolling for health
      if (diceRoll == 0)
      {
          ws.health = 50;
      }
      else  if (diceRoll > 6)
      {
          ws.health = 100;
      }
      else
      {
          ws.level = 75;
      }
      diceRoll = roll(); //Rolling for level
      if (diceRoll == 0)
      {
          ws.level = plyr.level - 1;
      }
      else  if (diceRoll > 6)
      {
          ws.level = plyr.level + 1;
      }
      else
      {
          ws.level = plyr.level;
      }
  }
};

• 播放器.h

#pragma once
#include <vector>
#include "powers.h"
#include "items.h"
#include "enemy.h"
//Need to include map?

class player
{
private:
  /**Stat Properties*********
  * Health: 0->100
  *     0 = Death/GameOver
  * Level: 1->100
  * Attack: 1->10
  * Defense: 1->10
  * Mana: 0->100
  * Affiliation: -100->100
  **************************/
  //Setting everything outside private for now due to needing to access variables in other classes.
  /*
  * Add inventory
  *      -list of pointers to inventory items
  * Add powers
  *      -list of pointers to powers
  */
  class currPowers //Keeps track of current powers have
  {
  private:

  public:

  };
public:
  unsigned int health, level, attackPWR, defensePWR, mana;
  int affiliation;
  std::string name;
  player(std::string t_name)
  {
      name = t_name;
      health = 100;
      level = 1;
      attackPWR = 1;
      defensePWR = 1;
      mana = 100;
      affiliation = 0;
  }

  void incAffiliation(bool x)
  {
      if (x == true)
      {
          affiliation += 5;
      }
      else
      {
          affiliation -= 5;
      }
  }

  void attack(enemy nme, power pwr)
  {

  }

  void defend()
  {

  }

  bool dead()
  {
      if (health == 0)
      {
          std::cout << "You are dead." << std::endl;
          return true;
      }
      return false;
  }

  std::string nameText()
  {
      return name + ": ";
  }

};

对不起，如果代码不好，有很多不需要的行，我打算尽快清理它，但想看看我是否可以与主角和敌人一起战斗，虽然我不知道是什么问题.我试图将玩家（主角）类作为参数传递的原因是因为我将敌人的统计数据基于玩家的统计数据，而我不是最好的指针和解除引用的东西，所以这很可能是一个问题.. . 无论如何，对不起，呃，代码很长，但这是我第一次尝试通过 C++ 制作一个小游戏并尝试学习新事物。 （好吧，我知道类和结构，但这是我第一次使用 c++ 进行非学校/非数据结构实现工作）

更新：删除了乱七八糟的 game.cpp 部分，发现问题是“语法错误：标识符 'player'”，所以我试图看看如何解决这个问题。

Answer 1

这里的问题是您将enemy.h 包含在player.h 中，并将player.h 包含在enemy.h 中。 然后将它们都包含在您的game.cpp 中。 Circular dependency 就是这种情况。 当您尝试编译您未共享的代码时，一定会出现更多错误。

无论如何，你可以使用forward declaration来避免这个问题。

一些旁注：

由于您正在开发游戏，因此您需要了解更多关于inheritance 和composition 的信息。继承是IS-A关系的情况，另一方面组合是HAS-A的情况。

所以在这里你所做的在设计上是不正确的，Wandering Soul 是一个敌人，所以不是在wanderingSoul类内部创建一个敌人，而是从enemy类固有的.

你的敌人可以拥有多个小工具，而这些小工具可以是另一个类，所以在这里你可以看到你有一个HAS-A情况的案例，你可以从中受益作文。

另一件事是，Player 和 Enemy 在您的游戏世界中是两个独立的东西，因此将玩家传递给敌人类不是一个好主意。您需要一个游戏控制器类来控制这两个类的对象之间的交互，例如打架或说话或这两者可能做的其他事情。