【发布时间】:2015-05-09 18:47:44
【问题描述】:
对于书本练习,我需要创建一个名为 Vec 的简单 C++ 容器(模仿 std::vector 的容器)。但是,我在实现一个简单的 erase() 方法时遇到了问题。我的意图是销毁该索引中的对象,然后将索引之后的所有元素移回列表的下方。
PS:我是 C++ 新手,对 C++ 中的内存管理知之甚少。
Vec.h
#pragma once
#ifndef GUARD_VEC_H
#define GUARD_VEC_H
#define WARNING D_SCL_SECURE_NO_WARNINGS
#define WARNING_ID 4996
#pragma message (WARNING)
#pragma warning (disable: WARNING_ID)
#define MAX(a , b) ((a > b) ? a : b)
#define MIN(a , b) ((a < b) ? a : b)
#include <memory> //For: Allocator
#include <cstddef> //FOR: size_type
template<class T> class Vec {
public: //interface
typedef T* iterator;
typedef const T* const_iterator;
typedef size_t size_type;
typedef T value_type;
Vec() { create(); }
explicit Vec(size_type n, const T& val = T()) { create(n, val); }
Vec(const Vec& v) { create(v.begin(), v.end()); }
Vec& operator = (const Vec&);
~Vec() { uncreate(); }
T& operator[] (size_type i) { return data[i]; }
const T& operator[] (size_type i) const { return data[i]; }
void push_back(const T& t) {
if (avail == limit)
grow();
unchecked_append(t);
}
void clear();
bool erase(size_type i);
size_type size() const { return avail - data; }
iterator begin() { return data; }
const_iterator begin() const { return data; }
iterator end() { return avail; }
const_iterator end() const { return avail; }
private: //implementation
iterator data;
iterator avail;
iterator limit;
std::allocator<T> alloc;
void create();
void create(size_type, const T&);
void create(const_iterator, const_iterator);
void uncreate();
void grow();
void unchecked_append(const T&);
};
template <class T> bool Vec<T>::erase(size_type i){
//No, doesn't work at all
if (i > size())
return false;
alloc.destroy(data+ i);
return true;
//Implement move-back
}
template <class T> void Vec<T>::clear(){
uncreate(); //Destroys all objects and deallocates all addresses
grow(); //Allocates addresses for next use.
}
template <class T> void Vec<T>::create()
{
data = avail = limit = 0;
}
template <class T> void Vec<T>::create(size_type n, const T& val)
{
data = alloc.allocate(n);
limit = avail = data + n;
std::uninitialized_fill(data, limit, val);
}
template <class T>
void Vec<T>::create(const_iterator i, const_iterator j){
data = alloc.allocate(j - i);
limit = avail = std::uninitialized_copy(i, j, data);
}
template <class T> void Vec<T>::uncreate()
{
if (data){
iterator it = avail;
while (it != data)
alloc.destroy(--it);
alloc.deallocate(data, limit - data);
}
data = limit = avail = 0;
}
template <class T> void Vec<T>::grow()
{
size_type new_size = MAX(2 * (limit - data), ptrdiff_t(1));
iterator new_data = alloc.allocate(new_size);
iterator new_avail = std::uninitialized_copy(data, avail, new_data);
uncreate();
data = new_data;
avail = new_avail;
limit = data + new_size;
}
template <class T> void Vec<T>::unchecked_append(const T& val)
{
alloc.construct(avail++, val);
}
template <class T> Vec<T>& Vec<T>::operator=(const Vec<T>& rhs)
{ //rhs = right hand side
if (&rhs != this){
uncreate();
create(rhs.begin(), rhs.end());
}
return *this;
}
#endif
main.cpp
#include "Vec.h"
#include <iostream>
#include "Windows.h"
#include <string>
int main(){
Vec<double> vector;
for (int i = 0; i < 10; i++){
vector.push_back((double) i);
}
//Check Copy Constructor
Vec<double> vector2 = vector;
Vec<double> vector3;
Vec<double> vector4;
for (int i = 0; i < 10; i++){
vector3.push_back((double)(i*2));
}
//Check Assignment Operator
vector4 = vector3;
for (int i = 0; i < 10; i++){
std::cout << vector[i] << " " << vector2[i] << " " << " " << vector3[i] << " "
<< vector4[i] << std::endl;
}
//Check Erase Operator
vector.erase(3);
for (int i = 0; i < vector.size(); i++){
std::cout << vector[i] << std::endl;
}
std::system("PAUSE");
return 0;
}
主要,“矢量”是我正在测试的对象。它被初始化为数字 0 到 9,并且在调用 vector.erase(3) 后保持不变;
另外,关于迭代器的解释,data 指向列表的开头(第一个元素),avail 指向初始化元素的结束位置,limit 指向未初始化存储结束的位置。数据
【问题讨论】:
-
附带问题:
MAX不需要宏。使用std::max或自己编写一个模板函数,但避免使用宏。 -
编译器错误?意外行为?介意explain more?
-
没有错误,只有矢量是“不变的”
-
仅仅因为你破坏了对象并不意味着它从向量中消失了。同样的原因你仍然可以在
SomeClass c; c.~SomeClass();之后访问c(但不要那样做)。