【发布时间】:2018-03-19 13:44:54
【问题描述】:
我刚刚开始学习套接字编程。
目前服务器和客户端在同一个工作站上,一切似乎都正常。服务器在 c 编程中运行,我的客户端是一个 android 程序。 我设法建立了单向连接,将数据从客户端发送到服务器。我想将一些字符串发回给客户。
请给我建议。
void *connection_handler(void *);
int main(int argc , char *argv[])
{
int socket_desc , client_sock , c;
struct sockaddr_in server , client;
//Create socket
socket_desc = socket(AF_INET , SOCK_STREAM , 0);
if (socket_desc == -1)
{
printf("Could not create socket");
}
puts("Socket created");
//Prepare the sockaddr_in structure
server.sin_family = AF_INET;
server.sin_addr.s_addr = INADDR_ANY;
server.sin_port = htons( 7800 );
//Bind
if( bind(socket_desc,(struct sockaddr *)&server , sizeof(server)) < 0)
{
//print the error message
perror("bind failed. Error");
return 1;
}
puts("bind done");
//Listen
listen(socket_desc , 3);
//Accept and incoming connection
//puts("Waiting for incoming connections...");
//c = sizeof(struct sockaddr_in);
//Accept and incoming connection
puts("Waiting for incoming connections...");
c = sizeof(struct sockaddr_in);
pthread_t thread_id;
while( (client_sock = accept(socket_desc, (struct sockaddr *)&client, (socklen_t*)&c)) )
{
puts("Connection accepted");
if( pthread_create( &thread_id , NULL , connection_handler , (void*) &client_sock) < 0)
{
perror("could not create thread");
return 1;
}
//Now join the thread , so that we dont terminate before the thread
//pthread_join( thread_id , NULL);
puts("Handler assigned");
}
if (client_sock < 0)
{
perror("accept failed");
return 1;
}
return 0;
}
/*
* This will handle connection for each client
* */
void *connection_handler(void *socket_desc)
{
//Get the socket descriptor
int sock = *(int*)socket_desc;
int read_size;
char *message , client_message[2000];
//Send some messages to the client
message = "Greetings! I am your connection handler\n";
write(sock , message , strlen(message));
message = "Now type something and i shall repeat what you type \n";
write(sock , message , strlen(message));
//Receive a message from client
while( (read_size = recv(sock , client_message , 2000 , 0)) > 0 )
{
//end of string marker
client_message[read_size] = '\0';
printf("%s\n", client_message);
//Send the message back to client
write(sock , client_message , strlen(client_message));
//clear the message buffer
memset(client_message, 0, 2000);
}
if(read_size == 0)
{
//puts("Client disconnected");
//fflush(stdout);
}
else if(read_size == -1)
{
perror("recv failed");
}
return 0;
}
【问题讨论】:
-
您能更具体地说明问题是什么吗?
-
我可以在您的代码中看到一些问题和潜在问题,但只要一次只连接一个客户端,那么与客户端之间的传输就不会有任何问题。
-
@Someprogrammerdude 暗示了这一点:'(void*) &client_sock' - 想想如果多个客户端“同时”尝试连接会发生什么......
-
如果所有 2000 个字节都已接收,则:'client_message[read_size] = '\0';'会写越界。
-
@MartinJames 这就是为什么我添加了关于一次只有一个客户端连接的注释。