计算字符串C++中字符的频率

Question

我正在尝试计算字符串输入中字母的频率。我遇到了一些麻烦，我不完全知道我做错了什么。我得到了奇怪的输出，比如笑脸。如果字符串是“abcdc”，我希望我的代码做这样的事情 一 - 1 b - 1 c - 2 d - 1

      #include <iostream>
using namespace std;




class moose
{
    char inputbuffer[132];
    char countbuffer[122];
    long count;
    short index = 0;
public:
    char charcount();
    char charinput();
    char initialize();

};

int main()
{
    moose obj;
    obj.initialize();
    obj.charinput();
    obj.charcount();
    system("pause");

}


char moose::initialize()
{
    for (int i = 0; i < 122; i++)
        countbuffer[i] = 0;
    return 0;

}

char moose::charinput()
{
    cout << "Enter your text and I'll read your characters" << endl;
    cin.getline(inputbuffer, 132);
    cin.gcount();
    count = cin.gcount();
    count--;
    return 0;
}

char moose::charcount()
{
    for (int i = 0; i < count; i++)
    {
        if (inputbuffer[i] >= 'a' & inputbuffer[i] <= 'z') {
            index = inputbuffer[i];
            countbuffer[index]++;

        }
        for (i = 0; i < count; i++)
        {
            cout << inputbuffer[i] << " - " << countbuffer[index] << endl;
        }
    }




    return 0;
}

Answer 1

您的代码有几个问题：

1. moose::charinput() 方法包含对gcount() 的额外调用。您只需要这条语句：count = cin.gcount();。 count--; 也不应该在那里。

2. moose::charcount() 里面的条件必须是

   if (inputbuffer[i] >= 'a' && inputbuffer[i] <= 'z')
   

3. moose::charcount() 应该有两个不同的循环：

       char moose::charcount()
       {
           for (int i = 0; i < count; i++)
           {
               if (inputbuffer[i] >= 'a' && inputbuffer[i] <= 'z') {
                   index = inputbuffer[i];
                   countbuffer[index]++;
               }
           }
           for (i = 0; i < count; i++)
           {
               cout << inputbuffer[i] << " - " << countbuffer[inputbuffer[i]] << endl;
           }   
           return 0;
       }
   

4. countbuffer 必须声明为 int 才能正确打印