【发布时间】:2018-10-11 01:50:08
【问题描述】:
这是求职面试。我想要做的是,一旦发牌(从 Dealer's Deck 实例中移除),该牌就可供 Player's Hand 实例使用。
class Card
attr_accessor :suite, :name, :value #specifiy that class attributes are both, readable and writable
#constructor
def initialize(suite, name, value)
@suite, @name, @value = suite, name, value #this looks odd
end
end
class Deck
attr_accessor :playable_cards
SUITES = [:hearts, :diamonds, :spades, :clubs] #constant
NAME_VALUES = {
:two => 2,
:three => 3,
:four => 4,
:five => 5,
:six => 6,
:seven => 7,
:eight => 8,
:nine => 9,
:ten => 10,
:jack => 10,
:queen => 10,
:king => 10,
:ace => [11, 1]}
def initialize #initialzing shuffles the deck
shuffle
end
def deal_card #removes card from deck
random = rand(@playable_cards.size) #returns an random int greater >= 0 & < max
@playable_cards.delete_at(random)
end
def shuffle
@playable_cards = [] #array of 52 cards
SUITES.each do |suite| #iterate over suites
NAME_VALUES.each do |name, value| #iterate, over card for that suite
@playable_cards << Card.new(suite, name, value) #add to end of array, new Card
end
end
end
end
class Hand
attr_accessor :cards
def initialize
@cards = []
end
end
class Player
def initialize
@player_hand = Hand.new
end
end
class Dealer
def initialize
@dealer_hand = Hand.new
@dealer_deck = Deck.new
end
def deal
card = @dealer_deck.deal_card
end
end
require 'test/unit'
class CardTest < Test::Unit::TestCase
def setup
@card = Card.new(:hearts, :ten, 10)
end
def test_card_suite_is_correct
assert_equal @card.suite, :hearts
end
def test_card_name_is_correct
assert_equal @card.name, :ten
end
def test_card_value_is_correct
assert_equal @card.value, 10
end
end
class DeckTest < Test::Unit::TestCase
def setup
@deck = Deck.new
end
def test_new_deck_has_52_playable_cards
assert_equal @deck.playable_cards.size, 52
end
def test_dealt_card_should_not_be_included_in_playable_cards
card = @deck.deal_card
assert(!@deck.playable_cards.include?(card)) #upon dealing card, card should be removed from deck
end
def test_shuffled_deck_has_52_playable_cards
@deck.shuffle
assert_equal @deck.playable_cards.size, 52
end
end
我所做的只是添加了Player 和Dealer 类。我的想法是玩家有一手牌,因此在初始化时,手牌的一个实例存储在@player_hand 中,发牌员也是如此。庄家显然也有自己的套牌实例。现在,一旦我调用Dealer.new.deal,一张牌从牌组中移除,我如何将新移除的牌添加到Player @player_hand?
我考虑过使用全局变量,但这是不好的做法。我也不确定这是否是正确的方法。
【问题讨论】:
-
你的自动化测试在哪里?
-
已添加测试。我还被要求根据需要创建自己的测试。到目前为止所有测试都通过了。
-
很棒的测试!你被录取了。哦,除了
assert_equal @deck.playable_cards.size, 52应该是assert_equal 52, @deck.playable_cards.size,assert(!(...))应该是refute,你应该在断言上去掉多余的括号()。 -
为什么玩家和经销商需要自己的班级?他们不会是Hand的一个实例吗?然后他们会从您初始化的甲板上收到一张卡片。我假设您没有编写 shuffle 方法,因为它实际上根本没有改组,这实际上是由随机选择(deal_card)完成的。在你的基本测试之后,你需要看看你想使用什么规则,即庄家什么时候必须抓牌,什么时候必须坐下……当然还有 21 个限制