如何处理自动重复用户删除

Question

我有以下几点：

@(Import-Csv C:\Users\Administrator\Desktop\dbs\Monday.csv) +
    @(Import-Csv C:\Users\Administrator\Desktop\dbs\Tuesday.csv) +
    @(Import-Csv C:\Users\Administrator\Desktop\dbs\Wednesday.csv) +
    @(Import-Csv C:\Users\Administrator\Desktop\dbs\Thursday.csv) +
    @(Import-Csv C:\Users\Administrator\Desktop\dbs\Friday.csv) |
  sort first_name,last_name,phone1 -Unique | 
  Export-Csv C:\Users\Administrator\Desktop\dbs\joined.csv

Import-Module ActiveDirectory

#EDIT PATH SO IT POINTS TO DB FILE \/  
$newUserList = Import-Csv C:\Users\Administrator\Desktop\dbs\joined.csv

ForEach ($item in $newUserList){ 
  $fname = $($item.first_name)
  $lname = $($item.last_name)
  $phone = $($item.phone1)

  $username=$fname+$lname.substring(0,1)

  # Puts Domain name into a Placeholder.
  $domain='@csilab.local'

  # Build the User Principal Name Username with Domain added to it
  $UPN=$username+$domain

  # Create the Displayname
  $Name=$fname+" "+$lname

  $newusers1 = (New-ADUser -GivenName $fname -Surname $lname -HomePhone $phone -Name $Name -DisplayName  $Name  -SamAccountName $username -AccountPassword (ConvertTo-SecureString "1NewPassword" -asplaintext -force) -ChangePasswordAtLogon $true -UserPrincipalName $UPN -Path "ou=test,dc=csi,dc=lab" -Enabled $true -PassThru) | 

  # I need this block to check for duplicates missed by the csv sort & merge
  # as well as any in the destination OU itself as the script will run daily
  # with inevitable possibility that user is unique to the csv but not the AD.
  $newusers1 | Get-ADUser -Filter * -SearchBase "OU=Active Users,DC=csilab,DC=local" |
    Sort-Object -Unique |
    Remove-ADUser -confirm:$false 

但是我运行它并得到：

Get-ADUser : The input object cannot be bound to any parameters for the command
either because the command does not take pipeline input or the input and its
properties do not match any of the parameters that take pipeline input.
At C:\Users\Administrator\Desktop\Team2.ps1:40 char:14
+ $newusers1 | Get-ADUser -Filter * -SearchBase "OU=Active Users,DC=csilab,DC=loca ...
+              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : InvalidArgument: (CN=Bethanie Cut...csilab,dc=local:PSObject) [Get-ADUser], ParameterBindingException
    + FullyQualifiedErrorId : InputObjectNotBound,Microsoft.ActiveDirectory.Management.Commands.GetADUser

即使它确实有效，我也担心它会删除唯一用户而不是重复用户。

get-AdUser $username |  Move-ADObject -TargetPath 'OU=Active Users,dc=csilab,dc=local'  
}    

我可以做些什么来确保所有用户都在那里，而不会删除任何原始文件，而只是删除重复文件？

Answer 1

New-ADUser 语句的末尾仍有一个空管道，这会导致脚本失败并出现“不允许空管道元素”错误，但是哦，好吧...

为了避免冲突，只需检查一个帐户是否已经存在在您尝试创建它之前，并且只有在它不存在时才创建它：

$username = $fname + $lname.substring(0,1)
...
if (Get-ADUser -Filter "SamAccountName -eq '$username'") {
  Write-Host "Account $username already exists."
} else {
  New-ADUser -SamAccountName $username -Name $Name ... -PassThru
}

另外，您使 CSV 处理过于复杂。只需通过ForEach-Object 处理文件列表：

$domain = '@csilab.local'

Set-Location 'C:\Users\Administrator\Desktop\dbs'

'Monday.csv', 'Tuesday.csv', 'Wednesday.csv', 'Thursday.csv', 'Friday.csv' |
  ForEach-Object { Import-Csv $_ } |
  Sort-Object first_name, last_name, phone1 -Unique |
  ForEach-Object {
    $fname = $_.first_name
    $lname = $_.last_name
    $phone = $_.phone1
    ...
  }

Answer 2

您可能想要使用 Try/Catch：

Try {$newusers1=(New-ADUser–GivenName$fname–Surname$lname-HomePhone$phone–Name$Name-DisplayName  $Name  –SamAccountName$username–AccountPassword(ConvertTo-SecureString"1NewPassword"-asplaintext-force) -ChangePasswordAtLogon$true–UserPrincipalName$UPN–Path"dc=csi,dc=lab"-Enabled$true)}
Catch {
    If ($_.Exception.Message -match "account already exists")
    {
        #do whatever here, eg $NewUsers1 = Get-ADUser $Name
    }
}

另外，如果您在通过 ADUC 浏览时看不到用户，则可能是您连接到了不同的 DC。

如上所述，如果命令失败，newuser1 变量将为空。它不会自动与其他用户一起加载，如果这样做会很糟糕。您需要决定如果该帐户已经存在该怎么办，这可能只是使用另一个帐户加载变量，或者执行诸如将“1”附加到 $name 并重试命令之类的操作。