打字稿中的全部承诺并不能解决所有问题

Question

在我的代码中我需要更新模型

{
"customerCode": "CUS15168",
"customerName": "Adam Jenie",
"customerType": "Cash",
"printPackingSlip": "true",
"contacts": [
    {
        "firstName": "Hunt",
        "lastName": "Barlow",
        "email": "huntbarlow@volax.com",
        "deliveryAddress": "805 Division Place, Waumandee, North Carolina, 537",
    },
    {
        "firstName": "Barlow",
        "lastName": "Hunt",
        "email": "huntbarlow@volax.com",
        "deliveryAddress": "805 Division Place, Waumandee, North Carolina, 537",
    }
],
"deliveryAddress": [
    {
        "addressName": "Postal",
        "addressType": "postal address",
        "addressLine1": "plaza street",
        "addressLine2": "broome street",
        "suburb": "Guilford",
        "city": "Oneida",
        "state": "Colorado",
        "postalCode": "3971",
        "country": "Belarus",
        "deliveryInstruction": "test delivery address"
    },
    {
        "addressName": "Physical",
        "addressType": "physical address",
        "addressLine1": "plaza street",
        "addressLine2": "broome street",
        "suburb": "Guilford",
        "city": "Oneida",
        "state": "Colorado",
        "postalCode": "3971",
        "country": "Belarus",
        "deliveryInstruction": "test delivery address"
    }
]
}

我使用 promise all 来实现这一点。在邮递员中，我发送这个对象，但首先它需要添加客户、联系人数组，然后是送货地址数组。我是这样做的。

public async createCustomer(customer: CustomerDTO): Promise<CustomerDTO> {
    let deliveryAddress = [];
    let contacts = [];

    let customerDto = new CustomerDTO();

    customerDto.customerCode = customer.customerCode;
    customerDto.tenantId = customer.tenantId;

    if (customer.contacts.length > 0) {
        customer.contacts.map((element => {
            contacts.push(element);
        }));
        customer.contacts.length = 0;
    }
    if (customer.deliveryAddress.length > 0) {
        customer.deliveryAddress.map((element => {
            deliveryAddress.push(element);
        }));
        customer.deliveryAddress.length = 0;
    }
    const createdCustomer = await this.customerRepo.updateOrCreateCustomer(customer);

    let updatedAddress = deliveryAddress.map(async (address: CustomerDeliveryAddressDto) => {
        return await this.customerRepo.updateDeliveryAddress(address, customerDto, address._id);
    });
    let updatedContacts = contacts.map(async (contact: CustomerContactsDto) => {
        return await this.customerRepo.createOrUpdateContactList(contact, customerDto, contact._id);
    });
    return Promise.all([updatedAddress, updatedContacts]).
        then((results: [Promise<boolean>[], Promise<boolean>[]]) => {
            console.log(results);
            return this.customerRepo.getLastUpdatedCustomer();
        }).
        then((result) => {
            return result;
        }).
        catch(e => {
            console.error(e);
            return e;
        });

}

在客户存储库中

public async updateDeliveryAddress(deliveryAddressDto: CustomerDeliveryAddressDto, customerDto: CustomerDTO, deliveryAddressId: string): Promise<boolean> {
    const customerToBeUpdated = await this.model.findOne({
        customerCode: customerDto.customerCode,
        tenantId: customerDto.tenantId
    });
    if (customerToBeUpdated !== null) {
        if (deliveryAddressId != null || deliveryAddressId != undefined) {

            const result = await this.model.findOneAndUpdate({ _id: customerToBeUpdated._id, deliveryAddress: { $elemMatch: { _id: deliveryAddressId } } },
                {
                    $set: {
                        //code here
                    }
                },
                { 'new': true, 'safe': true, 'upsert': true });
            if (result){
                return true;
            }

        } else {
            const result = await this.model.findOneAndUpdate({ _id: customerToBeUpdated._id },
                {
                    $push: { deliveryAddress: deliveryAddressDto }
                },
                { 'new': true, 'safe': true, 'upsert': true }
            );
            if (result) {
                return true;
            }
        }
    } else {
        return false;
    }
}

问题是它在承诺所有方法时并没有解决所有方法，我需要获取最后更新的客户，但它给出了结果 DeliveryAddress 和带有空数组的联系人。 mongodb 上的客户文档根据需要更新。

Answer 1

您需要直接在平面数组中传递承诺。

Promise.all on MDN

如果iterable包含非promise值，它们将被忽略，但仍计入返回的promise数组值（如果promise被履行）

您可以使用spread operator 轻松完成此操作。

let updatedAddress = deliveryAddress.map(async (address: CustomerDeliveryAddressDto) => {
  return await this.customerRepo.updateDeliveryAddress(address, customerDto, address._id);
});
let updatedContacts = contacts.map(async (contact: CustomerContactsDto) => {
  return await this.customerRepo.createOrUpdateContactList(contact, customerDto, contact._id);
});

// need to give a flat array to Promise.all, so use the `...` spread operator.
return Promise.all([...updatedAddress, ...updatedContacts]).then(/* ... */

另外，既然你已经在使用async / await，你没有理由不能awaitPromise.all调用。

const results = await Promise.all([...updatedAddress, ...updatedContacts]);
console.log(results);
return this.customerRepo.getLastUpdatedCustomer();

Answer 2

你也可以嵌套 Promise.all

let updatedAddress = Promise.all(deliveryAddress.map(async (address: CustomerDeliveryAddressDto) => {
  return await this.customerRepo.updateDeliveryAddress(address, customerDto, address._id);
}));

let updatedContacts = Promise.all(contacts.map(async (contact: CustomerContactsDto) => {
  return await this.customerRepo.createOrUpdateContactList(contact, customerDto, contact._id);
}));


return Promise.all([updatedAddress, updatedContacts])