改进 node.js 代码（续集、承诺和护照）

Question

我是 node.js、sequelize、Bluebird Promise 和 FB 身份验证的新手。

我想为我的 FB 身份验证用户保留一些身份验证详细信息。

在我的模型中，一个用户可以同时拥有多个身份验证（一个用于浏览器，另一个用于移动设备等）。 我需要处理这些身份验证，所以我有下一个关系：

User.hasMany(Auth); Auth.belongsTo(用户);

我编写了这个有效的代码，但我仍在寻找更智能的解决方案。

主要目标是向用户添加身份验证信息。 因此，在保留身份验证信息之前，我会寻找一个持久用户。

function(accessToken, refreshToken, profile, done) {

        console.log("FacebookStrategy_function:\naccessToken: " + accessToken);

    var thatUser=null;

        User.find({
          where: {
            username: profile.username 
          },
          include: [{model: Auth}]
        }).then(function(user) {
          console.log("USER IS #1: %j", user);
          if(user!= null){  // User found in database
            console.log("User " + profile.id + "found in database");
            return user;
          }else{  // First time that user authenticate in app
          var user = User.build({
              username: profile.username,
              givenName: profile.name.givenName,
              familyName: profile.name.familyName
            });
            return user.save();
          }
        }).then(function(user) {
          console.log("USER IS #2: %j", user);
          thatUser=user;

          var auth= Auth.build({
            provider: 'facebook',
            providerId: profile.id,
            accessToken: accessToken
          });

          return user.addAuth(auth);
        }).then(function(auth){
          user=thatUser;
          console.log("USER IS #3: %j", user);
          console.log("done. user and association saved.  auth is: %j", auth);


          done(null, user); // Call FacebookEstrategy's done
        }, function(err) {
            console.log("\nsomething happened persisting user/auth " + err);
            done(err, null); // Propagate error to FacebookEstrategy
        });

      }

有下一个日志：

    FacebookStrategy_function: accessToken: CAACO...
    Executing (default): SELECT "Users".*, "Auths"."id" AS "Auths.id", ... WHERE     "Users"."username"='john.doe'...
    INSERT INTO "Users" ("id","username","givenName","familyName","createdAt","updatedAt") VALUES (DEFAULT,'john.doe',...)
    USER IS #1: null
    Executing (default): INSERT INTO "Users"     ("id","username","givenName","familyName","createdAt","updatedAt") VALUES (DEFAULT,'john.doe',...)
    USER IS #2: {"username":"john.doe","givenName":"John","familyName":"Doe","id":2,"updatedAt":"2014-11-09T19:12:23.250Z","createdAt":"2014-11-09T19:12:23.250Z"}
    Executing (default): SELECT * FROM "Auths" WHERE "UserId" = 2;
    Executing (default): INSERT INTO "Auths" ("id","provider","providerId","accessToken","createdAt","updatedAt","UserId") VALUES (DEFAULT,'facebook','...','CAACO...','2014-11-09 19:12:23.278 +00:00','2014-11-09 19:12:23.278 +00:00',2) RETURNING *;
    USER IS #3: {"username":"john.doe","givenName":"John","familyName":"Doe","id":2,"updatedAt":"2014-11-09T19:12:23.250Z","createdAt":"2014-11-09T19:12:23.250Z"}
    done. user and association saved.  auth is: {"provider":"facebook","providerId":"...","accessToken":"CAACO...","id":2,"UserId":2,"updatedAt":"2014-11-09T19:12:23.278Z","createdAt":"2014-11-09T19:12:23.278Z"}

对我来说处理起来很奇怪，user.addAuth(auth) 返回一个 auth 对象。 在下一个 then 方法中，我希望收到一个用户对象（而不是 auth） 作为解决方法，我在主函数范围内使用了一个糟糕的 thatUser 变量。 有没有更聪明的方法来做到这一点？

在日志中，跟踪“USER IS #3:”显示的是没有身份验证对象的用户。 为什么？

欢迎任何修正或改进

谢谢

Answer 1

如果您正在使用 Promise - 您可以删除 done 回调 - 您可以简单地返回 Promise。如果你真的想要 done 回调 - 你可以调用 .nodeify 而不是显式调用它，尽管返回 Promise 有其他好处，比如未处理的拒绝跟踪。

你也可以使用聚合方法而不是显式的闭包范围：

function(accessToken, refreshToken, profile) {
    console.log("FacebookStrategy_function:\naccessToken: " + accessToken);
    return User.find({
      where: { username: profile.username }, include: [{model: Auth}]
    }).then(function(user) {
      console.log("USER IS #1: %j", user);
      if(user!= null){  // User found in database
        console.log("User " + profile.id + "found in database");
        return user;
      } 
      return User.build({ // first time
          username: profile.username,
          givenName: profile.name.givenName,
          familyName: profile.name.familyName
        }).save();
    }).then(function(user) {
      console.log("USER IS #2: %j", user);
      var auth= Auth.build({
        provider: 'facebook',
        providerId: profile.id,
        accessToken: accessToken
      });
      return [user, user.addAuth(auth)]; // note the array
    }).spread(function(user, auth){ // note the spread
      console.log("USER IS #3: %j", user);
      console.log("done. user and association saved.  auth is: %j", auth);
      return user;
    });
}

现在，如果允许我删除所有 console.logs，这会变得更短：

function(accessToken, refreshToken, profile) {
  return User.find({
      where: { username: profile.username }, include: [{model: Auth}]
  }).then(function(user) {
    return user || User.build({ // first time
      username: profile.username,
      givenName: profile.name.givenName,
      familyName: profile.name.familyName
    }).save();
  }).then(function(user) {
    return Auth.build({
      provider: 'facebook',
      providerId: profile.id,
      accessToken: accessToken
    }).return(user);
  });
}