【问题标题】:Slow Archiving Google Apps Script缓慢归档 Google Apps 脚本
【发布时间】:2020-08-21 20:37:45
【问题描述】:

我正在编写财务跟踪表,并已完成其中的输入部分,并且工作正常。问题是,它在大多数情况下逐行运行时运行非常缓慢。除了它有很多代码之外,我不知道如何加快它的速度或将任何东西放在一起。此外,有问题的函数的开头和结尾的大括号没有连接(当光标在它们旁边时它们都是红色的),我无法理解。任何人都可以帮助清理我的代码以加快速度吗? 这是有问题的功能:

function onClickSubmit(e) {
  var wkbk = SpreadsheetApp.getActiveSpreadsheet();
  var ss = wkbk.getSheetByName("Entry");

  //Bank Details Move
    var bankDeposit = ss.getRange(3,9).getValue();
    var bankWithdrawal = ss.getRange(3,10).getValue();
    var bankDate = ss.getRange(3,12).getValue();
    var targetSheet = wkbk.getSheetByName("BANK DS");
  if(bankDate != ""){
    //Finds first blank cell in column A, to enter new data in:
    var Avals = targetSheet.getRange("A1:A").getValues();
    var targetRow = Avals.filter(String).length + 1;
    var values = ss.getRange("A:A").getValues();
    var bankAmt = (bankDeposit - bankWithdrawal);
    var bankDetail = [[bankDate, bankAmt]];
    targetSheet.getRange(targetRow,1,1,2).setValues(bankDetail);
    targetSheet.getRange(targetRow-1,3).copyTo(targetSheet.getRange(targetRow,3));
    ss.getRange(3,9,1,4).clearContent();
  }
  //Work Chits Move
    var work1Hours = ss.getRange(5,9).getValue();
    var work1Job = ss.getRange(5,10).getValue();
    var work1Rate = ss.getRange(5,11).getValue();
    var work1Date = ss.getRange(5,12).getValue();
    var targetSheet = wkbk.getSheetByName("WORK DS");
  if(work1Date != ""){
    //Finds first blank cell in column A, to enter new data in:
    var Avals = targetSheet.getRange("A1:A").getValues();
    var targetRow = Avals.filter(String).length + 1;
    var values = ss.getRange("A:A").getValues();
    var work1Detail = [[work1Date,work1Job,work1Hours,work1Rate]];
    targetSheet.getRange(targetRow,1,1,4).setValues(work1Detail);
    targetSheet.getRange(targetRow-1,5,1,3).copyTo(targetSheet.getRange(targetRow,5,1,3));
    ss.getRange(5,9,1,4).clearContent();
  }
  var work2Hours = ss.getRange(6,9).getValue();
    var work2Job = ss.getRange(6,10).getValue();
    var work2Rate = ss.getRange(6,11).getValue();
    var work2Date = ss.getRange(6,12).getValue();
    var targetSheet = wkbk.getSheetByName("WORK DS");
  if(work2Date != ""){
    //Finds first blank cell in column A, to enter new data in:
    var Avals = targetSheet.getRange("A1:A").getValues();
    var targetRow = Avals.filter(String).length + 1;
    var values = ss.getRange("A:A").getValues();
    var work2Detail = [[work2Date,work2Job,work2Hours,work2Rate]];
    targetSheet.getRange(targetRow,1,1,4).setValues(work2Detail);
    targetSheet.getRange(targetRow-1,5,1,3).copyTo(targetSheet.getRange(targetRow,5,1,3));
    ss.getRange(6,9,1,4).clearContent();
  }
    var work3Hours = ss.getRange(7,9).getValue();
    var work3Job = ss.getRange(7,10).getValue();
    var work3Rate = ss.getRange(7,11).getValue();
    var work3Date = ss.getRange(7,12).getValue();
    var targetSheet = wkbk.getSheetByName("WORK DS");
  if(work3Date != ""){
    //Finds first blank cell in column A, to enter new data in:
    var Avals = targetSheet.getRange("A1:A").getValues();
    var targetRow = Avals.filter(String).length + 1;
    var values = ss.getRange("A:A").getValues();
    var work3Detail = [[work3Date,work3Job,work3Hours,work3Rate]];
    targetSheet.getRange(targetRow,1,1,4).setValues(work3Detail);
    targetSheet.getRange(targetRow-1,5,1,3).copyTo(targetSheet.getRange(targetRow,5,1,3));
    ss.getRange(7,9,1,4).clearContent();
  }

  //Receipts Move
  var i = 9
  var reDate = ss.getRange(i,12).getValue()
  var targetSheet = wkbk.getSheetByName("RECEIPTS DS");
  if (reDate !=""){
  while (reDate !="") {
    var reAmt = ss.getRange(i,9).getValue();
    var rePlace = ss.getRange(i,10).getValue();
    var reCat = ss.getRange(i,11).getValue();
    var reDate = ss.getRange(i,12).getValue();
    //Finds first blank cell in column A, to enter new data in:
    var Avals = targetSheet.getRange("A1:A").getValues();
    var targetRow = Avals.filter(String).length + 1;
    var values = ss.getRange("A:A").getValues();
    var reDetail = [[reDate,rePlace,reCat,reAmt]];
    targetSheet.getRange(targetRow,1,1,4).setValues(reDetail);
    targetSheet.getRange(targetRow-1,5,1,3).copyTo(targetSheet.getRange(targetRow,5,1,3));
    ss.getRange(i,9,1,4).clearContent();
    i++
  }
  }

  //Safe Move 3, 9, 13 (dates) 3-8, 9-12, 13-18
    var safeDate = ss.getRange(3,6).getValue();
    var targetSheet = wkbk.getSheetByName("SAFE DS");
  for (var i=3;i<9;i++){  
    var safeIn = ss.getRange(i,2).getValue();
    var safeOut = ss.getRange(i,4).getValue();
    var safeCnt = (safeIn - safeOut);
    var safeType = ss.getRange(i,3).getValue();

  if(safeCnt != 0){
    //Finds first blank cell in column A, to enter new data in:
    var Avals = targetSheet.getRange("A1:A").getValues();
    var targetRow = Avals.filter(String).length + 1;
    var values = ss.getRange("A:A").getValues();

    var safeDetail = [[safeDate, safeType,safeCnt]];
    targetSheet.getRange(targetRow,1,1,3).setValues(safeDetail);
//    targetSheet.getRange(targetRow-1,3).copyTo(targetSheet.getRange(targetRow,3));
    ss.getRange(i,2).clearContent();
    ss.getRange(i,4).clearContent();
  }
}
    ss.getRange(3,6).clearContent();
  //Safe Move 9 (rolls) 3-8, 9-12, 13-18
    var safeDate = ss.getRange(9,6).getValue();
    var targetSheet = wkbk.getSheetByName("SAFE DS");
  for (var i=9;i<13;i++){  
    var safeIn = ss.getRange(i,2).getValue();
    var safeOut = ss.getRange(i,4).getValue();
    var safeCnt = (safeIn - safeOut);
    var safeType = ss.getRange(i,3).getValue();

  if(safeCnt != 0){
    //Finds first blank cell in column A, to enter new data in:
    var Avals = targetSheet.getRange("A1:A").getValues();
    var targetRow = Avals.filter(String).length + 1;
    var values = ss.getRange("A:A").getValues();

    var safeDetail = [[safeDate, safeType,safeCnt]];
    targetSheet.getRange(targetRow,1,1,3).setValues(safeDetail);
    ss.getRange(i,2).clearContent();
    ss.getRange(i,4).clearContent();
  }
}
    ss.getRange(9,6).clearContent();
  //Safe Move (loose) 13-18
    var safeDate = ss.getRange(13,6).getValue();
    var targetSheet = wkbk.getSheetByName("SAFE DS");
  for (var i=13;i<19;i++){  
    var safeIn = ss.getRange(i,2).getValue();
    var safeOut = ss.getRange(i,4).getValue();
    var safeCnt = (safeIn - safeOut);
    var safeType = ss.getRange(i,3).getValue();

  if(safeCnt != 0){
    //Finds first blank cell in column A, to enter new data in:
    var Avals = targetSheet.getRange("A1:A").getValues();
    var targetRow = Avals.filter(String).length + 1;
    var values = ss.getRange("A:A").getValues();

    var safeDetail = [[safeDate, safeType,safeCnt]];
    targetSheet.getRange(targetRow,1,1,3).setValues(safeDetail);
    ss.getRange(i,2).clearContent();
    ss.getRange(i,4).clearContent();
  }
}
    ss.getRange(13,6).clearContent();
}

这里是工作表的副本,供您查看它是如何工作的:https://docs.google.com/spreadsheets/d/1Ij7DPqQnVAR9cCpqZRf6QFUIKfgrvLvj-y5gyUPKJMw/edit?usp=sharing

提前致谢!

更新 我接受了两个答案中更彻底的一个,但都提供了极好的洞察力。虽然这个答案有最有用的信息,但另一个答案也增加了很多。对于任何感兴趣的人,我使用了很多这些编辑,并且还通过在循环/if 测试之外调用它们来删除对 SpreadsheetApp 方法的调用,然后构建结果数组。这两个答案的组合使代码加速了大约 400%,所以谢谢你们俩!

为了进一步帮助任何对加速 Google Script 代码感兴趣的人,这是我修改后的函数 请注意,我确实必须保留“A1:A”与 getLastRow() 的一个实例,因为在该特定目标表中,有许多列包含需要忽略的信息:

function onClickSubmit(e) {
  var wkbk = SpreadsheetApp.getActiveSpreadsheet();
  var ss = wkbk.getSheetByName("Entry");

  //Bank Details Move
    var t=ss.getRange(3,9,1,4).getValues()[0];
    var bankDeposit = t[0];
    var bankWithdrawal = t[1];
    var bankDate = t[3];
    var targetSheet = wkbk.getSheetByName("BANK DS");
  if(bankDate != ""){
    var targetRow = targetSheet.getRange(1,1,targetSheet.getLastRow()).getValues().length + 1;
    var bankAmt = (bankDeposit - bankWithdrawal);
    var bankDetail = [[bankDate, bankAmt]];
    targetSheet.getRange(targetRow,1,1,2).setValues(bankDetail);
    targetSheet.getRange(targetRow-1,3).copyTo(targetSheet.getRange(targetRow,3));
    ss.getRange(3,9,1,4).clearContent();
  }
  //Work Chits Move
    var vals=ss.getRange(5,9,3,4).getValues();
    var work1Hours = vals[0][0];
    var work1Job = vals[0][1];
    var work1Rate = vals[0][2];
    var work1Date = vals[0][3];
    var targetSheet = wkbk.getSheetByName("WORK DS");
  if(work1Date != ""){
    var targetRow = targetSheet.getRange(1,1,targetSheet.getLastRow()).getValues().length +1;
    var work1Detail = [[work1Date,work1Job,work1Hours,work1Rate]];
    targetSheet.getRange(targetRow,1,1,4).setValues(work1Detail);
    targetSheet.getRange(targetRow-1,5,1,3).copyTo(targetSheet.getRange(targetRow,5,1,3));
    ss.getRange(5,9,1,4).clearContent();
    targetRow = targetRow + 1;
  }
    var work2Hours = vals[1][0];
    var work2Job = vals[1][1];
    var work2Rate = vals[1][2];
    var work2Date = vals[1][3];
  if(work2Date != ""){
    var work2Detail = [[work2Date,work2Job,work2Hours,work2Rate]];
    targetSheet.getRange(targetRow,1,1,4).setValues(work2Detail);
    targetSheet.getRange(targetRow-1,5,1,3).copyTo(targetSheet.getRange(targetRow,5,1,3));
    ss.getRange(6,9,1,4).clearContent();
    targetRow = targetRow + 1;
  }
    var work3Hours = vals[2][0];
    var work3Job = vals[2][1];
    var work3Rate = vals[2][2];
    var work3Date = vals[2][3];
  if(work3Date != ""){
    var work3Detail = [[work3Date,work3Job,work3Hours,work3Rate]];
    targetSheet.getRange(targetRow,1,1,4).setValues(work3Detail);
    targetSheet.getRange(targetRow-1,5,1,3).copyTo(targetSheet.getRange(targetRow,5,1,3));
    ss.getRange(7,9,1,4).clearContent();
    targetRow = targetRow + 1
  }

  //Receipts Move
  var i = 0
  var targetSheet = wkbk.getSheetByName("RECEIPTS DS");
  var reDetail = [];
  var reVals=ss.getRange(9,9,20,4).getValues();
  var reDate = reVals[0,3]
  var targetRow = targetSheet.getRange(1,1,targetSheet.getLastRow()).getValues().length + 1;
  if (reDate !=""){
  while (reVals[i][3] !="") {
    var reAmt = reVals[i][0];
    var rePlace = reVals[i][1];
    var reCat = reVals[i][2];
    var reDate = reVals[i][3];
    var reDetailNew = [[reDate, rePlace, reCat, reAmt]];
    var reDetail = reDetail.concat(reDetailNew);
    i=i+1
  }
    targetSheet.getRange(targetRow,1,i,4).setValues(reDetail);
    targetSheet.getRange(targetRow-1,5,1,3).copyTo(targetSheet.getRange(targetRow,5,i,3));
    ss.getRange(9,9,i+1,4).clearContent();


  //Safe Move (bills)

    var targetSheet = wkbk.getSheetByName("SAFE DS");
    var Avals = targetSheet.getRange("A1:A").getValues();
    var targetRow = Avals.filter(String).length + 1;
    var safeVals = ss.getRange(3,2,16,5).getValues();
    var safeDate = safeVals[0][4];
  for (var i=0;i<6;i++){
    var safeIn = safeVals[i][0];
    var safeOut = safeVals[i][2];
    var safeCnt = (safeIn - safeOut);
    var safeType = safeVals[i][1];

  if(safeCnt != 0){    
    var safeDetail = [[safeDate, safeType,safeCnt]];
    targetSheet.getRange(targetRow,1,1,3).setValues(safeDetail);
    targetRow = targetRow + 1;
  }
}
  //Safe Move (rolls)
    var safeDate = safeVals[6][4];
  for (var i=6;i<10;i++){  
    var safeIn = safeVals[i][0];
    var safeOut = safeVals[i][2];
    var safeCnt = (safeIn - safeOut);
    var safeType = safeVals[i][1];

  if(safeCnt != 0){
    var safeDetail = [[safeDate, safeType,safeCnt]];
    targetSheet.getRange(targetRow,1,1,3).setValues(safeDetail);
    targetRow = targetRow + 1;
  }
}
  //Safe Move (loose)
    var safeDate = safeVals[10][4];
  for (var i=10;i<16;i++){  
    var safeIn = safeVals[i][0];
    var safeOut = safeVals[i][2];
    var safeCnt = (safeIn - safeOut);
    var safeType = safeVals[i][1];

  if(safeCnt != 0){
    var safeDetail = [[safeDate, safeType,safeCnt]];
    targetSheet.getRange(targetRow,1,1,3).setValues(safeDetail);
    targetRow = targetRow + 1;
  }
}
    ss.getRange(3,2,16,1).clearContent();
    ss.getRange(3,4,16,1).clearContent();
    ss.getRange(3,6,16,1).clearContent();
}
}

【问题讨论】:

    标签: performance google-apps-script optimization google-sheets


    【解决方案1】:

    以下是一些建议:

    我将我的建议作为 cmets 放在您的代码下方。

    一般避免使用 getValue() 使用 getValues() 代替它返回一个二维数据数组。阅读文档并查看调试器中的返回值,以便您真正了解数据的样子:[[row0],[row1],[row2]....]

    并避免使用 A1:A 形式的 A1 符号。使用 Sheet.getRange(1,1,Sheet.getLastRow().... 代替。

    function onClickSubmit(e) {
      var wkbk = SpreadsheetApp.getActiveSpreadsheet();
      var ss = wkbk.getSheetByName("Entry");
      //Bank Details Move
        var bankDeposit = ss.getRange(3,9).getValue();
        var bankWithdrawal = ss.getRange(3,10).getValue();
        var bankDate = ss.getRange(3,12).getValue();
        var targetSheet = wkbk.getSheetByName("BANK DS");
        //var t=ss.getRange(3,9,1,4).getValues()[0];
        //var bankDeposit = t[0];
        //var bankWithdrawal = t[1];
        //var bankDate = t[3];
        //var targetSheet = wkbk.getSheetByName("BANK DS");
      if(bankDate != ""){
        //Finds first blank cell in column A, to enter new data in:
        var Avals = targetSheet.getRange("A1:A").getValues();//This often returns nulls between data last row and max rows  
        var targetRow = Avals.filter(String).length + 1;
        //var targetRow = targetSheet.getRange(1,1,targetSheet.getLastRow()).getValues().length;
        var values = ss.getRange("A:A").getValues();//Same problem as described above
        var bankAmt = (bankDeposit - bankWithdrawal);
        var bankDetail = [[bankDate, bankAmt]];
        targetSheet.getRange(targetRow,1,1,2).setValues(bankDetail);
        targetSheet.getRange(targetRow-1,3).copyTo(targetSheet.getRange(targetRow,3));
        ss.getRange(3,9,1,4).clearContent();
      }
      //Work Chits Move
        var work1Hours = ss.getRange(5,9).getValue();
        var work1Job = ss.getRange(5,10).getValue();
        var work1Rate = ss.getRange(5,11).getValue();
        var work1Date = ss.getRange(5,12).getValue();
        //try as above to get data all at once
        //var vals=ss.getRange(5,9,1,4).getValues();
        //then use vals[0]...
        var targetSheet = wkbk.getSheetByName("WORK DS");
      if(work1Date != ""){
        //Finds first blank cell in column A, to enter new data in:
        var Avals = targetSheet.getRange("A1:A").getValues();
        var targetRow = Avals.filter(String).length + 1;
        var values = ss.getRange("A:A").getValues();
        var work1Detail = [[work1Date,work1Job,work1Hours,work1Rate]];
        targetSheet.getRange(targetRow,1,1,4).setValues(work1Detail);
        targetSheet.getRange(targetRow-1,5,1,3).copyTo(targetSheet.getRange(targetRow,5,1,3));
        ss.getRange(5,9,1,4).clearContent();
      }
      var work2Hours = ss.getRange(6,9).getValue();
        var work2Job = ss.getRange(6,10).getValue();
        var work2Rate = ss.getRange(6,11).getValue();
        var work2Date = ss.getRange(6,12).getValue();
        var targetSheet = wkbk.getSheetByName("WORK DS");
      if(work2Date != ""){
        //Finds first blank cell in column A, to enter new data in:
        var Avals = targetSheet.getRange("A1:A").getValues();
        var targetRow = Avals.filter(String).length + 1;
        var values = ss.getRange("A:A").getValues();
        var work2Detail = [[work2Date,work2Job,work2Hours,work2Rate]];
        targetSheet.getRange(targetRow,1,1,4).setValues(work2Detail);
        targetSheet.getRange(targetRow-1,5,1,3).copyTo(targetSheet.getRange(targetRow,5,1,3));
        ss.getRange(6,9,1,4).clearContent();
      }
        var work3Hours = ss.getRange(7,9).getValue();
        var work3Job = ss.getRange(7,10).getValue();
        var work3Rate = ss.getRange(7,11).getValue();
        var work3Date = ss.getRange(7,12).getValue();
        var targetSheet = wkbk.getSheetByName("WORK DS");
      if(work3Date != ""){
        //Finds first blank cell in column A, to enter new data in:
        var Avals = targetSheet.getRange("A1:A").getValues();
        var targetRow = Avals.filter(String).length + 1;
        var values = ss.getRange("A:A").getValues();
        var work3Detail = [[work3Date,work3Job,work3Hours,work3Rate]];
        targetSheet.getRange(targetRow,1,1,4).setValues(work3Detail);
        targetSheet.getRange(targetRow-1,5,1,3).copyTo(targetSheet.getRange(targetRow,5,1,3));
        ss.getRange(7,9,1,4).clearContent();
      }
    
      //Receipts Move
      var i = 9
      var reDate = ss.getRange(i,12).getValue()
      var targetSheet = wkbk.getSheetByName("RECEIPTS DS");
      if (reDate !=""){
      while (reDate !="") {
        var reAmt = ss.getRange(i,9).getValue();
        var rePlace = ss.getRange(i,10).getValue();
        var reCat = ss.getRange(i,11).getValue();
        var reDate = ss.getRange(i,12).getValue();
        //Finds first blank cell in column A, to enter new data in:
        var Avals = targetSheet.getRange("A1:A").getValues();
        var targetRow = Avals.filter(String).length + 1;
        var values = ss.getRange("A:A").getValues();
        var reDetail = [[reDate,rePlace,reCat,reAmt]];
        targetSheet.getRange(targetRow,1,1,4).setValues(reDetail);
        targetSheet.getRange(targetRow-1,5,1,3).copyTo(targetSheet.getRange(targetRow,5,1,3));
        ss.getRange(i,9,1,4).clearContent();
        i++
      }
      }
    
      //Safe Move 3, 9, 13 (dates) 3-8, 9-12, 13-18
        var safeDate = ss.getRange(3,6).getValue();
        var targetSheet = wkbk.getSheetByName("SAFE DS");
      for (var i=3;i<9;i++){  
        var safeIn = ss.getRange(i,2).getValue();
        var safeOut = ss.getRange(i,4).getValue();
        var safeCnt = (safeIn - safeOut);
        var safeType = ss.getRange(i,3).getValue();
    
      if(safeCnt != 0){
        //Finds first blank cell in column A, to enter new data in:
        var Avals = targetSheet.getRange("A1:A").getValues();
        var targetRow = Avals.filter(String).length + 1;
        var values = ss.getRange("A:A").getValues();
    
        var safeDetail = [[safeDate, safeType,safeCnt]];
        targetSheet.getRange(targetRow,1,1,3).setValues(safeDetail);
    //    targetSheet.getRange(targetRow-1,3).copyTo(targetSheet.getRange(targetRow,3));
        ss.getRange(i,2).clearContent();
        ss.getRange(i,4).clearContent();
      }
    }
        ss.getRange(3,6).clearContent();
      //Safe Move 9 (rolls) 3-8, 9-12, 13-18
        var safeDate = ss.getRange(9,6).getValue();
        var targetSheet = wkbk.getSheetByName("SAFE DS");
      for (var i=9;i<13;i++){  
        var safeIn = ss.getRange(i,2).getValue();
        var safeOut = ss.getRange(i,4).getValue();
        var safeCnt = (safeIn - safeOut);
        var safeType = ss.getRange(i,3).getValue();
    
      if(safeCnt != 0){
        //Finds first blank cell in column A, to enter new data in:
        var Avals = targetSheet.getRange("A1:A").getValues();
        var targetRow = Avals.filter(String).length + 1;
        var values = ss.getRange("A:A").getValues();
    
        var safeDetail = [[safeDate, safeType,safeCnt]];
        targetSheet.getRange(targetRow,1,1,3).setValues(safeDetail);
        ss.getRange(i,2).clearContent();
        ss.getRange(i,4).clearContent();
      }
    }
        ss.getRange(9,6).clearContent();
      //Safe Move (loose) 13-18
        var safeDate = ss.getRange(13,6).getValue();
        var targetSheet = wkbk.getSheetByName("SAFE DS");
      for (var i=13;i<19;i++){  
        var safeIn = ss.getRange(i,2).getValue();
        var safeOut = ss.getRange(i,4).getValue();
        var safeCnt = (safeIn - safeOut);
        var safeType = ss.getRange(i,3).getValue();
    
      if(safeCnt != 0){
        //Finds first blank cell in column A, to enter new data in:
        var Avals = targetSheet.getRange("A1:A").getValues();
        var targetRow = Avals.filter(String).length + 1;
        var values = ss.getRange("A:A").getValues();
    
        var safeDetail = [[safeDate, safeType,safeCnt]];
        targetSheet.getRange(targetRow,1,1,3).setValues(safeDetail);
        ss.getRange(i,2).clearContent();
        ss.getRange(i,4).clearContent();
      }
    }
        ss.getRange(13,6).clearContent();
    }
    

    【讨论】:

      【解决方案2】:

      您的脚本很慢,因为它多次调用SpreadsheetApp 方法。为了提高它的性能,您应该更改逻辑以减少这些调用并使用数组来操作数据。

      I.E.而不是使用多个getValue() 只使用一个getValues(),您甚至可以使用getDatatRange() 来获取工作表的“数据范围”(包含所有具有数据的单元格的范围,包括它们之间的空白单元格),然后使用getValues() 获取所有工作表值。

      根据经验,避免在循环中使用SpreadsheetApp 方法(for、while 等)

      【讨论】:

        猜你喜欢
        • 1970-01-01
        • 2015-08-12
        • 1970-01-01
        • 2018-01-22
        • 2023-03-26
        • 1970-01-01
        • 2014-11-14
        • 1970-01-01
        • 1970-01-01
        相关资源
        最近更新 更多