PHP 中的多维数组 - 如何使用 foreach 添加值

Question

我有一个定义如下的多维数组

$SquadList = array('name', 'position', 'dob', 'nation', 'games', 'goals', 'assists');

我正在循环几个 foreach 循环并存储来自 JSON 的数据

foreach ($season as $key => $squad){
$SquadList[0] = $squad['full_name'];
$SquadList[1] = $squad['position'];
$SquadList[2] = gmdate("d-m-y", $birthday);
$SquadList[3] = $squad['nationality'];
$SquadList[4] = $squad['appearances_overall'];
$SquadList[5] = $squad['goals_overall'];
$SquadList[6] = $squad['assists_overall']; }

foreach ($season1 as $key => $squad){
$SquadList[0] = $squad['full_name'];
$SquadList[1] = $squad['position'];
$SquadList[2] = gmdate("d-m-y", $birthday);
$SquadList[3] = $squad['nationality'];
$SquadList[4] = $squad['appearances_overall'];
$SquadList[5] = $squad['goals_overall'];
$SquadList[6] = $squad['assists_overall'];

代码很乱。输出应该是 30+ 时只有 2 个元素

我试过array_push如下

array_push($SquadList['name'], $squad['full_name'];

Answer 1

我不确定我的问题是否正确，但我想你希望它的结构如下：

$SquadList = []; // define it as an array
$ctr = 0; // define a counter that would be used in the two iterations

foreach ($season as $key => $squad){
    $SquadList[$ctr][0] = $squad['full_name'];
    $SquadList[$ctr][1] = $squad['position'];
    $SquadList[$ctr][2] = gmdate("d-m-y", $birthday);
    $SquadList[$ctr][3] = $squad['nationality'];
    $SquadList[$ctr][4] = $squad['appearances_overall'];
    $SquadList[$ctr][5] = $squad['goals_overall'];
    $SquadList[$ctr][6] = $squad['assists_overall'];
    $ctr++; // increase counter
}

foreach ($season1 as $key => $squad){
    $SquadList[$ctr][0] = $squad['full_name'];
    $SquadList[$ctr][1] = $squad['position'];
    $SquadList[$ctr][2] = gmdate("d-m-y", $birthday);
    $SquadList[$ctr][3] = $squad['nationality'];
    $SquadList[$ctr][4] = $squad['appearances_overall'];
    $SquadList[$ctr][5] = $squad['goals_overall'];
    $SquadList[$ctr][6] = $squad['assists_overall'];
    $ctr++; // increase counter
}

Answer 2

你有两个结果的原因是因为你得到了每个赛季的最后一支球队。发生这种情况是因为每次迭代一个赛季，它都会覆盖之前的阵容。

要解决这个问题，$SquadList 必须是一个数组。但是你必须一次分配它的所有成员，否则每次添加成员时数组都会增加。

填充数组数组

foreach ($season as $key => $squad) {
    $squadList[] = [
        $squad['full_name'],
        $squad['position'],
        gmdate("d-m-y", $squad['birthday']),
        $squad['nationality'],
        $squad['appearances_overall'],
        $squad['goals_overall'],
        $squad['assists_overall']
    ];
}

请注意我所做的一些更改：

1. 我删除了 $squadList 上的大写字母，因为约定以表示对象的大写字母开头，而不是普通的旧变量
2. $birthday 未定义，所以我做了一个有根据的猜测

清理代码

您提到“代码很乱”。这是一个非常健康的观察结果。

您注意到的是两件事的结果：

1. 您的代码在重复自己（违反 DRY - 不要重复自己）
2. 需要遵循 PSR-12 的约定

所以让我们摆脱代码重复

重构

当你开始重复自己时，这就是将事物拉入函数的信号

function buildSquad(array $season)
{
   foreach ($season as $key => $squad) {
        $squadList[] = [
            $squad['full_name'],
            $squad['position'],
            gmdate("d-m-y", $squad['birthday']),
            $squad['nationality'],
            $squad['appearances_overall'],
            $squad['goals_overall'],
            $squad['assists_overall']
        ];
    }
    return $squadList;
}

$squadList = [];

// if you just want to lump them all together
$squadList[] = buildSquad($season);
$squadList[] = buildSquad($season2);
// etc