河内塔 C++（使用递归）

Question

我编写了以下代码作为练习。
我在打印目标堆栈时得到不正确的输出。
谁能指出我哪里出错了？

//Tower of Hanoi using Stacks!
#include<iostream.h>
#include<conio.h>
#include<stdlib.h>

class Stack
{
private:
    int *t;
    int length, top;

public:
    Stack(int len)
    {
        length=len;
        t= new int[len];
        top=-1;
    }

    ~Stack()
    {
        delete []t;
    }

    void push(int d)
    {
        top++;
        t[top]=d;
    }

    int pop()
    {
        top--;
        return t[top+1];
    }

    void printstack()
    {
        int cur=top;
        while(cur>-1)
        {
            cout<<t[cur]<<endl;
            cur--;
        }
    }
};

void MoveTowerofHanoi(int disk, Stack *source, Stack *temp, Stack *destination)
{
    if (disk==0)
    {
        destination->push(source->pop());
    }
    else
    {
        MoveTowerofHanoi(disk-1,source,temp,destination);
        destination->push(source->pop());
        MoveTowerofHanoi(disk-1,temp,destination,source);
    }
}

void main()
{
    clrscr();
    int disks;
    cout<<"Enter the number of disks!"<<endl;
    cin>>disks;
    Stack* source=new Stack(disks);
    for(int i=0; i<disks; i++) {
        source->push(disks-i);
    }
    cout<<"Printing Source!"<<endl;
    source->printstack();
    Stack* temp=new Stack(disks);
    Stack* destination=new Stack(disks);
    MoveTowerofHanoi(disks,source,temp,destination);
    cout<<"Printing Destination!"<<endl;
    destination->printstack();
    getch();
}

这是我得到的输出：

Enter the no. of disks!  
3  
Printing Source!  
1  
2  
3  
Printing Destination!  
-4

---

编辑后代码如下：

    void MoveTowerofHanoi(int disk, Stack *source, Stack *destination, Stack *temp)
{
    if (disk==1)
    {
        destination->push(source->pop());
    }
    else
    {
        MoveTowerofHanoi(disk-1,source,temp,destination);
        destination->push(source->pop());
        MoveTowerofHanoi(disk-1,temp,destination,source);
    }
}

第一个错误是：

void MoveTowerofHanoi(int disk, Stack *source, Stack *temp, Stack *destination)

第二个是：

if (disk==0)

非常感谢大家的帮助！

---

对堆栈类所做的更改：

void push(int d)
{
     if(top<length-1)
    {
    top++;
    t[top]=d;
    }

}

int pop()
{
    if(top>-1)
    {
    top--;
    return t[top+1];
    }
}

Answer 1

这行得通：

//Tower of Hanoi using Stacks!
#include<iostream>
//#include<conio.h>
#include<stdlib.h>
#include<vector>
#include<algorithm>
using namespace std;

void print_elem(int elem)
{
    cout << elem << endl;       
}

class Stack{
public:
    void push(int d){t.push_back(d);}
    int pop()
    {
        int d=t.back();
        t.pop_back();
        return d;
    }
    void printstack()
    {
        for_each(t.rbegin(),t.rend(),print_elem);
    }
private:
    vector<int> t;

};

void MoveTowerofHanoi(int disk, Stack *source, Stack *temp, Stack *destination)
{
    if (disk==1)
    {
        destination->push(source->pop());
    }
    else
    {
        MoveTowerofHanoi(disk-1,source,destination,temp);
        destination->push(source->pop());
        MoveTowerofHanoi(disk-1,temp,source,destination);
    }
}

int main()
{
    int disks;
    cout<<"Enter the number of disks!"<<endl;
    cin>>disks;
    Stack* source = new Stack();
    for(int i=disks; i>0; --i) {
        source->push(i);
    }

    cout<<"Printing Source!"<<endl;
    source->printstack();
    Stack* temp = new Stack();
    Stack* destination = new Stack();
    MoveTowerofHanoi(disks,source,temp,destination);
    cout<<"Printing Destination!"<<endl;
    destination->printstack();
    delete source;
    delete temp;
    delete destination;
}