【发布时间】:2018-09-10 12:05:04
【问题描述】:
我使用DRF为库存中的产品创建了一个API,可以通过以下端点url(r'products/$', views.InventoryList.as_view(), name='product-list')访问。
当通过邮递员发出GET 请求时,我得到了正确的查询集,总共有11 产品:
[
{
"id": 1,
"name": "Biscuits",
"description": "Papadopoulou Biscuits",
"price": "2.52",
"comments": [
{
"id": 1,
"title": "First comments for this",
"comments": "Very tasty",
"rating": 8,
"created_by": "xx"
}
]
},
{
"id": 2,
"name": "Rice",
"description": "Agrino Rice",
"price": "3.45",
"comments": []
},
{
"id": 3,
"name": "Spaghetti",
"description": "Barilla",
"price": "2.10",
"comments": []
},
{
"id": 4,
"name": "Canned Tomatoes",
"description": "Kyknos",
"price": "3.40",
"comments": []
},
{
"id": 5,
"name": "Bacon",
"description": "Nikas Bacon",
"price": "2.85",
"comments": []
},
{
"id": 6,
"name": "Croissants",
"description": "Molto",
"price": "3.50",
"comments": []
},
{
"id": 7,
"name": "Beef",
"description": "Ground",
"price": "12.50",
"comments": []
},
{
"id": 8,
"name": "Flour",
"description": "Traditional Flour",
"price": "3.50",
"comments": []
},
{
"id": 9,
"name": "Oregano",
"description": "Traditional oregano",
"price": "0.70",
"comments": []
},
{
"id": 10,
"name": "Tortellini",
"description": "Authentic tortellini",
"price": "4.22",
"comments": []
},
{
"id": 11,
"name": "Milk",
"description": "Delta",
"price": "1.10",
"comments": []
}
]
然后我写了一个测试(使用 pytest )来测试这个端点:
import pytest
import pytest_django
from django.urls import reverse
from rest_framework import status
from rest_framework.test import APITestCase
class TestInventoryList(APITestCase):
@pytest.mark.django_db
def test_get_product_list(self):
url = reverse('product-list')
response = self.client.get(url)
print(response.json())
self.assertEqual(response.status_code, status.HTTP_200_OK)
self.assertEqual(len(response.json()), 11) # <-- TC fails here
但它失败了,因为 response.json() 只返回前 9 个对象:
[{
'id': 1,
'name': 'Biscuits',
'description': 'Papadopoulou Biscuits',
'comments': [],
'price': '2.52'
}, {
'id': 2,
'name': 'Rice',
'description': 'Agrino Rice',
'comments': [],
'price': '3.45'
}, {
'id': 3,
'name': 'Spaghetti',
'description': 'Barilla',
'comments': [],
'price': '2.10'
}, {
'id': 4,
'name': 'Canned Tomatoes',
'description': 'Kyknos',
'comments': [],
'price': '3.40'
}, {
'id': 5,
'name': 'Bacon',
'description': 'Nikas Bacon',
'comments': [],
'price': '2.85'
}, {
'id': 6,
'name': 'Croissants',
'description': 'Molto',
'comments': [],
'price': '3.50'
}, {
'id': 7,
'name': 'Beef',
'description': 'Ground',
'comments': [],
'price': '12.50'
}, {
'id': 8,
'name': 'Flour',
'description': 'Traditional Flour',
'comments': [],
'price': '3.50'
}, {
'id': 9,
'name': 'Oregano',
'description': 'Traditional oregano',
'comments': [],
'price': '0.70'
}]
这里有几个观察:
- 在我的测试用例中返回的查询集不包含我的第一个产品的 cmets,尽管通过邮递员访问时我可以看到 cmets。
Comments是一个不同的django模型,可通过此嵌套端点访问:url(r'^products/(?P<product_id>[0-9]+)/comments/$', views.CommentsList.as_view()) - 我使用
POST和API身份验证令牌插入了最后两个产品以及我的第一个产品的评论(后一个查询集中没有返回)。这是我应该以某种方式包含在我的测试用例中的信息吗?
编辑
models.py
from django.db import models
from django.contrib.auth.models import User
class Product(models.Model):
name = models.CharField(max_length=255)
description = models.TextField()
price = models.DecimalField(decimal_places=2, max_digits=20)
class Comments(models.Model):
product = models.ForeignKey(Product, related_name='comments')
title = models.CharField(max_length=255)
comments = models.TextField()
rating = models.IntegerField()
created_by = models.ForeignKey(User)
urls.py
from django.conf.urls import url
from . import views
urlpatterns = [
url(r'products/$', views.InventoryList.as_view(), name='product-list'),
url(r'^products/(?P<product_id>[0-9]+)/$', views.InventoryDetail.as_view()),
url(r'^products/(?P<product_id>[0-9]+)/comments/$', views.CommentsList.as_view()),
url(r'^products/(?P<product_id>[0-9]+)/comments/(?P<comment_id>[0-9]+)/$', views.CommentsDetail.as_view()),
]
views.py
from rest_framework import generics
from rest_framework.permissions import IsAuthenticatedOrReadOnly
from .models import Product, Comments
from .serializers import ProductSerializer, CommentSerializer
from .permissions import IsAdminOrReadOnly, IsOwnerOrReadOnly
class InventoryList(generics.ListCreateAPIView):
queryset = Product.objects.all()
serializer_class = ProductSerializer
permission_classes = (IsAdminOrReadOnly, )
lookup_url_kwarg = 'product_id'
class InventoryDetail(generics.RetrieveUpdateAPIView):
queryset = Product.objects.all()
serializer_class = ProductSerializer
permission_classes = (IsAdminOrReadOnly, )
lookup_url_kwarg = 'product_id'
class CommentsList(generics.ListCreateAPIView):
serializer_class = CommentSerializer
permission_classes = (IsAuthenticatedOrReadOnly, )
lookup_url_kwarg = 'product_id'
def perform_create(self, serializer):
serializer.save(created_by=self.request.user, product_id=self.kwargs['product_id'])
def get_queryset(self):
product = self.kwargs['product_id']
return Comments.objects.filter(product__id=product)
class CommentsDetail(generics.RetrieveUpdateDestroyAPIView):
serializer_class = CommentSerializer
permission_classes = (IsAuthenticatedOrReadOnly, IsOwnerOrReadOnly)
lookup_url_kwarg = 'comment_id'
def get_queryset(self):
comment = self.kwargs['comment_id']
return Comments.objects.filter(id=comment)
permissions.py
from rest_framework.permissions import BasePermission, SAFE_METHODS
class IsAdminOrReadOnly(BasePermission):
def has_permission(self, request, view):
if request.method in SAFE_METHODS:
return True
else:
return request.user.is_staff
class IsOwnerOrReadOnly(BasePermission):
def has_object_permission(self, request, view, obj):
if request.method in SAFE_METHODS:
return True
return obj.created_by == request.user
【问题讨论】:
-
想到的事情:不同的数据库或用于测试的不同分页设置。
-
您有什么具体的检查可以让我验证您的两个建议吗?据我记得,我没有改变任何关于分页的东西,我只在我的虚拟环境中使用一个数据库。您认为问题可能与 API 令牌有关吗?
-
至于db,看表中是否有实体:测试加
assert Product.objects.get(pk=10).name == 'Tortellini',测试是否通过? -
至于分页,再想想这可能不是问题,因为您也错过了第一个产品的 cmets。
-
为什么不使用
setUpClass或setUpTestData之类的东西来测试您的视图?它将更加健壮并且独立于您的生产数据。
标签: python django django-rest-framework pytest django-testing