【问题标题】:Shuffle a list of strings in C++随机播放 C++ 中的字符串列表
【发布时间】:2020-11-23 20:06:50
【问题描述】:

我尝试随机播放以下字符串列表:

list<string> l({"10000007", "1", "4", "5", "7", "12", "23", "25", "26", "27", "30", "31", "32", "44", "46", "47", "59", "65", "91"})

我所有的尝试都失败了。这是我最好的尝试之一。

试试 1

基本上我从这个回答Randomize a std::list<std::string>复制过来

#include <iostream>
#include <functional>
#include <iterator>
#include <algorithm>
#include <string>
#include <list>
#include <vector>
#include <random>
#include <numeric>

int main() {
    std::list<std::string> l({"10000007", "1", "4", "5", "7", "12", "23", "25", "26", "27", "30", "31", "32", "44", "46", "47", "59", "65", "91"});
    std::vector<std::reference_wrapper<std::string>> v(l.cbegin(), l.cend());
    std::random_device rd;
    std::mt19937 generator(rd());
    std::shuffle(v.begin(), v.end(), generator);
    std::cout << "Original list:\n";
    std::copy(l.cbegin(), l.cend(), std::ostream_iterator<std::string>(std::cout, " "));
    std::cout << "\nShuffled view:\n";
    std::copy(v.cbegin(), v.cend(), std::ostream_iterator<std::string>(std::cout, " "));
}

我有这个错误跟踪:

In file included from /usr/include/c++/7/vector:62:0,
                 from /usr/include/c++/7/functional:61,
                 from prueba.cpp:2:
/usr/include/c++/7/bits/stl_construct.h: In instantiation of ‘void std::_Construct(_T1*, _Args&& ...) [with _T1 = std::reference_wrapper<std::__cxx11::basic_string<char> >; _Args = {const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&}]’:
/usr/include/c++/7/bits/stl_uninitialized.h:83:18:   required from ‘static _ForwardIterator std::__uninitialized_copy<_TrivialValueTypes>::__uninit_copy(_InputIterator, _InputIterator, _ForwardIterator) [with _InputIterator = std::_List_const_iterator<std::__cxx11::basic_string<char> >; _ForwardIterator = std::reference_wrapper<std::__cxx11::basic_string<char> >*; bool _TrivialValueTypes = false]’
/usr/include/c++/7/bits/stl_uninitialized.h:134:15:   required from ‘_ForwardIterator std::uninitialized_copy(_InputIterator, _InputIterator, _ForwardIterator) [with _InputIterator = std::_List_const_iterator<std::__cxx11::basic_string<char> >; _ForwardIterator = std::reference_wrapper<std::__cxx11::basic_string<char> >*]’
/usr/include/c++/7/bits/stl_uninitialized.h:289:37:   required from ‘_ForwardIterator std::__uninitialized_copy_a(_InputIterator, _InputIterator, _ForwardIterator, std::allocator<_Tp>&) [with _InputIterator = std::_List_const_iterator<std::__cxx11::basic_string<char> >; _ForwardIterator = std::reference_wrapper<std::__cxx11::basic_string<char> >*; _Tp = std::reference_wrapper<std::__cxx11::basic_string<char> >]’
/usr/include/c++/7/bits/stl_vector.h:1331:33:   required from ‘void std::vector<_Tp, _Alloc>::_M_range_initialize(_ForwardIterator, _ForwardIterator, std::forward_iterator_tag) [with _ForwardIterator = std::_List_const_iterator<std::__cxx11::basic_string<char> >; _Tp = std::reference_wrapper<std::__cxx11::basic_string<char> >; _Alloc = std::allocator<std::reference_wrapper<std::__cxx11::basic_string<char> > >]’
/usr/include/c++/7/bits/stl_vector.h:1299:23:   required from ‘void std::vector<_Tp, _Alloc>::_M_initialize_dispatch(_InputIterator, _InputIterator, std::__false_type) [with _InputIterator = std::_List_const_iterator<std::__cxx11::basic_string<char> >; _Tp = std::reference_wrapper<std::__cxx11::basic_string<char> >; _Alloc = std::allocator<std::reference_wrapper<std::__cxx11::basic_string<char> > >]’
/usr/include/c++/7/bits/stl_vector.h:414:26:   required from ‘std::vector<_Tp, _Alloc>::vector(_InputIterator, _InputIterator, const allocator_type&) [with _InputIterator = std::_List_const_iterator<std::__cxx11::basic_string<char> >; <template-parameter-2-2> = void; _Tp = std::reference_wrapper<std::__cxx11::basic_string<char> >; _Alloc = std::allocator<std::reference_wrapper<std::__cxx11::basic_string<char> > >; std::vector<_Tp, _Alloc>::allocator_type = std::allocator<std::reference_wrapper<std::__cxx11::basic_string<char> > >]’
prueba.cpp:13:76:   required from here
/usr/include/c++/7/bits/stl_construct.h:75:7: error: binding reference of type ‘std::__cxx11::basic_string<char>&’ to ‘const std::__cxx11::basic_string<char>’ discards qualifiers
     { ::new(static_cast<void*>(__p)) _T1(std::forward<_Args>(__args)...); }
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/c++/7/bits/std_function.h:44:0,
                 from /usr/include/c++/7/functional:58,
                 from prueba.cpp:2:
/usr/include/c++/7/bits/refwrap.h:334:7: note:   initializing argument 1 of ‘std::reference_wrapper<_Tp>::reference_wrapper(_Tp&) [with _Tp = std::__cxx11::basic_string<char>]’
       reference_wrapper(_Tp& __indata) noexcept
       ^~~~~~~~~~~~~~~~~

我试图理解 reference_wrapper 在这个例子中做了什么,但没有成功。

其他尝试

我对 classical 组合的所有尝试也都失败了...random_engineshufflesrand 的跟踪错误有数千行。

为什么不转换成整数?

在我的原始代码中,有两个 .json 文件,json 始终具有字符串格式的键。我知道我可以将字符串列表转换为整数列表,但问题是我正在创建算法并且有:

  • 2000 个列表
  • 算法中的 2000 次迭代
  • 您必须在每次迭代(字符串到 int、int 到字符串...)进行多次这种转换

所以我认为这个选项在计算上会非常昂贵。

提前致谢。

【问题讨论】:

    标签: c++ string list random shuffle


    【解决方案1】:

    在这一行:

    std::vector<std::reference_wrapper<std::string>> v(l.cbegin(), l.cend());
    

    您正在使用const_iterators 构造向量,这会在从const std::string 构造reference_wrapper&lt;std::string&gt;s 时导致类型不匹配错误。

    相反,您需要非常量迭代器,如下所示:

    std::vector<std::reference_wrapper<std::string>> v(l.begin(), l.end());
    

    这是demo

    【讨论】:

      【解决方案2】:

      cbegin() 成员函数返回一个 const_iterator,当取消引用它时返回一个 const std::string&amp;

      vector 的创建更改为:

      std::vector<std::reference_wrapper<const std::string>> v(l.cbegin(), l.cend());
      

      Demo

      【讨论】:

        【解决方案3】:

        我首先会质疑使用std::list 的用途/需要。在这种情况下,您似乎只使用list 来初始化vector。既然如此,还不如直接初始化使用vector

        #include <iostream>
        #include <functional>
        #include <iterator>
        #include <algorithm>
        #include <string>
        #include <list>
        #include <vector>
        #include <random>
        #include <numeric>
        
        int main() {
            std::vector<std::string> v({"10000007", "1", "4", "5", "7", "12", "23", "25", "26", "27", "30", "31", "32", "44", "46", "47", "59", "65", "91"});
            std::random_device rd;
        
            std::cout << "Original list:\n";
            std::copy(v.cbegin(), v.cend(), std::ostream_iterator<std::string>(std::cout, " "));
        
            std::mt19937 generator(rd());
            std::shuffle(v.begin(), v.end(), generator);
        
            std::cout << "\nShuffled view:\n";
            std::copy(v.cbegin(), v.cend(), std::ostream_iterator<std::string>(std::cout, " "));
        
            std::cout << "\n";    
        }
        

        如果你真的坚持使用列表,你可以去掉引用包装器,它会起作用:

        #include <iostream>
        #include <functional>
        #include <iterator>
        #include <algorithm>
        #include <string>
        #include <list>
        #include <vector>
        #include <random>
        #include <numeric>
        
        int main() {
            std::list<std::string> l({"10000007", "1", "4", "5", "7", "12", "23", "25", "26", "27", "30", "31", "32", "44", "46", "47", "59", "65", "91"});
            std::vector<std::string> v(l.cbegin(), l.cend());
            std::random_device rd;
            std::mt19937 generator(rd());
            std::shuffle(v.begin(), v.end(), generator);
            std::cout << "Original list:\n";
            std::copy(l.cbegin(), l.cend(), std::ostream_iterator<std::string>(std::cout, " "));
            std::cout << "\nShuffled view:\n";
            std::copy(v.cbegin(), v.cend(), std::ostream_iterator<std::string>(std::cout, " "));
        }
        

        ...但我看不出有什么意义。

        就存储整数与字符串的成本而言:只要您使用的是相对较新的编译器,因此其(库的)std::string 实现具有短字符串优化,两者之间可能没有太大区别二。如果您(可能)需要支持缺乏短字符串优化的旧版编译器,这会大大增加您转换和存储 ints 而不是存储字符串的机会。

        问题很简单:如果没有短字符串优化,每个字符串都会分配一个堆来存储实际数据。该堆分配可能很容易比与 int 相互转换要慢(但您需要进行测试才能确定)。

        对于那些真正关心速度的人来说,理想的情况可能是对整个 json 文件进行内存映射,然后为您关心的值创建 string_view 对象。然后,您可以打乱string_view 对象,并按照您认为合适的方式将它们打印出来(或其他任何内容)——但所有这些都只包含指向原始数据的指针,因此您不会全部复制基础数据。

        【讨论】:

          猜你喜欢
          • 1970-01-01
          • 2017-04-11
          • 2017-08-16
          • 2016-04-28
          • 1970-01-01
          • 1970-01-01
          • 2023-01-23
          • 1970-01-01
          • 1970-01-01
          相关资源
          最近更新 更多